Re: [BucketingSink] incorrect indexing of part files, when part suffix is specified

2018-07-06 Thread Rinat
Hi Mingey ! I’ve implemented the group of tests, that shows that problem exists only when part suffix is specified and file in pending state exists here is an exception

Re: [BucketingSink] incorrect indexing of part files, when part suffix is specified

2018-06-25 Thread Rinat
Hi Mingey ! Thx for your reply, really, have no idea why everything works in your case, I have implemented unit tests in my PR which shows, that problem exists. Please, let me know which Flink version do you use ? Current fix is actual for current master branch, here it an example of unit

Re: [BucketingSink] incorrect indexing of part files, when part suffix is specified

2018-06-23 Thread zhangminglei
Hi, Rinat I tried this situation you said and it works fine for me. The partCounter incremented as we hope. When the new part file is created, I did not see any same part index. Here is my code for that, you can take a look. In my case, the max index of part file is part-0-683PartSuffix, other

Re: [BucketingSink] incorrect indexing of part files, when part suffix is specified

2018-06-23 Thread Rinat
Hi mates, could anyone please have a look on my PR, that fixes issue of incorrect indexing in BucketingSink component ? Thx > On 18 Jun 2018, at 10:55, Rinat wrote: > > I’ve created a JIRA issue https://issues.apache.org/jira/browse/FLINK-9603 >

Re: [BucketingSink] incorrect indexing of part files, when part suffix is specified

2018-06-18 Thread Rinat
I’ve created a JIRA issue https://issues.apache.org/jira/browse/FLINK-9603 and added a proposal with PR. Thx > On 16 Jun 2018, at 17:21, Rinat wrote: > > Hi mates, since 1.5 release, BucketingSink has ability to configure suffix of > the

[BucketingSink] incorrect indexing of part files, when part suffix is specified

2018-06-16 Thread Rinat
Hi mates, since 1.5 release, BucketingSink has ability to configure suffix of the part file. It’s very useful, when it’s necessary to set specific extension of the file. During the usage, I’ve found the issue - when new part file is created, it has the same part index, as index of just closed