Re: Missing annotation in SimpleJdbcConnectionProvider.java ?

2020-10-12 Thread Kenzyme
After careful examination, seems like it should be marked as @Internal since this class is located in package org.apache.flink.connector.jdbc.internal.connection. Here is my PR related to this https://github.com/apache/flink/pull/13603 . Thanks a lot! Kenzyme Le ‐‐‐ Original Message

Missing annotation in SimpleJdbcConnectionProvider.java ?

2020-10-12 Thread Kenzyme
Hi, I would like to know if class [SimpleJdbcConnectionProvider](https://github.com/apache/flink/blob/master/flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/internal/connection/SimpleJdbcConnectionProvider.java).java should be marked as @Internal or