Re: A little typo in ClusterConnection

2019-03-14 Thread Stack
File an issue Kevin? Maybe attach a patch? Thank you, S On Wed, Mar 13, 2019 at 1:51 AM kevin su wrote: > Hi, > > I clone the latest the hbase from github. > i found the comment on the top in ClusterConnection from > org.apache.hadoop.hbase.client. > > /** > * > > * Licensed to the Apache

Re: When should we use volatile modifier in HMaster?

2019-03-14 Thread Stack
On Thu, Mar 14, 2019 at 12:34 AM yuhang li <89389114...@gmail.com> wrote: > Hi all, I'm developing some new features based on HBase-1.2.9 Its best to develop against master first and then we backport to other branches. You've seen announcements that hbase-1.2 is sunsetting that it'll be

When should we use volatile modifier in HMaster?

2019-03-14 Thread yuhang li
Hi all, I'm developing some new features based on HBase-1.2.9 and found a weird thing that, in class HMaster some properties are volatile, while others are not volatile and I haven't found any synchronization for them. As far as I know, volatile is use to to guarantee visibility among multiple