Re: Help with integrating Ignite(as JCache) with JBoss EAP 6.4

Yakov, TC seems to be ok, could you please review https://github.com/apache/ignite/pull/345/files before comit? On Thu, Dec 17, 2015 at 1:27 PM, Yakov Zhdanov wrote: > Anton, can you please let us know if changes have been merged? > > --Yakov > > 2015-12-16 17:00 GMT+03:00

Re: Help with integrating Ignite(as JCache) with JBoss EAP 6.4

Anton, can you please let us know if changes have been merged? --Yakov 2015-12-16 17:00 GMT+03:00 Anton Vinogradov : > Val, > Yes, Please check my pull-request > https://github.com/apache/ignite/pull/345 > I'll megre changes tomorrow morning in case everything is ok &

Re: Help with integrating Ignite(as JCache) with JBoss EAP 6.4

Seems fair to me. Sam or Alex Goncharuk, can any of you review this as well? --Yakov 2015-12-17 13:39 GMT+03:00 Anton Vinogradov : > Yakov, > TC seems to be ok, could you please review > https://github.com/apache/ignite/pull/345/files before comit? > > On Thu, Dec 17,

Re: Help with integrating Ignite(as JCache) with JBoss EAP 6.4

Looks good to me as well. However, shouldn't any tests be added as well?

Re: Help with integrating Ignite(as JCache) with JBoss EAP 6.4

PR merged to branch ignite-1.5. Issue not closed with reason: need to write tests. On Thu, Dec 17, 2015 at 1:59 PM, Alexey Goncharuk < alexey.goncha...@gmail.com> wrote: > Looks good to me as well. However, shouldn't any tests be added as well? >

Re: Help with integrating Ignite(as JCache) with JBoss EAP 6.4

Juan, I've checked fix and pushed it to ignite-1.5. On Mon, Dec 14, 2015 at 3:29 PM, Yakov Zhdanov wrote: > Juan, > > Anton Vinogradov has identified the problem in cache manager and fixed it > (one-liner fix) and will check tc today. If this does not break anything, > we

Re: Help with integrating Ignite(as JCache) with JBoss EAP 6.4

Completely agree with Juan. Setting class loader only for default configuration is definitely not enough for the most use cases. I reopened the ticket. Anton, will you have a chance to finish the fix? -Val -- View this message in context:

Re: Help with integrating Ignite(as JCache) with JBoss EAP 6.4

Juan, Anton Vinogradov has identified the problem in cache manager and fixed it (one-liner fix) and will check tc today. If this does not break anything, we will include it into ignite-1.5 release which should be available early next week. --Yakov 2015-12-08 18:18 GMT+03:00 juanavelez

Re: Help with integrating Ignite(as JCache) with JBoss EAP 6.4

Thanks, Juan! We are very glad to hear that Ignite is helpful for you! --Yakov

Re: Help with integrating Ignite(as JCache) with JBoss EAP 6.4

That was the original approach but seeing how difficult it is to correctly set the IgniteConfiguration object (either by using Properties as you pointed out earlier in this thread because of Factories, SPIs, etc. or JSON as stated in another thread), we realized we could not avoid using Spring

Re: Help with integrating Ignite(as JCache) with JBoss EAP 6.4

Juan, I don't see why we should provide cache configuration properties there, because cache is created by CacheManager, not CachingProvider, and based on configuration object, not Spring XML file. At the same time I agree that now there is now way to use Ignite's CacheManager without Spring and

Re: Help with integrating Ignite(as JCache) with JBoss EAP 6.4

Hi Val, Thanks for your reply. The reason for all this request was to try to use the JCache API as agnostically as possible, so we could switch implementations if necessary (for example switch from Hazelcast to Ignite and viceversa). I agree with you that having the configuration in

Re: Help with integrating Ignite(as JCache) with JBoss EAP 6.4

Juan, I don't see how this will help you. IgnitionEx.loadConfigurations(springCfgUrl) still uses Spring to load configuration from the file. I think the best way is to create IgniteConfiguration object, set class loader, start Ignite and create cache using Ignite API. If you then use only JCache

Re: Help with integrating Ignite(as JCache) with JBoss EAP 6.4

Val, Correct. If the classloader passed to CachingProvider::getCacheManager(uri, clsLdr) is honored, that would be a fix. Also, it would be great if properties passed to the other overloaded mehtod CachingProvider::getCacheManager(urig, clsLdr, props) was honored as well. Thanks - Juan --

Re: Help with integrating Ignite(as JCache) with JBoss EAP 6.4

Juan, Here is the ticket for this: https://issues.apache.org/jira/browse/IGNITE-2087 What other properties except the class loader should be honored in your point of view? Please share your thoughts in the ticket. You are also free to pick it up and make the fix ;) -Val -- View this message

Re: Help with integrating Ignite(as JCache) with JBoss EAP 6.4

Hi, I'm not familiar with JBoss classloading model, but I would start with making sure that your data model classes (the ones that are stored in cache) are available on classpath of all nodes (both servers and clients). Probably you need to put them to the same module where Ignite is deployed, so

Re: Help with integrating Ignite(as JCache) with JBoss EAP 6.4

Juan, Do I understand correctly, that if Ignite's cache manager sets its class loader (the one that was passed to getCacheManager() method) to the IgniteConfiguration when starting a node, everything will work properly? If so, it's a good point and looks like an easy fix. Please confirm that I