Re: Adding the limited resource to TaskStatus messages

2017-10-10 Thread James Peach
> On Oct 9, 2017, at 7:15 PM, Wil Yegelwel wrote: > > Is it correct to say that the limited resource field is *only* meant to > provide machine readable information about what resources limits were > exceeded? Yes, > If so, does it make sense to provide richer reporting

Re: Adding the limited resource to TaskStatus messages

2017-10-09 Thread Wil Yegelwel
Is it correct to say that the limited resource field is *only* meant to provide machine readable information about what resources limits were exceeded? If so, does it make sense to provide richer reporting fields for all failure reasons? I imagine other failure reasons could benefit from being

Re: Adding the limited resource to TaskStatus messages

2017-10-09 Thread James Peach
> On Oct 9, 2017, at 1:27 PM, Vinod Kone wrote: > >> In the case that a task is killed because it violated a resource >> constraint (ie. the reason field is REASON_CONTAINER_LIMITATION, >> REASON_CONTAINER_LIMITATION_DISK or REASON_CONTAINER_LIMITATION_MEMORY), >> this

Re: Adding the limited resource to TaskStatus messages

2017-10-09 Thread Vinod Kone
> In the case that a task is killed because it violated a resource > constraint (ie. the reason field is REASON_CONTAINER_LIMITATION, > REASON_CONTAINER_LIMITATION_DISK or REASON_CONTAINER_LIMITATION_MEMORY), > this field may be populated with the resource that triggered the > limitation. This is

Re: Adding the limited resource to TaskStatus messages

2017-10-09 Thread Jie Yu
+1 On Mon, Oct 9, 2017 at 10:56 AM, James Peach wrote: > Hi all, > > In https://reviews.apache.org/r/62644/, I am proposing to add an optional > Resources field to the TaskStatus message named `limited_resources`. > > In the case that a task is killed because it violated a

Re: Adding the limited resource to TaskStatus messages

2017-10-09 Thread Yan Xu
Does it make sense to wrap the resources in a `Limitation` message in case we add new fields for it? --- Jiang Yan Xu | @xujyan On Mon, Oct 9, 2017 at 10:56 AM, James Peach wrote: > Hi all, > > In https://reviews.apache.org/r/62644/,

Adding the limited resource to TaskStatus messages

2017-10-09 Thread James Peach
Hi all, In https://reviews.apache.org/r/62644/, I am proposing to add an optional Resources field to the TaskStatus message named `limited_resources`. In the case that a task is killed because it violated a resource constraint (ie. the reason field is REASON_CONTAINER_LIMITATION,