Re: Is the email regex validator in Struts validation incorrect?

2014-08-25 Thread Lukasz Lenart
2014-08-25 18:27 GMT+02:00 Miguel Almeida : > Note: I pasted the wrong JIRA issue. The correct one is: > https://issues.apache.org/jira/browse/WW-4395 But you can simple override default pattern with regex or regexExpression param (don't use both) *. http://struts.apache.org/release/2.3.x

Re: Is the email regex validator in Struts validation incorrect?

2014-08-25 Thread Miguel Almeida
Note: I pasted the wrong JIRA issue. The correct one is: https://issues.apache.org/jira/browse/WW-4395 On Mon, 2014-08-25 at 12:22 -0400, Dave Newton wrote: > http://tools.ietf.org/html/rfc2822 > > IIRC http://tools.ietf.org/html/rfc2047 discusses non-0-127 chars in > headers, I'm not sure if th

Re: Is the email regex validator in Struts validation incorrect?

2014-08-25 Thread Paul Benedict
It's impossible to generalize if the developer wants ASCII characters or Unicode characters in email validation. A switch is obviously mandated. However, for Unicode characters, this can be easily solved by using the \w switch (word characters), I believe, as a replacement for the typical [A-Za-z0-

Re: Is the email regex validator in Struts validation incorrect?

2014-08-25 Thread Dave Newton
http://tools.ietf.org/html/rfc2822 IIRC http://tools.ietf.org/html/rfc2047 discusses non-0-127 chars in headers, I'm not sure if that extends to addresses. The bottom line is that any realistic email regex will miss a lot of edge cases, and some fairly normal use cases as well. Email regexes are

Re: Is the email regex validator in Struts validation incorrect?

2014-08-25 Thread Miguel Almeida
I have added it to the JIRA - https://issues.apache.org/jira/browse/WW-4389 I can't seem to find the actual standard though (i.e., the one in place that essentially doesn't allow these characters). For documentation purposes, does anyone know what effective standard disallows these characters? C

Re: Is the email regex validator in Struts validation incorrect?

2014-08-25 Thread Paul Benedict
I looked up the RFC. The document lists itself as a "proposed standard" [1] so it's not really available yet for general use (but correct me if wrong). I propose that an enhancement should be made in JIRA to handle this. [1] http://tools.ietf.org/html/rfc6531 Cheers, Paul On Mon, Aug 25, 2014

Is the email regex validator in Struts validation incorrect?

2014-08-25 Thread Miguel Almeida
This is the regex for email validation in Struts: \\b^['_a-z0-9-\\+]+(\\.['_a-z0-9-\\+]+)*@[a-z0-9-]+(\\.[a-z0-9-]+)\* \.([a-z]{2}|aero|arpa|asia|biz|com|coop|edu|gov|info|int|jobs|mil|mobi| museum|name|nato|net|org|pro|tel|travel|xxx)$\\b I had a report of this failing for a user with an umlaut