Re: Best practise for populating a select from database so that it works for all result types

2008-04-21 Thread Adam Hardy
Hi Toni there are several different approaches. The one I use has an Edit action and a Save action. The Edit action fetches the dropdown list and puts it in the request and results in the form jsp. The form submits to Save and if validation fails, the Input result is resultType=chain and

Re: Best practise for populating a select from database so that it works for all result types

2008-04-21 Thread Toni Lyytikäinen
Well, for the retrieval I use stateless session bean injected to the action with Spring, like this (simplified): public User getUser() { return user; } public String edit() { user=dao.get(id); return SUCCESS; } So it's nothing special. The session approach of course isn't ideal, but more a

Re: Best practise for populating a select from database so that it works for all result types

2008-04-21 Thread Adam Hardy
I think so - the chain is just a forward inside the same request so you shouldn't lose the field errors. But I'm just setting up a new website now with this approach, so actually I'm as inexperienced as you are - my previous Struts2 project had a different approach entirely. You second

Re: Best practise for populating a select from database so that it works for all result types

2008-04-21 Thread Toni Lyytikäinen
Thanks for the answer! Does the resultType=chain approach preserve the fieldErrors and the values the user has already typed into the form? Also, how do you prevent the edit action from retrieving the entity from the database in the case the validation fails? I also thought about putting the

Best practise for populating a select from database so that it works for all result types

2008-04-21 Thread Toni Lyytikäinen
Hello, What is generally regarded as the best practise for populating a select element in a form from database so that it works regardless of the action and the result from which the form is displayed? I've tried this: action configuration: action name=edit method=edit class=admin.Users

Re: Best practise for populating a select from database so that it works for all result types

2008-04-21 Thread Adam Hardy
Yes, I get the picture. If you haven't already, download the source bundle and look at the examples. Actually I don't think I understood one thing you said. You're using an action taglib in the JSP, which invokes the list retrieval. Surely that's not affected by validation failure? I was

Re: Best practise for populating a select from database so that it works for all result types

2008-04-21 Thread Toni Lyytikäinen
Yes it shouldn't be affected, but there seems to be a bug that affects this behaviour, see WW-2599. https://issues.apache.org/struts/browse/WW-2599 On Mon, Apr 21, 2008 at 2:20 PM, Adam Hardy [EMAIL PROTECTED] wrote: Yes, I get the picture. If you haven't already, download the source bundle

Re: Best practise for populating a select from database so that it works for all result types

2008-04-21 Thread Adam Hardy
Did you see this: http://struts.apache.org/2.0.9/docs/why-didnt-my-action-tag-get-executed-when-i-have-validation-errors.html I stumbled across it on the wiki. Do you exclude the appropriate 'read' method on your validation interceptor config? You don't want struts to think that validation

Re: Best practise for populating a select from database so that it works for all result types

2008-04-21 Thread Al Sutton
Toni, Isn't your bug a duplicate of https://issues.apache.org/struts/browse/WW-1963? Al. - Original Message - From: Toni Lyytikäinen [EMAIL PROTECTED] To: Struts Users Mailing List user@struts.apache.org Sent: Monday, April 21, 2008 12:26 PM Subject: Re: Best practise for