On Thursday 09 March 2006 17:57, Jeff Dike wrote: > On Tue, Mar 07, 2006 at 08:31:15PM +0100, Blaisorblade wrote: > > To fix that, we should remove some excess constness. Try the attached > > patch
> That's certainly a lot simpler than what I had. I'll drop it in my tree > and see what it does. I've now seen that while that may fix the problem on 4.1 (and please, do test that), on my 3.4 it causes new warnings like: fs/proc/proc_misc.c: In function `write_sysrq_trigger': fs/proc/proc_misc.c:686: warning: initialization discards qualifiers from pointer target type 686: if (get_user(c, buf)) where "buf" is a "const char __user *". It's complaining because "const" was lost. Ultimately, I think we should remove all this copying of pointers and do like i386 in this regard - there is only one cast to do, in put_user, as I mentioned in last mail. -- Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!". Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 215621894) http://www.user-mode-linux.org/~blaisorblade ___________________________________ Yahoo! Mail: gratis 1GB per i messaggi e allegati da 10MB http://mail.yahoo.it ------------------------------------------------------- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 _______________________________________________ User-mode-linux-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
