Re: [uml-devel] aio vs gentoo headers

2007-07-27 Thread Jeff Dike
On Fri, Jul 27, 2007 at 07:11:07PM +0100, Antoine Martin wrote: > I needed the tiny change below to be able to build on amd64 with gentoo > kernel headers. Already in -mm - http://marc.info/?l=user-mode-linux-devel&m=118521982227031&q=raw Jeff -- Work e

[uml-devel] aio vs gentoo headers

2007-07-27 Thread Antoine Martin
I needed the tiny change below to be able to build on amd64 with gentoo kernel headers. posted here just in case it's useful, I can compile both x86 and amd64 kernels using these headers but not cross compile (make ARCH=um SUBARCH=i386) That still fails with: arch/um/sys-i386/user-offsets.c: In

Re: [uml-devel] [PATCH 18/68] 0 -> NULL, for arch/um

2007-07-27 Thread Jeff Dike
On Fri, Jul 27, 2007 at 11:45:56AM +0200, Yoann Padioleau wrote: > When comparing a pointer, it's clearer to compare it to NULL than to 0. ACK > sys-i386/fault.c |2 +- > sys-x86_64/fault.c |2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Except you should probably diff from

Re: [uml-devel] [PATCH 18/68] 0 -> NULL, for arch/um

2007-07-27 Thread Yoann Padioleau
Jeff Dike <[EMAIL PROTECTED]> writes: > On Fri, Jul 27, 2007 at 11:45:56AM +0200, Yoann Padioleau wrote: >> When comparing a pointer, it's clearer to compare it to NULL than to 0. > > ACK > >> sys-i386/fault.c |2 +- >> sys-x86_64/fault.c |2 +- >> 2 files changed, 2 insertions(+), 2 de

[uml-devel] [PATCH] UML - Console should handle spurious IRQS

2007-07-27 Thread Jeff Dike
The previous DEBUG_SHIRQ patch missed one case. The console doesn't set its host descriptors non-blocking. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/drivers/chan_kern.c |9 - 1 file changed, 8 insertions(+), 1 deletion(-) Index: linux-2.6.21-mm/arch/um/drivers/chan_ker

[uml-devel] [PATCH 18/68] 0 -> NULL, for arch/um

2007-07-27 Thread Yoann Padioleau
When comparing a pointer, it's clearer to compare it to NULL than to 0. Here is an excerpt of the semantic patch: @@ expression *E; @@ E == - 0 + NULL @@ expression *E; @@ E != - 0 + NULL Signed-off-by: Yoann Padioleau <[EMAIL PROTECTED]> Cc: [EMAIL PROTECTED] Cc: user-mode-linux-devel@