Re: [uml-devel] [PATCH 3/4] UML - Implement get_wchan

2007-10-30 Thread Jeff Dike
On Tue, Oct 30, 2007 at 10:40:46AM -0700, Joe Perches wrote: > Perhaps instead of unsigned long? > > bool skipped_ip; //delayed initialization Ooh, I forgot we had bool. I'll fix that in a later patch. Jeff -- Work email - jdike at linux dot intel dot com ---

Re: [uml-devel] [PATCH 3/4] UML - Implement get_wchan

2007-10-30 Thread Joe Perches
On Tue, 2007-10-30 at 13:28 -0400, Jeff Dike wrote: > +unsigned long get_wchan(struct task_struct *p) > +{ > + unsigned long stack_page, sp, ip, count = 0; Perhaps instead of unsigned long? bool skipped_ip;//delayed initialization > + > + if ((p == NULL) || (p == current) || (p->

[uml-devel] [PATCH 3/4] UML - Implement get_wchan

2007-10-30 Thread Jeff Dike
Implement get_wchan - the algorithm is similar to x86. It starts with the stack pointer of the process in question and looks above that for addresses that are kernel text. The second one which isn't in the scheduler is the one that's returned. The first one is ignored because that will be UML's

[uml-devel] [PATCH 1/4] UML - Remove xmm checking on x86

2007-10-30 Thread Jeff Dike
From: Karol Swietlicki <[EMAIL PROTECTED]> This patch removes some code which ran at every boot, but does not seem to do anything anymore. Please test. It works for me but mistakes can happen. Signed-off-by: Karol Swietlicki <[EMAIL PROTECTED]> Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> --- ar

[uml-devel] [PATCH 4/4] UML - get rid of asmlinkage

2007-10-30 Thread Jeff Dike
Get rid of asmlinkage and remove some old cruft from asm/linkage.h. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> --- arch/um/sys-i386/tls.c |9 + include/asm-um/linkage.h |7 --- 2 files changed, 5 insertions(+), 11 deletions(-) Index: linux-2.6.22/arch/um/sys-i386/tls.c ==

[uml-devel] [PATCH 2/4] UML - Code tidying under arch/um/os-Linux

2007-10-30 Thread Jeff Dike
From: WANG Cong <[EMAIL PROTECTED]> This patch contains varied fixes and improvements for some files under arch/um/os-Linux/, such as a typo fix in a perror message, a missing argument fix for a printf, some constifying for pointers and so on. [ jdike - made sigprocmask failure return -errno inst

[uml-devel] [PATCH 0/4] UML - Four tidying patches for 2.6.25

2007-10-30 Thread Jeff Dike
These four patches are non-urgent and should wait for 2.6.25. Three of them are code cleanup and the other is an implementation of get_wchan, which no one has been complaining about. Jeff -- Work email - jdike at linux dot intel dot com -