Re: [uml-devel] running UserModeLinux under Valgrind(memcheck)

2008-01-02 Thread Jeff Dike
On Wed, Jan 02, 2008 at 02:42:20PM -0800, John Reiser wrote: > It looks more complicated to me. > > When include/linux/slab.h is in view, then I trace > (where indentation indicates logical call [inline, or physical call]): > kmalloc include/linux/slab.h > __kmalloc mm/slab.c > __d

Re: [uml-devel] running UserModeLinux under Valgrind(memcheck)

2008-01-02 Thread John Reiser
Jeff Dike responded: John Reiser wrote: >>The web page http://bitwagon.com/valgrind+uml/index.html >>now exists with news, history, commentary, scripts, links > You refer to kmalloc and kfree as keeping object state intact between > kfree and kmalloc, thus not being semantically the same as mall

Re: [uml-devel] UML woes in 2.6.24-rc6-mm1

2008-01-02 Thread Jeff Dike
On Wed, Jan 02, 2008 at 09:52:41PM +0100, Miklos Szeredi wrote: > 32bit UML, 64bit host, config attached. Hadn't tried that, but that works here too. I'll see if your config reproduces it. > Can't reproduce with plain -rc6. Feel like bisecting -mm1? Jeff -- Wo

Re: [uml-devel] UML woes in 2.6.24-rc6-mm1

2008-01-02 Thread Miklos Szeredi
> On Wed, Jan 02, 2008 at 06:53:00PM +0100, Miklos Szeredi wrote: > > The below patch was needed to make UML compile in latest -mm. > > ACK on that - I've got the same patch on its way. > > > But sometimes it doesn't boot and does weird things (this is a sample > > with init=/bin/bash): > > > (n

[uml-devel] [PATCH 7/7] UML - Style fixes in arch/um/os-Linux

2008-01-02 Thread Jeff Dike
Style changes under arch/um/os-Linux: include trimming CodingStyle fixes some printks needed severity indicators make_tempfile turns out not to be used outside of mem.c, so it is now static. Its declaration in tempfile.h is no longer needed, and tempfile.h itself is no lo

[uml-devel] [PATCH 6/7] UML - Remove init_irq_signals

2008-01-02 Thread Jeff Dike
init_irq_signals doesn't need to be called from the context of a new process. It initializes handlers, which are useless in process context. With that call gone, init_irq_signals has only one caller, so it can be inlined into init_new_thread_signals. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>

[uml-devel] [PATCH 0/7] UML - Small fixes and cleanups for 2.6.25

2008-01-02 Thread Jeff Dike
This set of patches should wait for 2.6.25. Jeff -- Work email - jdike at linux dot intel dot com - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studi

[uml-devel] [PATCH 5/7] UML - Fix hostfs tv_usec calculations

2008-01-02 Thread Jeff Dike
From: Dominique Quatravaux <[EMAIL PROTECTED]> To convert from tv_nsec to tv_usec, one needs to divide by 1000, not multiply. Signed-off-by: Dominique Quatravaux <[EMAIL PROTECTED]> Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> --- fs/hostfs/hostfs_user.c |8 1 file changed, 4 insert

[uml-devel] [PATCH 3/7] UML - Style fixes in arch/um/kernel

2008-01-02 Thread Jeff Dike
Joe Perches noticed some printks in smp.c that needed fixing. While I was in there, I did the usual tidying in arch/um/kernel, which should be fairly style-clean at this point: copyright updates emacs formatting comments removal include tidying style fixes Cc: Joe

[uml-devel] [PATCH 4/7] UML - Signal handling tidying

2008-01-02 Thread Jeff Dike
This patch tidies the signal handling code slightly. pending is renamed to signals_pending for symmetry with signals_enabled. remove_sigstack was unused, so can be deleted. The value of change_sig was never used, so it is now void and the return value is not calculated any more. Signed-off-by:

[uml-devel] [PATCH 2/7] UML - Remove current_thread

2008-01-02 Thread Jeff Dike
Tidy current-related stuff. There was a comment in current.h saying that current_thread was obsolete, so this patch turns all instances of current_thread into current_thread_info(). There's some simplifying of the result in arch/um/sys-i386/signal.c. current.h and thread_info.h also get style cl

[uml-devel] [PATCH 1/7] UML - Re-remove accidentally restored code

2008-01-02 Thread Jeff Dike
aout-suppress-aout-library-support-if-config_arch_supports_aout.patch restores some code which had been deleted by uml-move-um_virt_to_phys.patch and uml-add-virt_to_pte.patch, presumably due to a botched diff. This patch gets rid of it again. Cc: David Howells <[EMAIL PROTECTED]> Signed-off-by:

Re: [uml-devel] UML woes in 2.6.24-rc6-mm1

2008-01-02 Thread Jeff Dike
On Wed, Jan 02, 2008 at 06:53:00PM +0100, Miklos Szeredi wrote: > The below patch was needed to make UML compile in latest -mm. ACK on that - I've got the same patch on its way. > But sometimes it doesn't boot and does weird things (this is a sample > with init=/bin/bash): > (none):/# ls > Segme

[uml-devel] UML woes in 2.6.24-rc6-mm1

2008-01-02 Thread Miklos Szeredi
The below patch was needed to make UML compile in latest -mm. But sometimes it doesn't boot and does weird things (this is a sample with init=/bin/bash): [0.42] EXT3-fs: mounted filesystem with ordered data mode. [0.42] VFS: Mounted root (ext3 filesystem) readonly. (none):/# ls (n

Re: [uml-devel] (Try #2) [Patch 1/8] UML: Remove 'TOPDIR' from Makefiles

2008-01-02 Thread Sam Ravnborg
On Wed, Jan 02, 2008 at 10:02:55AM -0500, Jeff Dike wrote: > On Tue, Jan 01, 2008 at 09:01:25PM +0800, WANG Cong wrote: > > TOPDIR is obsolete, use srctree instead. > > This patch removes TOPDIR from all UML Makefiles. > > Thanks, I'll send this to Andrew. Thanks Jeff. Sam -

Re: [uml-devel] PATCH - .spec file repair

2008-01-02 Thread Jeff Dike
On Thu, Dec 06, 2007 at 09:07:36PM -0500, Bill Schwanitz wrote: > I wanted to install the uml tools as an rpm on my cent5 box and the .spec > file was not quite functional. > > Attached is a diff against the 20070815 release. Thanks, I dropped that into my tree. J

Re: [uml-devel] __attribute_used__ error on 2.6.23.9

2008-01-02 Thread Jeff Dike
On Wed, Dec 26, 2007 at 06:30:34PM -0800, Todd Jackson wrote: > That patch didn't work...I'm still seeing the same error with the patch > applied. Can you make aio.i and send it to me? Jeff -- Work email - jdike at linux dot intel dot com --

Re: [uml-devel] running UserModeLinux under Valgrind(memcheck)

2008-01-02 Thread Jeff Dike
On Tue, Jan 01, 2008 at 01:24:49PM -0800, John Reiser wrote: > The web page http://bitwagon.com/valgrind+uml/index.html > now exists with news, history, commentary, scripts, links > on getting User Mode Linux for i686 to run under memcheck on i686. You refer to kmalloc and kfree as keeping object

Re: [uml-devel] (Try #2) [Patch 1/8] UML: Remove 'TOPDIR' from Makefiles

2008-01-02 Thread Jeff Dike
On Tue, Jan 01, 2008 at 09:01:25PM +0800, WANG Cong wrote: > TOPDIR is obsolete, use srctree instead. > This patch removes TOPDIR from all UML Makefiles. Thanks, I'll send this to Andrew. Jeff -- Work email - jdike at linux dot intel dot com