S_IFMT is obviously wrong and needs to be 0777.
We're interested in the file mode, not the type.
Fixes: b98b91029c (hostfs: No need to box and later unbox the file mode)
Reported-by: Markus Stenberg markus.stenb...@iki.fi
Signed-off-by: Richard Weinberger rich...@nod.at
---
On Mon, May 4, 2015 at 2:53 PM, Richard Weinberger rich...@nod.at wrote:
--- a/fs/hostfs/hostfs_kern.c
+++ b/fs/hostfs/hostfs_kern.c
@@ -581,7 +581,7 @@ static int hostfs_create(struct inode *dir, struct dentry
*dentry, umode_t mode,
if (name == NULL)
goto out_put;
Am 04.05.2015 um 15:22 schrieb Geert Uytterhoeven:
On Mon, May 4, 2015 at 2:53 PM, Richard Weinberger rich...@nod.at wrote:
--- a/fs/hostfs/hostfs_kern.c
+++ b/fs/hostfs/hostfs_kern.c
@@ -581,7 +581,7 @@ static int hostfs_create(struct inode *dir, struct
dentry *dentry, umode_t mode,
Hi Thomas,
I read it and like it except idle sleep. See my comments inline. I
killed that nanosleep quite on purpose :)
With what you did to the tramp the issue of userspace stalling
should go away by the way (in theory). I think that it will still show a
very HZ behavior, but IMHO
