[uml-devel] [PATCH RESEND] um,ethertap: use strncpy

2015-01-20 Thread Alan
I can't prove the case pointed out in https://bugzilla.kernel.org/show_bug.cgi?id=82341 is correct so let us play safe. Signed-off-by: Alan Cox --- arch/um/os-Linux/drivers/ethertap_user.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/um/os-Linux/dr

[uml-devel] [PATCH] um,ethertap: use strncpy

2014-08-27 Thread Alan
I can't prove the case pointed out in https://bugzilla.kernel.org/show_bug.cgi?id=82341 is correct so let us play safe. Signed-off-by: Alan Cox --- arch/um/os-Linux/drivers/ethertap_user.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/um/os-Linux/dr

Re: [uml-devel] um: TTY fixes (?)

2012-06-07 Thread Alan Cox
er has its own locking model to watch out for. Alan -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond

Re: [uml-devel] um: TTY fixes (?)

2012-06-07 Thread Alan Cox
On Thu, 07 Jun 2012 18:32:42 +0200 Richard Weinberger wrote: > Am 07.06.2012 18:37, schrieb Alan Cox: > > Yes I know exactly what is going on. However getting a more tolerant > > behaviour is going to take a couple more kernels. > > > > So, then please tell me what&

Re: [uml-devel] um: TTY fixes (?)

2012-06-07 Thread Alan Cox
On Thu, 07 Jun 2012 17:18:37 +0200 Richard Weinberger wrote: > Alan, Jiri! > > If I omit ->hangup(), mingetty (And all other getty implementations) > are unable to open /dev/ttyX. open() returns -EIO. > Currently I'm testing it on FC12. > Also if I do something lik

Re: [uml-devel] um: TTY fixes (?)

2012-06-07 Thread Alan Cox
On Thu, 07 Jun 2012 01:17:24 +0200 Richard Weinberger wrote: > Am 04.06.2012 23:17, schrieb Alan Cox: > > We can half ignore it on console for the simple reason that you > > don't "dial in" to the console. I suspect it may be abusable but > > I've not f

Re: [uml-devel] um: TTY fixes (?)

2012-06-07 Thread Alan Cox
ace, but leaving other vendors systems insecure just to cover Fedora's backside is also not entirely fair either. Alan -- Live Security Virtual Conference Exclusive live event will cover all the ways today's se

Re: [uml-devel] um: TTY fixes (?)

2012-06-07 Thread Alan Cox
left from before the vhangup due to util-linux misbehaving is a hung-up fd so cannot affect the tty. UML is a good test case for fixing this properly because it's got almost no users, and those it has are fairly technical 8) Alan --

Re: [uml-devel] um: TTY fixes (?)

2012-06-05 Thread Alan Cox
refer a clever solution which can spot all the fds are the same process so we can keep compatibility but I've not found a sensible way to do that. Alan -- Live Security Virtual Conference Exclusive live event will c

Re: [uml-devel] um: TTY fixes (?)

2012-06-04 Thread Alan Cox
nd a way to do so. > I have no idea what's the root cause of this, there seems to be a lot of > black magic > involved. > Alan, do you think the issues are caused by Fedora's broken user space? See what fuser says abou

Re: [uml-devel] [PATCH 13/24] TTY: um/line, use tty from tty_port

2012-06-04 Thread Alan Cox
> Two days ago I did so but still faced the problems described here: > https://lkml.org/lkml/2012/3/10/163 If you are running a Fedora like distro it's because the user space is broken. At some point we are going to have to make them fix the userspace not to sit with ttys held o

Re: [uml-devel] /sys/class/tty/tty0/active?

2012-01-27 Thread Alan Cox
On Fri, 27 Jan 2012 13:04:37 +0100 richard -rw- weinberger wrote: > On Fri, Jan 27, 2012 at 12:51 PM, Alan Cox wrote: > >> UML's console driver (arch/um/drivers/line.c) implements tty_operations. > >> The crash happens because the tty subsystem calls the driver's

Re: [uml-devel] /sys/class/tty/tty0/active?

2012-01-27 Thread Alan Cox
nting out another older change that was needed and that wasn't acted on either.. Take a look at how all the other tty drivers use tty_port, how the ioctls have been supposed to work for the past few years and the callback chan

Re: [uml-devel] [PATCH v4 10/12] string: factorize skip_spaces and export it to be generally available

2009-11-08 Thread Alan Cox
function call. Second minor comment. Although it never made it into the final ANSI C, the proposed name (and the one used in a lot of other non Linux code for this) is stpblk(). Alan -- Let Crystal Reports handle the re

Re: [uml-devel] [Patch] um: fix a build error

2008-07-22 Thread Alan Cox
On Tue, 22 Jul 2008 18:35:09 +0100 WANG Cong <[EMAIL PROTECTED]> wrote: > On Tue, Jul 22, 2008 at 11:53:54AM +0100, Alan Cox wrote: > >> Signed-off-by: Eric Sesterhenn <[EMAIL PROTECTED]> > >> > >> --- linux-2.6/arch/um/drivers/line.c.orig

Re: [uml-devel] [Patch] um: fix a build error

2008-07-22 Thread Alan Cox
WRITE_WAKEUP, &tty->flags)) > + tty_wakeup(tty); Sorry I should have been clearer - you don't want the test_bit either. Acked-by: Alan Cox <[EMAIL PROTECTED]> however as it is still right but you can stick my Ack on a version without the if too. -

Re: [uml-devel] [Patch] um: fix a build error

2008-07-21 Thread Alan Cox
*** [sub-make] Error 2 > > Sigend-off-by: WANG Cong <[EMAIL PROTECTED]> NAK - drivers shouldn't be poking around in tty innards in the first place then this wouldn't break. Use tty_wakeup(tty); insteaad Alan

Re: [uml-devel] [Patch] UML: Fix inconsistence due to tty_operation change

2008-05-02 Thread Alan Cox
ECTED]> > Signed-off-by: WANG Cong <[EMAIL PROTECTED]> Acked-by: Alan Cox <[EMAIL PROTECTED]> - This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting ev

[uml-devel] [PATCH] UML - tty locking

2006-09-11 Thread Alan Cox
Jeff this is the tty locking diff I mentioned at Linux Kongress, it just ensures current->signal->tty doesn't get freed during log_exec(). Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.18-rc6-m

Re: [uml-devel] [linux-usb-devel] [ link to patch] resurrecting the uml-hcd

2006-08-15 Thread Alan Stern
e the hub thread is > is it even a good idea to do so? I admit the proxy hubs are somewhat > of a messy design with both simulated and real status and urbs going > back and forth on both the UML and the host. Have you seen the changes to usbcore in the -mm kernel series? They introduce t

Re: [uml-devel] [linux-usb-devel] [ link to patch] resurrecting the uml-hcd

2006-08-14 Thread Alan Stern
seing usb initializion through the core > for several days without finding that point. > Though fixing that now causes the devices to show up twice, > two host controllers & two usb devices. Maybe this is because the standard mechanisms are now operating in addition to whatever workaround

Re: [uml-devel] [linux-usb-devel] [ link to patch] resurrecting the uml-hcd

2006-08-13 Thread Alan Stern
it do so? > The patch can be fetched from > http://mysite.verizon.net/james.mcmechan/uml-hcd.2.6.17.6.patch > or bzipped as > http://mysite.verizon.net/james.mcmechan/uml-hcd.2.6.17.6.patch.bz2 > it is 1104 lines long & 31K in size so I stuck it on a web page. Your server doesn

[uml-devel] 2.6.13-bs3 amd64 compilation broken?

2005-10-07 Thread Alan Menegotto
x27;ve got no such errors compiling 2.6.13-bs9 (probably one version further, I'm not sure about the version). Try the latest 'bs patch' and the latest vanilla kernel version (2.6.13-3) and the error should be gone. -- Saudações Alan Menegotto Depto de Informática G

[uml-devel] Re: [PATCH 1/12] UML - tty fix

2005-09-02 Thread Alan Cox
1/arch/um/drivers/chan_kern.c > === Acked-by: Alan Cox <[EMAIL PROTECTED]> (and applied to my tty tree for future diff generation) --- SF.Net email is Sponsored by the Better Software Confere

[uml-devel] Re: [01/07] uml: add nfsd syscall when nfsd is modular

2005-04-27 Thread Alan Cox
On Mer, 2005-04-27 at 18:46, Chris Wright wrote: > > Don't see why this one is a critical bug. > > I guess without it, modular nfsd has no syscall interface (for UML, or > course). And the trivial zero risk fix is to compile it in. Its hardly pressing --

[uml-devel] Re: [01/07] uml: add nfsd syscall when nfsd is modular

2005-04-27 Thread Alan Cox
On Mer, 2005-04-27 at 18:15, Greg KH wrote: > -stable review patch. If anyone has any objections, please let us know. Don't see why this one is a critical bug. --- SF.Net email is sponsored by: Tell us your software development plans! Take t