Re: [uml-devel] [PATCH] [RFC] um: Convert ubd driver to blk-mq

2017-12-03 Thread Richard Weinberger
Christoph, Am Mittwoch, 29. November 2017, 22:46:51 CET schrieb Christoph Hellwig: > On Sun, Nov 26, 2017 at 02:10:53PM +0100, Richard Weinberger wrote: > > MAX_SG is 64, used for blk_queue_max_segments(). This comes from > > a0044bdf60c2 ("uml: batch I/O requests"). Is this still a good/sane > >

Re: [uml-devel] [PATCH] [RFC] um: Convert ubd driver to blk-mq

2017-11-29 Thread Christoph Hellwig
On Sun, Nov 26, 2017 at 02:10:53PM +0100, Richard Weinberger wrote: > MAX_SG is 64, used for blk_queue_max_segments(). This comes from > a0044bdf60c2 ("uml: batch I/O requests"). Is this still a good/sane > value for blk-mq? blk-mq itself doesn't change the tradeoff. > The driver does IO batching

Re: [uml-devel] [PATCH] [RFC] um: Convert ubd driver to blk-mq

2017-11-26 Thread Anton Ivanov
On 26/11/17 13:56, Richard Weinberger wrote: > Anton, > > please don't crop the CC list. Apologies, I wanted to keep the discussion UML side until we have come up with something. Will not do it again. > > Am Sonntag, 26. November 2017, 14:41:12 CET schrieb Anton Ivanov: >> I need to do some read

Re: [uml-devel] [PATCH] [RFC] um: Convert ubd driver to blk-mq

2017-11-26 Thread Richard Weinberger
Anton, please don't crop the CC list. Am Sonntag, 26. November 2017, 14:41:12 CET schrieb Anton Ivanov: > I need to do some reading on this. > > First of all - a stupid question: mq's primary advantage is in > multi-core systems as it improves io and core utilization. We are still > single-core

Re: [uml-devel] [PATCH] [RFC] um: Convert ubd driver to blk-mq

2017-11-26 Thread Anton Ivanov
I need to do some reading on this. First of all - a stupid question: mq's primary advantage is in multi-core systems as it improves io and core utilization. We are still single-core in UML and AFAIK this is likely to stay that way, right? On 26/11/17 13:10, Richard Weinberger wrote: > This is the

[uml-devel] [PATCH] [RFC] um: Convert ubd driver to blk-mq

2017-11-26 Thread Richard Weinberger
This is the first attempt to convert the UserModeLinux block driver (UBD) to blk-mq. While the conversion itself is rather trivial, a few questions popped up in my head. Maybe you can help me with them. MAX_SG is 64, used for blk_queue_max_segments(). This comes from a0044bdf60c2 ("uml: batch I/O