Re: [uml-devel] [PATCH 8/9] um: fix strrchr problems

2011-08-30 Thread Al Viro
On Tue, Aug 30, 2011 at 12:32:31PM +0200, Richard Weinberger wrote: > defconfig + STATIC_LINK + UML_NET_VDE builds fine for me. > > Toolchain (openSUSE 11.4): > glibc: 2.11.3 > vde2: 2.3.1 > gcc: 4.5.3 > binutils: 2.21.1 > > Is my vde too new? > BTW: Why is only strstr affected, what makes it s

Re: [uml-devel] [PATCH 8/9] um: fix strrchr problems

2011-08-30 Thread Richard Weinberger
Am 30.08.2011 04:48, schrieb Al Viro: > On Tue, Aug 30, 2011 at 01:23:31AM +0100, Al Viro wrote: >> On Tue, Aug 30, 2011 at 12:25:25AM +0200, Richard Weinberger wrote: >> >>> I'm building most of the time static. >>> Using defconfig and >>> CONFIG_STATIC_LINK=y >>> it builds fine here (x86_64 and i

Re: [uml-devel] [PATCH 8/9] um: fix strrchr problems

2011-08-29 Thread Jeff Dike
On Mon, Aug 29, 2011 at 02:27:05PM -0700, Andrew Morton wrote: > ok, I give up. How does this work? It fixes symbol clashes between libc and kernel names by redefining the kernel name in any file that is built against kernel headers. This fix is fairly nasty, but simple and it works. My long-ra

Re: [uml-devel] [PATCH 8/9] um: fix strrchr problems

2011-08-29 Thread Al Viro
On Tue, Aug 30, 2011 at 01:23:31AM +0100, Al Viro wrote: > On Tue, Aug 30, 2011 at 12:25:25AM +0200, Richard Weinberger wrote: > > > I'm building most of the time static. > > Using defconfig and > > CONFIG_STATIC_LINK=y > > it builds fine here (x86_64 and i386) > > 32bit build works, 64bit one br

Re: [uml-devel] [PATCH 8/9] um: fix strrchr problems

2011-08-29 Thread Al Viro
On Tue, Aug 30, 2011 at 12:25:25AM +0200, Richard Weinberger wrote: > I'm building most of the time static. > Using defconfig and > CONFIG_STATIC_LINK=y > it builds fine here (x86_64 and i386) 32bit build works, 64bit one breaks with /usr/lib/gcc/x86_64-linux-gnu/4.4.5/../../../../lib/libc.a(str

Re: [uml-devel] [PATCH 8/9] um: fix strrchr problems

2011-08-29 Thread Boaz Harrosh
On 08/29/2011 03:25 PM, Richard Weinberger wrote: >> >> Try to build it static... > > I'm building most of the time static. > Using defconfig and > CONFIG_STATIC_LINK=y > it builds fine here (x86_64 and i386) > > Thanks, > //richard With some switches and optimization gcc might turn strrchr into

Re: [uml-devel] [PATCH 8/9] um: fix strrchr problems

2011-08-29 Thread Arnaud Lacombe
Hi, On Mon, Aug 29, 2011 at 6:19 PM, Al Viro wrote: > On Tue, Aug 30, 2011 at 12:15:59AM +0200, Richard Weinberger wrote: >> Am 30.08.2011 00:12, schrieb Al Viro: >> >On Mon, Aug 29, 2011 at 11:38:39PM +0200, Richard Weinberger wrote: >> >>> >> >>>ok, I give up.  How does this work? >> >> >> >>*g

Re: [uml-devel] [PATCH 8/9] um: fix strrchr problems

2011-08-29 Thread Richard Weinberger
Am 30.08.2011 00:19, schrieb Al Viro: > On Tue, Aug 30, 2011 at 12:15:59AM +0200, Richard Weinberger wrote: >> Am 30.08.2011 00:12, schrieb Al Viro: >>> On Mon, Aug 29, 2011 at 11:38:39PM +0200, Richard Weinberger wrote: > > ok, I give up. How does this work? *grrr*, you can drop

Re: [uml-devel] [PATCH 8/9] um: fix strrchr problems

2011-08-29 Thread Al Viro
On Tue, Aug 30, 2011 at 12:15:59AM +0200, Richard Weinberger wrote: > Am 30.08.2011 00:12, schrieb Al Viro: > >On Mon, Aug 29, 2011 at 11:38:39PM +0200, Richard Weinberger wrote: > >>> > >>>ok, I give up. How does this work? > >> > >>*grrr*, you can drop this patch. > >>To my excuse, I've dropped

Re: [uml-devel] [PATCH 8/9] um: fix strrchr problems

2011-08-29 Thread Richard Weinberger
Am 30.08.2011 00:12, schrieb Al Viro: > On Mon, Aug 29, 2011 at 11:38:39PM +0200, Richard Weinberger wrote: >>> >>> ok, I give up. How does this work? >> >> *grrr*, you can drop this patch. >> To my excuse, I've dropped it already from my queue but after >> pulling a second time from Al's git bran

Re: [uml-devel] [PATCH 8/9] um: fix strrchr problems

2011-08-29 Thread Al Viro
On Mon, Aug 29, 2011 at 11:38:39PM +0200, Richard Weinberger wrote: > > > >ok, I give up. How does this work? > > *grrr*, you can drop this patch. > To my excuse, I've dropped it already from my queue but after > pulling a second time from Al's git branch it made it again into my > queue and I fo

Re: [uml-devel] [PATCH 8/9] um: fix strrchr problems

2011-08-29 Thread Al Viro
On Mon, Aug 29, 2011 at 02:27:05PM -0700, Andrew Morton wrote: > z:/usr/src/linux-3.1-rc4> grep -r kernel_strrchr . > z:/usr/src/linux-3.1-rc4> > > ok, I give up. How does this work? You are grepping for the wrong thing ;-) It works the same way defines next to it do - both the kernel

Re: [uml-devel] [PATCH 8/9] um: fix strrchr problems

2011-08-29 Thread Richard Weinberger
Am 29.08.2011 23:27, schrieb Andrew Morton: > >> Subject: [PATCH 8/9] um: fix strrchr problems > > What are the problems? > > On Mon, 29 Aug 2011 18:13:38 +0200 > Richard Weinberger wrote: > >> From: Al Viro >> >> Several years old patch, originally by jdike, I think... >> >> Signed-off-by: Al Vir

Re: [uml-devel] [PATCH 8/9] um: fix strrchr problems

2011-08-29 Thread Andrew Morton
> Subject: [PATCH 8/9] um: fix strrchr problems What are the problems? On Mon, 29 Aug 2011 18:13:38 +0200 Richard Weinberger wrote: > From: Al Viro > > Several years old patch, originally by jdike, I think... > > Signed-off-by: Al Viro > Signed-off-by: Richard Weinberger > --- > arch/um/

[uml-devel] [PATCH 8/9] um: fix strrchr problems

2011-08-29 Thread Richard Weinberger
From: Al Viro Several years old patch, originally by jdike, I think... Signed-off-by: Al Viro Signed-off-by: Richard Weinberger --- arch/um/Makefile |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/um/Makefile b/arch/um/Makefile index fab8121..c0f712c 100644 ---