Re: [uml-devel] [PATCH 6/6] UML - Fix hostfs style

2007-08-24 Thread Jeff Dike
On Thu, Aug 23, 2007 at 04:54:59PM +0200, Blaisorblade wrote: > > actually. Personally I'd prefer: > > > > else > > type = OS_TYPE_DIR; > > I strongly agree with this style; beyond style itself, one strong reason is > that joining statements hinder singlestepping through function

Re: [uml-devel] [PATCH 6/6] UML - Fix hostfs style

2007-08-24 Thread Blaisorblade
On venerdì 24 agosto 2007, Jeff Dike wrote: > On Thu, Aug 23, 2007 at 04:54:59PM +0200, Blaisorblade wrote: > > > actually. Personally I'd prefer: > > > > > > else > > > type = OS_TYPE_DIR; > > > > I strongly agree with this style; beyond style itself, one strong reason > > is that join

[uml-devel] [PATCH] convert #include "linux/..." and #include "asm/..." to #include <...>

2007-08-24 Thread Joe Perches
There are several files that: #include "linux/file" not #include #include "asm/file" not #include Here's the little script that converted them: egrep -i -r -l --include=*.[ch] \ "^[[:space:]]*\#[[:space:]]*include[[:space:]]*\"(linux|asm)/(.*)\"" * \ | xargs sed -i -e 's/^[[:space:]]*#[[:spac