Re: [uml-devel] [PATCH 6/19] UML - hppfs fixes

2008-04-28 Thread Jeff Dike
On Sat, Apr 26, 2008 at 04:31:32PM +0800, WANG Cong wrote: > > - copy_to_user(buf, &data->contents[off], count); > > - *ppos += count; > > + rem = copy_to_user(buf, &data->contents[off], count); > > + *ppos += count - rem; > > + if (rem > 0) > > +

Re: [uml-devel] [PATCH 6/19] UML - hppfs fixes

2008-04-28 Thread Jeff Dike
On Sat, Apr 26, 2008 at 04:31:32PM +0800, WANG Cong wrote: > > + rem = copy_to_user(buf, &data->contents[off], count); > > + *ppos += count - rem; > > + if (rem > 0) > > + return -EFAULT; > > Could you please explain why check 'rem' after using it he

Re: [uml-devel] [PATCH 7/19] UML - Move hppfs_kern.c to hppfs.c

2008-04-28 Thread Jeff Dike
On Sat, Apr 26, 2008 at 05:17:55PM +0800, WANG Cong wrote: > > +static struct inode *get_inode(struct super_block *, struct dentry *); > > + > > +struct hppfs_data { > > + struct list_head list; > > + char contents[PAGE_SIZE - sizeof(struct list_head)]; > > +}; > > + > > +struct hppfs_private {

Re: [uml-devel] [PATCH 9/19] UML - Tidy ptrace interface

2008-04-28 Thread Jeff Dike
On Sat, Apr 26, 2008 at 05:35:38PM +0800, WANG Cong wrote: > From: Jeff Dike <[EMAIL PROTECTED]> > Date: Fri, 25 Apr 2008 13:56:10 -0400 > > Tidy the ptrace interface code. Removed a bunch of unused macros. > > Started converting register sets from arrays of longs to structures. > > Could you ple

Re: [uml-devel] [PATCH 2/19] UML - Tidy stub management code

2008-04-28 Thread Jeff Dike
On Sat, Apr 26, 2008 at 06:01:12PM +0800, WANG Cong wrote: > > + /* > > +* When the stub stops, we find the following values on the > > +* beginning of the stack: > > +* (long) return_value > > +* (long) offset to failed sycall data (0 if no error) > > +*/ > > + ret = *((uns

[uml-devel] arch/um/Makefile:100: *** missing separator. Stop.

2008-04-28 Thread Peter Teoh
What is the following errors: make defconfig ARCH=um /sda4/download/linux_linus/linux-2.6/arch/um/Makefile:100: *** missing separator. Stop. I was not able to find anything relevant from Internet, please advise? Other infor: /sda4/download/linux_linus/linux-2.6>uname -r 2.6.25-rc9 /sda4/downl

Re: [uml-devel] actually useful backtrace from a CPU-chewing hang

2008-04-28 Thread Jeff Dike
On Sat, Apr 26, 2008 at 07:31:44PM +0100, Nix wrote: > The cause of this is almost certainly time-skewing on the *host* via > adjtimex(). I stopped ntpd and there were no problems for half a day: I > restarted it, and as soon as ntpd had synched and begun slewing the time > (within a second of slew

Re: [uml-devel] [PATCH] SKAS4 - Clean up command line disable output

2008-04-28 Thread Jeff Dike
On Mon, Apr 14, 2008 at 05:16:28PM -0700, Ryan Finnie wrote: > The PTRACE_GETSIGINFO notice was missing a linefeed. In addition, tab > and wrap each SKAS4 "disabled" message in parens so it doesn't break up > the indendation within the switch_mm check block. Looks good, but I'm going to want a

Re: [uml-devel] arch/um/Makefile:100: *** missing separator. Stop.

2008-04-28 Thread Jeff Dike
On Mon, Apr 28, 2008 at 11:53:48PM +0800, Peter Teoh wrote: > What is the following errors: > > make defconfig ARCH=um > /sda4/download/linux_linus/linux-2.6/arch/um/Makefile:100: *** missing > separator. Stop. What version of UML? Jeff -- Work email - jdike at linux dot intel do

[uml-devel] [PATCH] SKAS4 - Clean up command line disable output

2008-04-28 Thread Ryan Finnie
The PTRACE_GETSIGINFO notice was missing a linefeed. In addition, tab and wrap each SKAS4 "disabled" message in parens so it doesn't break up the indendation within the switch_mm check block. Signed-off-by: Ryan Finnie <[EMAIL PROTECTED]> --- start_up.c | 11 +-- 1 file changed, 5 i

[uml-devel] [PATCH] SKAS4 - Add noswitchmm, noptraceswitchmm and mode=skas3 switches

2008-04-28 Thread Ryan Finnie
The SKAS4 patch that eventually hits mainline will almost certainly be incompatible with the current working SKAS4 patchset. To that end, add mode=skas3, so current SKAS4 guests can be run in SKAS3 mode if/when future SKAS4 hosts are incompatible. At current time, if a SKAS4 check fails, it f