Re: [uml-devel] Performance tests (was: Using UML in libguestfs)

2013-08-16 Thread Richard W.M. Jones
On Thu, Aug 15, 2013 at 10:31:54PM +0200, richard -rw- weinberger wrote: > On Thu, Aug 15, 2013 at 8:59 PM, Richard W.M. Jones wrote: > > On Thu, Aug 15, 2013 at 08:41:53PM +0200, richard -rw- weinberger wrote: > >> Meant regarding fsync()... > > > > Ah right, see what you mean :-) > > > > It call

Re: [uml-devel] [PATCH] print_worker_info: Handle pointer with more care

2013-08-16 Thread Tejun Heo
On Fri, Aug 16, 2013 at 06:15:07PM +0200, Richard Weinberger wrote: > On UML I hit the case that pwq is NULL. > Then we oops at &pwq->wq... Hmmm? I'm confused. &pwq->wq is pwq's pointer + wq's offset in pwq. It doesn't involve dereferencing pwq->wq. Maybe uml isn't implementing probe_kernel_thr

Re: [uml-devel] [PATCH] print_worker_info: Handle pointer with more care

2013-08-16 Thread Richard Weinberger
Am 16.08.2013 18:28, schrieb Tejun Heo: > On Fri, Aug 16, 2013 at 06:15:07PM +0200, Richard Weinberger wrote: >> On UML I hit the case that pwq is NULL. >> Then we oops at &pwq->wq... > > Hmmm? I'm confused. &pwq->wq is pwq's pointer + wq's offset in pwq. > It doesn't involve dereferencing pwq->

Re: [uml-devel] [PATCH] print_worker_info: Handle pointer with more care

2013-08-16 Thread Tejun Heo
Hello, On Fri, Aug 16, 2013 at 06:38:58PM +0200, Richard Weinberger wrote: > > cc'ing uml people. Hey, guys, workqueue uses proble_kernel_read() to > > print out workqueue related information during oops because those > > events are completely asynchronous and workqueue states may not be > > cons

Re: [uml-devel] [PATCH] print_worker_info: Handle pointer with more care

2013-08-16 Thread Richard Weinberger
Am 16.08.2013 18:45, schrieb Tejun Heo: > Hello, > > On Fri, Aug 16, 2013 at 06:38:58PM +0200, Richard Weinberger wrote: >>> cc'ing uml people. Hey, guys, workqueue uses proble_kernel_read() to >>> print out workqueue related information during oops because those >>> events are completely asynchr

Re: [uml-devel] [PATCH] print_worker_info: Handle pointer with more care

2013-08-16 Thread Richard Weinberger
Am 16.08.2013 18:53, schrieb Richard Weinberger: >> Yeah, and that should be fine. &pwq->wq would be just an offset of wq > > Yep. Now my brain also parsed the C notation correctly. > Sorry for the completely wrong patch. > >> from NULL which is an invalid pointer but probe_kernel_read() should

[uml-devel] [PATCH] um: Implement probe_kernel_read()

2013-08-16 Thread Richard Weinberger
UML needs it's own probe_kernel_read() to handle kernel mode faults correctly. The implementation uses mincore() on the host side to detect whether a page is owned by the UML kernel process. This fixes also a possible crash when sysrq-t is used. Starting with 3.10 sysrq-t calls probe_kernel_read()

Re: [uml-devel] [PATCH] um: Implement probe_kernel_read()

2013-08-16 Thread Richard Weinberger
Am 16.08.2013 21:44, schrieb Richard Weinberger: > UML needs it's own probe_kernel_read() to handle kernel > mode faults correctly. > The implementation uses mincore() on the host side to detect > whether a page is owned by the UML kernel process. > > This fixes also a possible crash when sysrq-t