>
Hi Thomas,
Could you please fix your patch since there are multiple issues with it
1) I does not apply cleanly against the current linux tree
mostly due to kmsg_dump.c which is not in the proper format
it should be b/arch/um/kernel/kmsg_dump.c like the rest of the patch
2) After fixing
On Tue, Oct 07, 2014 at 06:28:07AM +0100, Guenter Roeck wrote:
> Devicetree bindings are supposed to be operating system independent
> and should thus not describe how a specific functionality is implemented
> in Linux.
>
> Cc: Rob Herring
> Cc: Pawel Moll
> Cc: Mark Rutland
> Signed-off-by: Gu
Replace reference to pm_power_off (which is an implementation detail)
and replace it with a more generic description of the driver's functionality.
Cc: Rob Herring
Cc: Pawel Moll
Cc: Mark Rutland
Signed-off-by: Guenter Roeck
---
Documentation/devicetree/bindings/power_supply/qnap-poweroff.txt
Register with kernel poweroff handler instead of setting pm_power_off
directly. Register with low priority value of 64 since the efi code
states that this is a poweroff handler of last resort.
Cc: Matt Fleming
Signed-off-by: Guenter Roeck
---
drivers/firmware/efi/reboot.c | 23 +
Register with kernel poweroff handler instead of setting pm_power_off
directly.
Signed-off-by: Guenter Roeck
---
drivers/power/reset/vexpress-poweroff.c | 19 +--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/drivers/power/reset/vexpress-poweroff.c
b/drivers/pow
Register with kernel poweroff handler instead of setting pm_power_off
directly. Always use register_poweroff_handler_simple as there is no
indication that more than one poweroff handler is registered.
If the poweroff handler only resets the system or puts the CPU in sleep mode,
select a priority o
On Tue, Oct 07, 2014 at 06:28:09AM +0100, Guenter Roeck wrote:
> Replace reference to pm_power_off (which is an implementation detail)
> and replace it with a more generic description of the driver's functionality.
>
> Cc: Rob Herring
> Cc: Pawel Moll
> Cc: Mark Rutland
> Signed-off-by: Guenter
Register with kernel poweroff handler instead of setting pm_power_off
directly. Register with a low priority value of 64 to reflect that
the original code only sets pm_power_off if it was not already set.
Other changes:
Drop note that there can not be an additional instance of this driver.
The or
Register with kernel poweroff handler instead of setting pm_power_off
directly. Register with lower priority of 64 to reflect that the call
is expected to be replaced at some point.
Cc: Tony Luck
Cc: Fenghua Yu
Signed-off-by: Guenter Roeck
---
arch/ia64/sn/kernel/setup.c | 4 ++--
1 file chang
Register with kernel poweroff handler instead of setting pm_power_off
directly. Register with a low priority value of 64 to reflect that
the original code only sets pm_power_off if it was not already set.
Cc: Samuel Ortiz
Cc: Lee Jones
Signed-off-by: Guenter Roeck
---
drivers/mfd/dm355evm_msp.
Register with kernel poweroff handler instead of setting pm_power_off
directly.
Cc: Geert Uytterhoeven
Cc: Joshua Thompson
Signed-off-by: Guenter Roeck
---
arch/m68k/emu/natfeat.c | 2 +-
arch/m68k/mac/config.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/m68k/e
Register with kernel poweroff handler instead of setting pm_power_off
directly.
Signed-off-by: Guenter Roeck
---
arch/sh/boards/board-sh7785lcr.c | 2 +-
arch/sh/boards/board-urquell.c | 2 +-
arch/sh/boards/mach-highlander/setup.c | 2 +-
arch/sh/boards/mach-landisk/setup.c| 2
Register with kernel poweroff handler instead of setting pm_power_off
directly. Register with a low priority value of 64 to reflect that
the original code only sets pm_power_off if it was not already set.
Cc: Samuel Ortiz
Cc: Lee Jones
Signed-off-by: Guenter Roeck
---
drivers/mfd/tps80031.c
Register with kernel poweroff handler instead of setting pm_power_off
directly.
Cc: Haavard Skinnemoen
Cc: Hans-Christian Egtvedt
Signed-off-by: Guenter Roeck
---
arch/avr32/boards/atngw100/mrmt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/avr32/boards/atngw100/mr
No users of pm_power_off are left, so it is safe to remove the function.
Cc: Rafael J. Wysocki
Cc: Pavel Machek
Cc: Len Brown
Signed-off-by: Guenter Roeck
---
include/linux/pm.h | 1 -
kernel/power/poweroff_handler.c | 10 +-
2 files changed, 1 insertion(+), 10 deletions
Poweroff handlers may now be installed with register_poweroff_handler.
Use the new API function have_kernel_poweroff to determine if a poweroff
handler has been installed.
Cc: Rafael J. Wysocki
Cc: Pavel Machek
Cc: Len Brown
Signed-off-by: Guenter Roeck
---
kernel/power/hibernate.c | 2 +-
1
Register with kernel poweroff handler instead of setting pm_power_off
directly. Register with a low priority value of 64 to reflect that
the original code only sets pm_power_off if it was not already set.
Cc: Samuel Ortiz
Cc: Lee Jones
Signed-off-by: Guenter Roeck
---
drivers/mfd/palmas.c
On Tue, Oct 7, 2014 at 7:28 AM, Guenter Roeck wrote:
> Replace mach_power_off with pm_power_off to simplify the subsequent
> move of pm_power_off to generic code.
Thanks!
> Cc: Geert Uytterhoeven
> Cc: Greg Ungerer
> Cc: Joshua Thompson
> Signed-off-by: Guenter Roeck
Looks OK, so since you
Register with kernel poweroff handler instead of setting pm_power_off
directly.
Cc: Thomas Gleixner
Cc: Ingo Molnar
Cc: H. Peter Anvin
Signed-off-by: Guenter Roeck
---
arch/x86/platform/ce4100/ce4100.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/platform/ce410
Register with kernel poweroff handler instead of setting pm_power_off
directly. Register with a high priority value of 192 to reflect that
the original code overwrites pm_power_off unconditionally.
Register poweroff handler after the ipmi system is ready, and unregister
it prior to cleanup. This a
On Tue, Oct 07, 2014 at 06:28:08AM +0100, Guenter Roeck wrote:
> pm_power_off is an implementation detail. Replace it with a more generic
> description of the driver's functionality.
>
> Cc: Rob Herring
> Cc: Pawel Moll
> Cc: Mark Rutland
Acked-by: Mark Rutland
> Signed-off-by: Guenter Roeck
Register with kernel poweroff handler instead of setting pm_power_off
directly. Register with high priority value of 192 to reflect that
the driver explicitly wants to override default poweroff handlers.
Cc: Thomas Gleixner
Cc: Ingo Molnar
Cc: H. Peter Anvin
Signed-off-by: Guenter Roeck
---
a
Register with kernel poweroff handler instead of setting pm_power_off
directly. Register with high priority value of 192 to reflect that
the original code overwrites existing poweroff handlers.
Cc: Thomas Gleixner
Cc: Ingo Molnar
Cc: H. Peter Anvin
Cc: Jiri Kosina
Signed-off-by: Guenter Roeck
Register with kernel poweroff handler instead of setting pm_power_off
directly.
Cc: Catalin Marinas
Cc: Will Deacon
Signed-off-by: Guenter Roeck
---
arch/arm64/kernel/psci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/kernel/psci.c b/arch/arm64/kernel/psci.c
Register with kernel poweroff handler instead of setting pm_power_off
directly. Register with high priority value of 192 to reflect that
the driver explicitly overrides existing poweroff handlers.
Cc: Rafael J. Wysocki
Cc: Len Brown
Signed-off-by: Guenter Roeck
---
drivers/acpi/sleep.c | 15 ++
Use have_kernel_poweroff() to determine if the kernel is able
to power off the system.
Cc: Santosh Shilimkar
Signed-off-by: Guenter Roeck
---
drivers/memory/emif.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/memory/emif.c b/drivers/memory/emif.c
index 04644e7
Register with kernel poweroff handler instead of setting pm_power_off
directly. Register with high priority value of 192 to reflect that
the original code overwrites existing poweroff handlers.
Cc: Thomas Gleixner
Cc: Ingo Molnar
Cc: H. Peter Anvin
Signed-off-by: Guenter Roeck
---
arch/x86/pl
Register with kernel poweroff handler instead of setting pm_power_off
directly. Select proprity 0 since the code does not really poweroff
the system.
Signed-off-by: Guenter Roeck
---
drivers/power/reset/msm-poweroff.c | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --g
On 07/10/2014 07:28, Guenter Roeck :
> Register with kernel poweroff handler instead of setting pm_power_off
> directly. Always use register_poweroff_handler_simple as there is no
> indication that more than one poweroff handler is registered.
>
> If the poweroff handler only resets the system or
Register with kernel poweroff handler instead of setting pm_power_off
directly.
Cc: Rusty Russell
Cc: Thomas Gleixner
Cc: Ingo Molnar
Cc: H. Peter Anvin
Signed-off-by: Guenter Roeck
---
arch/x86/lguest/boot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/lguest
Register with kernel poweroff handler instead of setting pm_power_off
directly. Register with a low priority value of 64 to reflect that
the original code only sets pm_power_off if it was not already set.
Make twl4030_power_off static as it is only called from the twl4030-power
driver.
Cc: Samuel
On Tue, Oct 7, 2014 at 7:28 AM, Guenter Roeck wrote:
> pm_power_off is defined for all architectures. Move it to common code.
>
> Have all architectures call do_kernel_poweroff instead of pm_power_off.
> Some architectures point pm_power_off to machine_power_off. For those,
> call do_kernel_powero
Hello
This seems exactly what I would need on the mc13783 to handle cleanly
the poweroff,
but after reading this patchset I have the following question:
[...]
> +/*
> + * Notifier list for kernel code which wants to be called
> + * to power off the system.
> + */
> +static ATOMIC_NOTIFIER_H
pm_power_off is an implementation detail. Replace it with a more generic
description of the driver's functionality.
Cc: Rob Herring
Cc: Pawel Moll
Cc: Mark Rutland
Signed-off-by: Guenter Roeck
---
Documentation/devicetree/bindings/gpio/gpio-poweroff.txt | 10 +-
1 file changed, 5 inse
Register with kernel poweroff handler instead of setting pm_power_off
directly. Register with a low priority value of 64 to reflect that
the original code only sets pm_power_off if it was not already set.
Cc: Lee Jones
Cc: Samuel Ortiz
Signed-off-by: Guenter Roeck
---
drivers/mfd/retu-mfd.c |
On Tue, Oct 7, 2014 at 7:28 AM, Guenter Roeck wrote:
> Register with kernel poweroff handler instead of setting pm_power_off
> directly.
>
> Cc: Geert Uytterhoeven
> Cc: Joshua Thompson
> Signed-off-by: Guenter Roeck
As someone already mentioned, having #defines instead of hardcoded
numbers fo
Register with kernel poweroff handler instead of setting pm_power_off
directly. Register with a low priority value of 64 to reflect that
the original code only sets pm_power_off if it was not already set.
Cc: Thomas Gleixner
Cc: Ingo Molnar
Cc: H. Peter Anvin
Signed-off-by: Guenter Roeck
---
A dummy poweroff handler does not serve any purpose. Drop it.
Cc: Thomas Gleixner
Cc: Ingo Molnar
Cc: H. Peter Anvin
Signed-off-by: Guenter Roeck
---
arch/x86/platform/intel-mid/intel-mid.c | 5 -
arch/x86/platform/intel-mid/mfld.c | 5 -
2 files changed, 10 deletions(-)
diff --
Register with kernel poweroff handler instead of setting pm_power_off
directly. Register with default priority value of 128 since we don't know
any better.
Cc: Julian Andres Klode
Cc: Marc Dietrich
Cc: Greg Kroah-Hartman
Signed-off-by: Guenter Roeck
---
drivers/staging/nvec/nvec.c | 24 ++
Register with kernel poweroff handler instead of setting pm_power_off
directly. Register with a low priority value of 64 to reflect that
the original code only sets pm_power_off if it was not already set.
Cc: Samuel Ortiz
Cc: Lee Jones
Signed-off-by: Guenter Roeck
---
drivers/mfd/tps65910.c
Register with kernel poweroff handler instead of setting pm_power_off
directly. Register with a low priority value of 64 to reflect that
the original code only sets pm_power_off if it was not already set.
Note that this patch fixes a problem on driver unload as side effect:
The old code did not re
Register with kernel poweroff handler instead of setting pm_power_off
directly.
If there is an indication that there can be more than one poweroff handler,
use register_poweroff_handler, otherwise use register_poweroff_handler_simple
to register the poweroff handler.
If the poweroff handler only
Replace mach_power_off with pm_power_off to simplify the subsequent
move of pm_power_off to generic code.
Cc: Geert Uytterhoeven
Cc: Greg Ungerer
Cc: Joshua Thompson
Signed-off-by: Guenter Roeck
---
arch/m68k/emu/natfeat.c | 3 ++-
arch/m68k/include/asm/machdep.h | 1 -
arch/m68k/kern
Register with kernel poweroff handler instead of setting pm_power_off
directly. Register with default priority value of 128 to reflect that
the original code generates an error if another poweroff handler has
already been registered when the driver is loaded.
Cc: Sebastian Reichel
Cc: Dmitry Erem
Register with kernel poweroff handler instead of seting pm_power_off
directly. Register as poweroff handler of last resort since the driver
does not really power off the system but executes a restart.
Cc: Sebastian Reichel
Cc: Dmitry Eremin-Solenikov
Cc: David Woodhouse
Signed-off-by: Guenter
Devicetree bindings are supposed to be operating system independent
and should thus not describe how a specific functionality is implemented
in Linux.
Cc: Rob Herring
Cc: Pawel Moll
Cc: Mark Rutland
Signed-off-by: Guenter Roeck
---
Documentation/devicetree/bindings/mfd/as3722.txt | 3 +--
1 f
Various drivers implement architecture and/or device specific means to
remove power from the system. For the most part, those drivers set the
global variable pm_power_off to point to a function within the driver.
This mechanism has a number of drawbacks. Typically only one scheme
to remove power
pm_power_off is defined for all architectures. Move it to common code.
Have all architectures call do_kernel_poweroff instead of pm_power_off.
Some architectures point pm_power_off to machine_power_off. For those,
call do_kernel_poweroff from machine_power_off instead.
Cc: Richard Henderson
Cc:
Drivers should not call pm_power_off directly; it is not guaranteed
to be non-NULL. Call kernel_power_off instead.
Cc: Jean Delvare
Reviewed-by: Jean Delvare
Signed-off-by: Guenter Roeck
---
drivers/hwmon/ab8500.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers
Register with kernel poweroff handler instead of setting pm_power_off
directly. Register with a low priority value of 64 to reflect that
the original code only sets pm_power_off if it was not already set.
Cc: Samuel Ortiz
Cc: Lee Jones
Signed-off-by: Guenter Roeck
---
drivers/mfd/tps6586x.c |
Register with kernel poweroff handler instead of setting pm_power_off
directly. Register with a low priority value of 64 to reflect that
the original code only sets pm_power_off if it was not already set.
Cc: Sebastian Reichel
Cc: Dmitry Eremin-Solenikov
Cc: David Woodhouse
Signed-off-by: Guent
Register with kernel poweroff handler instead of setting pm_power_off
directly. Register with a low priority value of 64 to reflect that
the original code only sets pm_power_off if it was not already set.
Cc: Lee Jones
Cc: Samuel Ortiz
Signed-off-by: Guenter Roeck
---
drivers/mfd/axp20x.c
Various drivers implement architecture and/or device specific means to
remove power from the system. For the most part, those drivers set the
global variable pm_power_off to point to a function within the driver.
This mechanism has a number of drawbacks. Typically only one means
to remove power
Register with kernel poweroff handler instead of setting pm_power_off
directly. Register with a low priority value of 64 to reflect that
the original code only sets pm_power_off if it was not already set.
Cc: Linus Walleij
Cc: Lee Jones
Cc: Samuel Ortiz
Signed-off-by: Guenter Roeck
---
driver
Am 07.10.2014 07:28, schrieb Guenter Roeck:
> arch/um/kernel/reboot.c| 2 --
Acked-by: Richard Weinberger
Thanks,
//richard
--
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS
55 matches
Mail list logo
