[uml-devel] [PATCH 1/3] um: Fallback when C library does not provide __ptr_t

2015-06-10 Thread Hans-Werner Hilse
Glibc provides __ptr_t for the pointer in the stack_t struct, but other C libraries - namely musl - do not necessarily do so. In that case, fall back to a void* pointer. Signed-off-by: Hans-Werner Hilse --- arch/um/os-Linux/signal.c | 5 + 1 file changed, 5 insertions(+) diff --git a/arch

[uml-devel] [PATCH 2/3] um: Do not use stdin and stdout names for variables

2015-06-10 Thread Hans-Werner Hilse
Naming local variables "stdin" and "stdout" is fine with glibc, other C libraries, namely musl, will however complain. Signed-off-by: Hans-Werner Hilse --- arch/um/drivers/harddog_user.c | 18 +- arch/um/drivers/net_user.c | 6 +++--- arch/um/drivers/slip_

Re: [uml-devel] [PATCH 1/3] um: Fallback when C library does not provide __ptr_t

2015-06-10 Thread Hans-Werner Hilse
Hi, Am 2015-06-10 23:20, schrieb Hans-Werner Hilse: [...] This three-part patch series will allow to compile UML against the musl libc implementation - even statically. Take it as a suggestion, but I think most things are quite sensible. The __ptr_t stuff is admittedly a bit ugly. -hwh -

Re: [uml-devel] [PATCH 1/3] um: Fallback when C library does not provide __ptr_t

2015-06-10 Thread Richard Weinberger
On Wed, Jun 10, 2015 at 11:20 PM, Hans-Werner Hilse wrote: > Glibc provides __ptr_t for the pointer in the stack_t struct, > but other C libraries - namely musl - do not necessarily do so. > In that case, fall back to a void* pointer. Please just kill __ptr_t in UML. -- Thanks, //richard -

Re: [uml-devel] [PATCH 2/3] um: Do not use stdin and stdout names for variables

2015-06-10 Thread Richard Weinberger
On Wed, Jun 10, 2015 at 11:21 PM, Hans-Werner Hilse wrote: > Naming local variables "stdin" and "stdout" is fine with glibc, > other C libraries, namely musl, will however complain. Wait, what?! These are not local variables, they are struct members. What exactly is the issue with musl? Sounds v

Re: [uml-devel] [PATCH 3/3] um: Include sys/types.h for makedev(), major(), minor()

2015-06-10 Thread Richard Weinberger
On Wed, Jun 10, 2015 at 11:21 PM, Hans-Werner Hilse wrote: > The functions in question are not part of the POSIX standard, > documentation however hints that the corresponding header shall > be sys/types.h. C libraries other than glibc, namely musl, did > not include that header via other ways and

Re: [uml-devel] [PATCH 2/3] um: Do not use stdin and stdout names for variables

2015-06-10 Thread Hans-Werner Hilse
Hi, Am 2015-06-10 23:37, schrieb Richard Weinberger: > On Wed, Jun 10, 2015 at 11:21 PM, Hans-Werner Hilse > wrote: >> Naming local variables "stdin" and "stdout" is fine with glibc, >> other C libraries, namely musl, will however complain. > > Wait, what?! > These are not local variables, they

Re: [uml-devel] [PATCH 2/3] um: Do not use stdin and stdout names for variables

2015-06-10 Thread Richard Weinberger
On Thu, Jun 11, 2015 at 8:35 AM, Hans-Werner Hilse wrote: > Hi, > > Am 2015-06-10 23:37, schrieb Richard Weinberger: >> On Wed, Jun 10, 2015 at 11:21 PM, Hans-Werner Hilse >> wrote: >>> Naming local variables "stdin" and "stdout" is fine with glibc, >>> other C libraries, namely musl, will howeve