Re: OPS4J Pax JDBC + Derby = Duplicate DataSource

2019-02-04 Thread Jean-Baptiste Onofré
Thanks Benjamin, much appreciated ;) Regards JB On 04/02/2019 21:50, Benjamin Graf wrote: Hi JB, OK, go for it and good night. :-) Regards Benjamin Am 04.02.2019 um 21:47 schrieb Jean-Baptiste Onofré: Indeed, It should work without the jdbc feature (Karaf one). I'm releasing Karaf

Re: OPS4J Pax JDBC + Derby = Duplicate DataSource

2019-02-04 Thread Jean-Baptiste Onofré
Indeed, It should work without the jdbc feature (Karaf one). I'm releasing Karaf 4.2.3 now (we are already late for this release). I'm gonna investigate the Derby case ;) Regards JB On 04/02/2019 21:36, Benjamin Graf wrote: Hi, I'm a little bit confused:    

Re: OPS4J Pax JDBC + Derby = Duplicate DataSource

2019-02-04 Thread Benjamin Graf
Hi, I'm a little bit confused:     mvn:org.osgi/org.osgi.service.jdbc/1.0.0     pax-jdbc-spec     mvn:org.apache.derby/derby/${derby.version} pax-jdbc-derby still does install mvn:org.osgi/org.osgi.service.jdbc/x.x.x but not mvn:org.ops4j.pax.jdbc/pax-jdbc/x.x.x Regards

Re: OPS4J Pax JDBC + Derby = Duplicate DataSource

2019-02-04 Thread Jean-Baptiste Onofré
Hi, Actually, this is because pax-jdbc-spec feature should have: dependency="true">mvn:org.osgi/org.osgi.service.jdbc/${org.osgi.service.jdbc.version} That's why jdbc feature make things working. If you don't mind, I would like to release Karaf 4.2.3 like this (as it works fine). In the

Re: OPS4J Pax JDBC + Derby = Duplicate DataSource

2019-02-04 Thread Benjamin Graf
Hi JB, I would suggest to add pax-jdbc feature as dependency to pax-jdbc-derby feature as it would work without. Just keep pax features independent from possible installed karaf feature. What do you think? Regards Benjamin Am 04.02.2019 um 21:20 schrieb Jean-Baptiste Onofré: > Hi Benjamin, >

Re: OPS4J Pax JDBC + Derby = Duplicate DataSource

2019-02-04 Thread Jean-Baptiste Onofré
Hi Benjamin, Previously, pax-jdbc-derby feature also needed pax-jdbc feature. I directly installed the derby bundle, it uses dynamic import, that's why it works with pax-jdbc-spec IMHO (with the package with DataSourceFactory is there). So, I'm not sure to see your point: in previous version,

Re: OPS4J Pax JDBC + Derby = Duplicate DataSource

2019-02-04 Thread Benjamin Graf
Hu JB, Just to summarize: Karaf jdbc installs pax-jdbc and pax-jdbc-config sub features. pax-jdbc is needed to get a DataSourceFactory instance for Driver only installations like Derby. Derby does not register a DataSourceFactory  directly. But if you do not install jdbc and/or pax-jdbc you

Re: OPS4J Pax JDBC + Derby = Duplicate DataSource

2019-02-04 Thread Jean-Baptiste Onofré
pax-jdbc installs the pax-jdbc-spec bundle, that's why. Regards JB On 04/02/2019 20:59, Benjamin Graf wrote: > This way pax-jdbc-derby also need pax-jdbc feature to get installed! > > Am 04.02.2019 um 20:57 schrieb Benjamin Graf: >> Hi JB, >> >> I install pax-jdbc-config and pax-jdbc-derby.

Re: OPS4J Pax JDBC + Derby = Duplicate DataSource

2019-02-04 Thread Benjamin Graf
This way pax-jdbc-derby also need pax-jdbc feature to get installed! Am 04.02.2019 um 20:57 schrieb Benjamin Graf: > Hi JB, > > I install pax-jdbc-config and pax-jdbc-derby. After installing pax-jdbc > I got the derby DataSourceFactory. IMHO pax-jdbc is not mandatory to > install and pooling

Re: OPS4J Pax JDBC + Derby = Duplicate DataSource

2019-02-04 Thread Jean-Baptiste Onofré
Hi, pax-jdbc-config already comes with jdbc feature. I know pooling doesn't work: that's an issue in the Derby bundle. So, I took the decision to fix the dual DataSourceFactory issue, and I created a Jira at Derby to fix the XA/Pooling issue. Regards JB On 04/02/2019 20:57, Benjamin Graf

Re: OPS4J Pax JDBC + Derby = Duplicate DataSource

2019-02-04 Thread Jean-Baptiste Onofré
Just to illustrate, on a freshly built 4.2.3-SNAPSHOT: karaf@root()> feature:install jdbc karaf@root()> feature:install pax-jdbc-derby karaf@root()> la|grep -i derby 52 │ Active │ 80 │ 10.14.200.1828579 │ Apache Derby 10.14 karaf@root()> bundle:services -p 52 Apache Derby 10.14 (52)

Re: OPS4J Pax JDBC + Derby = Duplicate DataSource

2019-02-04 Thread Benjamin Graf
Hi JB, I install pax-jdbc-config and pax-jdbc-derby. After installing pax-jdbc I got the derby DataSourceFactory. IMHO pax-jdbc is not mandatory to install and pooling seems to not work either. Regards Benjamin Am 04.02.2019 um 20:44 schrieb Jean-Baptiste Onofré: > By the way, Karaf example

Re: OPS4J Pax JDBC + Derby = Duplicate DataSource

2019-02-04 Thread Jean-Baptiste Onofré
Hi Benjamin, With Pax JDBC 1.3.3 ? I tested in Karaf and it's covered by Pax JDBC itest. I checked in Derby code, and there's the Activator that register the AutoloaderDriver with the factory. Let me double check but I'm surprised. What did you do ? feature:install jdbc feature:install

Re: OPS4J Pax JDBC + Derby = Duplicate DataSource

2019-02-04 Thread Jean-Baptiste Onofré
By the way, Karaf example itest (jdbc example) use Derby without problem. Regards JB On 04/02/2019 20:23, Benjamin Graf wrote: > Hi JB, > > if I install pax-jdbc-derby on a fresh Karaf 4.2.3-SNAPSHOT I do not get > a DataSourceFactory registered. I also do not found any code in derby > sources

Re: OPS4J Pax JDBC + Derby = Duplicate DataSource

2019-02-04 Thread Benjamin Graf
Hi JB, if I install pax-jdbc-derby on a fresh Karaf 4.2.3-SNAPSHOT I do not get a DataSourceFactory registered. I also do not found any code in derby sources that does anything about that if do not install pax-jdbc  to get the Driver instrumented. Regards Benjamin Am 04.02.2019 um 16:30

Re: OPS4J Pax JDBC + Derby = Duplicate DataSource

2019-02-04 Thread Jean-Baptiste Onofré
FYI: I did Pax JDBC 1.3.3 release yesterday, and Karaf 4.2.3-SNAPSHOT is already updated. So it will be included in 4.2.3 release that will be on vote tonight. Regards JB On 04/02/2019 16:27, Alex Soto wrote: > Thank you all, > > The workaround worked, i.e., removed feature /pax-jdbc-derby / 

Re: OPS4J Pax JDBC + Derby = Duplicate DataSource

2019-02-04 Thread Alex Soto
Thank you all, The workaround worked, i.e., removed feature pax-jdbc-derby and adding only the derby feature. Best regards, Alex soto > On Feb 2, 2019, at 1:48 AM, Jean-Baptiste Onofré wrote: > > That's what I'm testing: still keeping pax-jdbc-derby feature but just > installing the

Re: OPS4J Pax JDBC + Derby = Duplicate DataSource

2019-02-01 Thread Jean-Baptiste Onofré
That's what I'm testing: still keeping pax-jdbc-derby feature but just installing the derby bundle (not the pax-jdbc wrapper bundle). Regards JB On 02/02/2019 07:35, Christian Schneider wrote: > If derby now provides a DataSourceFactory then we should remove > pax-jdbc-derby from the feature. >

Re: OPS4J Pax JDBC + Derby = Duplicate DataSource

2019-02-01 Thread Christian Schneider
If derby now provides a DataSourceFactory then we should remove pax-jdbc-derby from the feature. I guess at some point derby started providing the DSF and we just forgot to remove the adapter bundle. Christian Am Sa., 2. Feb. 2019 um 07:19 Uhr schrieb Jean-Baptiste Onofré < j...@nanthrax.net>:

Re: OPS4J Pax JDBC + Derby = Duplicate DataSource

2019-02-01 Thread Jean-Baptiste Onofré
By the way, a simple workaround is to stop or even remove the pax-jdbc-derby bundle, and use only the derby bundle (or the opposite). Regards JB On 02/02/2019 06:55, Jean-Baptiste Onofré wrote: > OK, I think I found the problem: installing the pax-jdbc-derby feature > actually registers two

Re: OPS4J Pax JDBC + Derby = Duplicate DataSource

2019-02-01 Thread Jean-Baptiste Onofré
OK, I think I found the problem: installing the pax-jdbc-derby feature actually registers two DataSourceFactory services: 1. a DataSourceFactory service coming from pax-jdbc-derby bundle (which is normal) (org.apache.derby.jdbc.EmbeddedDriver) 2. a DataSourceFactory service coming from directly

Re: OPS4J Pax JDBC + Derby = Duplicate DataSource

2019-02-01 Thread Jean-Baptiste Onofré
It would certainly require a new pax-jdbc release. Anyway, it's not a blocker IMHO (having two service is not a big deal). I hope to fix that today in order to include in Karaf 4.2.3 release. Regards JB On 01/02/2019 19:10, Alex Soto wrote: > Oh, thanks! > > Can you suggest a work around?  >

Re: OPS4J Pax JDBC + Derby = Duplicate DataSource

2019-02-01 Thread Alex Soto
Oh, thanks! Can you suggest a work around? What s the ETA for a fix? I have a release deadline looming and I am afraid I can't wait too long. Thank you for the prompt response. Best regards, Alex soto > On Feb 1, 2019, at 1:05 PM, Jean-Baptiste Onofré wrote: > > Indeed, I can

Re: OPS4J Pax JDBC + Derby = Duplicate DataSource

2019-02-01 Thread Jean-Baptiste Onofré
Indeed, I can reproduce the issue embedded: Name│ Service Id │ Product │ Version │ URL │ Status ┼┼──┼───┼───┼─── querier │ 91 │ Apache Derby │ 10.13.1.1 -

Re: OPS4J Pax JDBC + Derby = Duplicate DataSource

2019-02-01 Thread Alex Soto
> How to do you provision the datasource cfg file ? > Using a feature or by dropping the file in the etc folder ? Dropping file in the etc/ directory Best regards, Alex soto > On Feb 1, 2019, at 12:57 PM, Jean-Baptiste Onofré wrote: > > Hi, > > I just did a blog where I'm using a derby

Re: OPS4J Pax JDBC + Derby = Duplicate DataSource

2019-02-01 Thread Jean-Baptiste Onofré
Hi, I just did a blog where I'm using a derby datasource (on Karaf 4.2.3-SNAPSHOT): http://blog.nanthrax.net/?p=874 If you install an unique provider (only derby or derbyclient, but not both), then, it should work. I did: feature:install pax-jdbc-derbyclient then: jdbc:ds-create -dn