Re: Java 11 support

2019-01-17 Thread Sebastian Götz
Hi folks, it appears that there is some work left in the convention plugin. As I can see from my IVY resolve process this plugin drags in asm 5.2. From its sources it looks like it supports class version up to 1.8 (class version 52). As we compile with JDK 11 already (class version 55) we get

Re: Java 11 support

2019-01-17 Thread Lukasz Lenart
Hm... I thought we switched to ASM 7.0 in struts-2-5-x branch - at least in the master branch we have it which means Struts 2.6 supports JDK 11 czw., 17 sty 2019 o 14:11 Sebastian Götz napisał(a): > Hi folks, > > it appears that there is some work left in the convention plugin. As I > can see

Re: Java 11 support

2019-01-17 Thread Sebastian Götz
Okay. I have taken a look at the struts-2-5-x branch in github. There is a global property in the struts-parentof that defines the version for ASM: 5.2 The struts-masterpom of the current github *master branch* has: 7.0 But when I look into DefaultClassFinder$InfoBuildingVisitorclass (line

Re: Java 11 support

2019-01-17 Thread Lukasz Lenart
Hm... strange but our builds are passing on JDK 11 https://builds.apache.org/view/S-Z/view/Struts/job/Struts-master-JDK11/ also on Travis https://travis-ci.org/apache/struts pt., 18 sty 2019 o 08:46 Sebastian Götz napisał(a): > Okay. > > I have taken a look at the struts-2-5-x branch in github.