Re: outstandingChanges queue grows without bound

I've pulled this into a separate branch after incorporating some feedback. https://github.com/msolo/zookeeper/commits/msolo-optimize-close-session On Fri, Oct 14, 2016 at 12:03 AM, Mike Solomon wrote: > Thanks for the comments - I'll incorporate them in a future fix. There >

Re: outstandingChanges queue grows without bound

Thanks for the comments - I'll incorporate them in a future fix. There is actually a flaw in this code as it's currently implemented - it does not match the original behavior and I need to think more carefully. Arshad, I think ZOOKEEPER-2570 is a somewhat different issue. The root cause in both

Re: outstandingChanges queue grows without bound

Very interesting patch, Mike. I've left a couple of review comments (hope you don't mind) in the https://github.com/msolo/zookeeper/commit/75da352d506c2e3b0001d28acc058c 422b3c8f0c commit. :) Cheers, Eddie On Thu, Oct 13, 2016 at 4:06 PM, Arshad Mohammad < arshad.mohamma...@gmail.com> wrote:

Re: outstandingChanges queue grows without bound

Hi Mike I also faced same issue. There is test patch in ZOOKEEPER-2570 which can be used to quickly check performance gains in each modification. Hope it is useful. -Arshad On Thu, Oct 13, 2016 at 1:27 AM, Mike Solomon wrote: > I've been performance testing 3.5.2 and hit