Re: ActiveMQ v5 plugin migration to Artemis

2020-02-25 Thread David Martin
Hi Justin, Having pulled the code and run some tests I found that, The good news is : 1. Can already override the Filter in beforeCreateConsumer() and verified this works 2. Can already override message content & headers in beforeSend() as per existing broker plugin example What's missing in

Re: ActiveMQ v5 plugin migration to Artemis

2020-02-20 Thread David Martin
Hi Justin, Having done some analysis I think I need to do the following however it appears that QueueConfig is intended to be immutable so maybe point (3) below is undesirable. Alternatively beforeCreateQueue() could return QueueConfig (by default returning input param as-is) in order to be able

Re: ActiveMQ v5 plugin migration to Artemis

2020-02-15 Thread David Martin
Thanks Justin, That sounds like a great idea to me - will submit a pr. It enables clients to be quite dumb and the broker can also be in full control of what they receive based on their credentials. Dave On Sat, Feb 15, 2020, 7:06 PM Justin Bertram wrote: > Interceptors work on a

Re: ActiveMQ v5 plugin migration to Artemis

2020-02-15 Thread Justin Bertram
Interceptors work on a per-protocol basis and the way they work for each is slightly different. I think you can do what you want for core clients using interceptors, but I don't think it will work for AMQP. AMQP interceptors don't intercept low-level packets/frames like the other interceptors do

Re: ActiveMQ v5 plugin migration to Artemis

2020-02-15 Thread David Martin
Hi Justin, AMQP or Core - can be either Thanks, Dave On Fri, Feb 14, 2020, 11:02 PM Justin Bertram wrote: > What protocol are your clients going to be using? > > > Justin > > On Fri, Feb 14, 2020 at 3:28 PM David Martin wrote: > > > Thanks Chris - > > > > Unfortunately what I need to

Re: ActiveMQ v5 plugin migration to Artemis

2020-02-14 Thread Justin Bertram
What protocol are your clients going to be using? Justin On Fri, Feb 14, 2020 at 3:28 PM David Martin wrote: > Thanks Chris - > > Unfortunately what I need to override (queue name and filter) is read only: > > >

Re: ActiveMQ v5 plugin migration to Artemis

2020-02-14 Thread David Martin
Thanks Chris - Unfortunately what I need to override (queue name and filter) is read only: https://github.com/apache/activemq-artemis/blob/master/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ConsumerInfo.java Wondering whether an interceptor is what I need? Unless I'm

Re: ActiveMQ v5 plugin migration to Artemis

2020-02-14 Thread Christopher Shannon
Take a look at the plugin API for Artemis: https://activemq.apache.org/components/artemis/documentation/latest/broker-plugins.html Specifically you can implement your own ActiveMQServerPlugin (which extends many other plugin interfaces) and has a ton of hooks into the broker to do what you need.

ActiveMQ v5 plugin migration to Artemis

2020-02-13 Thread David Martin
Hi everyone, Decided to switch to Artemis which is not going to be difficult in the main but not sure of my best option to migrate a broker plugin which overrides *addConsumer()* to set a new destination and a message selector using broker-side business logic based on the user credentials. It