Re: Camel with Rabbitmq: messages in temp reply queue not being acked

2018-08-22 Thread Claus Ibsen
Hi Thanks the PR has been merged, you can see from the fix-version in the JIRA which releases it will be in On Wed, Aug 22, 2018 at 10:58 AM, Valdis Andersons wrote: > Hi Claus, > > Pull request #2490 has been created now. > https://github.com/apache/camel/pull/2490 > > If you're happy with

RE: Camel with Rabbitmq: messages in temp reply queue not being acked

2018-08-22 Thread Valdis Andersons
Hi Claus, Pull request #2490 has been created now. https://github.com/apache/camel/pull/2490 If you're happy with the change could you please merge it up and let me know which release will have the code in it? Also, if there is anything more I need to do with the fix/Pull Request please let

Re: Camel with Rabbitmq: messages in temp reply queue not being acked

2018-08-22 Thread Claus Ibsen
Hi Validis Yeah that sounds good. Great to hear we have a solution for this issue now. On Tue, Aug 21, 2018 at 5:58 PM, Valdis Andersons wrote: > Hi Claus, > > That seems to work as expected, deployed a local build to test and no more > stale messages in un-acked states in the temp reply

RE: Camel with Rabbitmq: messages in temp reply queue not being acked

2018-08-21 Thread Valdis Andersons
Hi Claus, That seems to work as expected, deployed a local build to test and no more stale messages in un-acked states in the temp reply queues and in addition it doesn't seem to brake any tests either. JIRA ticket here: https://issues.apache.org/jira/browse/CAMEL-12746 Tomorrow I'll figure

Re: Camel with Rabbitmq: messages in temp reply queue not being acked

2018-08-21 Thread Claus Ibsen
On Tue, Aug 21, 2018 at 10:05 AM, Valdis Andersons wrote: > Hi Claus, > > Thanks for your time and the response. I'll see if I can check out the code > today and build it locally and then deploy to a test environment. > As you suggested, I'll make a change to the TemporaryQueueReplyManager at >

RE: Camel with Rabbitmq: messages in temp reply queue not being acked

2018-08-21 Thread Valdis Andersons
Hi Claus, Thanks for your time and the response. I'll see if I can check out the code today and build it locally and then deploy to a test environment. As you suggested, I'll make a change to the TemporaryQueueReplyManager at line 139 to always create a temp queue with autoAck=ture. Please let

Re: Camel with Rabbitmq: messages in temp reply queue not being acked

2018-08-21 Thread Claus Ibsen
Hi You may be on to something. It does smell like when using temporary queues for request/response then acknowledge should maybe be auto always, so the "other side" can see the message on the temporary queue, process it, and send back a reply message, for Camel to pickup. I wonder if you could

RE: Camel with Rabbitmq: messages in temp reply queue not being acked

2018-08-17 Thread Valdis Andersons
Hi All, Been digging today through some of the Camel-RabbitMQ code and can confirm now that the temp queue is created with the main endpoint's relevant properties (prefetch, autoAck and some others). The ack mode is set when the consumer get bound to the channel - TemporaryQueueReplyManager