Re: vsnprintf broken

2007-11-12 Thread Johannes Hofmann
Simon 'corecode' Schubert <[EMAIL PROTECTED]> wrote: > [-- text/plain, encoding quoted-printable, charset: UTF-8, 29 lines --] > > Simon 'corecode' Schubert wrote: >> Johannes Hofmann wrote: >>> Hello, >>> >>> I see crashes with a string handling library on DragonFly. >>> The problem can be reduce

Re: va_copy() problem

2007-11-12 Thread Johannes Hofmann
Joerg Sonnenberger <[EMAIL PROTECTED]> wrote: > On Mon, Nov 12, 2007 at 06:58:30PM +, Johannes Hofmann wrote: >> va_copy(va1, va); >> n = vsnprintf(s->str + s->len, s->size - s->len, format, va); >> va_end(va1); > > va -> va1 in the call to vsnprintf.

vsnprintf broken (was: Re: gcc update)

2007-11-12 Thread Simon 'corecode' Schubert
Simon 'corecode' Schubert wrote: > Johannes Hofmann wrote: >> Hello, >> >> I see crashes with a string handling library on DragonFly. >> The problem can be reduced to the test program below. It crashes on >> DragonFly when compiled with "gcc -O2 -o foo foo.c". Without -O2 it >> runs fine. No probl

Re: gcc update (was: Re: va_copy() problem)

2007-11-12 Thread Joerg Sonnenberger
On Mon, Nov 12, 2007 at 09:27:17PM +0100, Simon 'corecode' Schubert wrote: > No, the problem is that gcc uses %ebx after a function call, which it is > not allowed to do: It is allowed to. From the i386 ABI: If necessary, a function saves the values of %edi, %esi, and %ebx in the positions shown

Re: va_copy() problem

2007-11-12 Thread Joerg Sonnenberger
On Mon, Nov 12, 2007 at 06:58:30PM +, Johannes Hofmann wrote: > va_copy(va1, va); > n = vsnprintf(s->str + s->len, s->size - s->len, format, va); > va_end(va1); va -> va1 in the call to vsnprintf. Also consider using vasprintf. Joerg

gcc update (was: Re: va_copy() problem)

2007-11-12 Thread Simon 'corecode' Schubert
Johannes Hofmann wrote: > Hello, > > I see crashes with a string handling library on DragonFly. > The problem can be reduced to the test program below. It crashes on > DragonFly when compiled with "gcc -O2 -o foo foo.c". Without -O2 it > runs fine. No problems on Linux with or without -O2. > Can

va_copy() problem

2007-11-12 Thread Johannes Hofmann
Hello, I see crashes with a string handling library on DragonFly. The problem can be reduced to the test program below. It crashes on DragonFly when compiled with "gcc -O2 -o foo foo.c". Without -O2 it runs fine. No problems on Linux with or without -O2. Can anyone spot the problem? I think its r