Hi Karl,
I understand how ServiceLoader works. But in OSGi the proper way to do
ServiceLoader is what is described in the Service Loader Mediator
specification (see [1]). Playing with the TCCL is just a workaround and
error prone. Also, it seems to me that setting the TCCL to a specific
Hi Eric,
sorry, I was a bit brief in my last mail (was on my phone). The point is:
the TCCL is the mechanism intended for configuring a ServiceLoader.
That is how this is supposed to work. The problem typically is that in
OSGi it is either not set or its set to the wrong classloader.
However, it
Hi Karl,
Perhaps juggling the TCCL around the jetty startup code would workaround
the specific startup error from PreEncodedHttpField, but I don't really
like doing that around such a broad block of someone else's code. It
wouldn't be clear to me that it doesn't have any unintended side effects
I think you can just set the thread context classloader to the classloader
of the bundle in the activator and then you don’t need the spifly thingy at
all anymore...
regards,
Karl
On Sunday, July 15, 2018, Eric Norman wrote:
> Hi Carsten,
>
> I tried to make it work with an uber bundle by
Hi Carsten,
I tried to make it work with an uber bundle by merging in the important
stuff. In this case the o.a.felix.http.jetty is both a consumer and a
producer of a few ServiceLoader services.
Unfortunately, it looks like there is a problem with using the service
loader mediator stuff in the
Let's not forget the fact that jetty is not semantically versioned, which
can cause ugly problems. The Uber jetty bundle hides this concern.
I'm not saying this couldn't be solved somehow but it can't be ignored.
And also don't get me wrong, I love jetty!
The thing is that Felix modules are
Hi Eric,
that sounds interesting. As far as I remember we started to embed Jetty
as by that time Jetty was not available as OSGi bundles out of the box.
The other reason is ease of use, you just need to install a single
bundle - which is sufficient for most users - instead of a set of bundles.
I've been doing some work to enable the HTTP/2 support in jetty for usage
within the Felix Http Jetty 4.x bundle for an apache sling based project.
I'm not sure about the history of the felix.http.jetty bundle, but can I
ask why it was decided to make copies of the jetty classes inside the felix
8 matches
Mail list logo
