Re: FlexJS, JQuery and FDT

2016-04-21 Thread Harbs
changes soon. > But today I'm completely stuck with the JS externs no longer generating :-( > > Chris > > > Von: Harbs <harbs.li...@gmail.com> > Gesendet: Donnerstag, 21. April 2016 12:40 > An: users@flex.apache.org > Betre

AW: FlexJS, JQuery and FDT

2016-04-21 Thread Christofer Dutz
ag, 21. April 2016 12:40 An: users@flex.apache.org Betreff: Re: FlexJS, JQuery and FDT OK. Would it be easier to have a wiki page that we document build-related changes in, so they are all in one place? We could send an email with a link to the page when it’s edited. On Apr 21, 2016, at 1

Re: FlexJS, JQuery and FDT

2016-04-21 Thread Harbs
t; Gesendet: Donnerstag, 21. April 2016 11:48 > An: users@flex.apache.org > Betreff: Re: FlexJS, JQuery and FDT > > OK. Can you recommend a workflow so these changes are properly captured? > > On Apr 21, 2016, at 12:40 PM, Christofer Dutz <christofer.d...@c-ware.de> >

AW: FlexJS, JQuery and FDT

2016-04-21 Thread Christofer Dutz
sendet: Donnerstag, 21. April 2016 11:48 An: users@flex.apache.org Betreff: Re: FlexJS, JQuery and FDT OK. Can you recommend a workflow so these changes are properly captured? On Apr 21, 2016, at 12:40 PM, Christofer Dutz <christofer.d...@c-ware.de> wrote: > Hi, > > just a request from my si

Re: FlexJS, JQuery and FDT

2016-04-21 Thread Harbs
ads, please inform me about that cause > these are impossible to auto-merge and even harder to detect. > > Chris > > > Von: Alex Harui <aha...@adobe.com> > Gesendet: Donnerstag, 21. April 2016 09:07 > An: users@flex.apache.o

AW: FlexJS, JQuery and FDT

2016-04-21 Thread Christofer Dutz
aha...@adobe.com> Gesendet: Donnerstag, 21. April 2016 09:07 An: users@flex.apache.org Betreff: Re: FlexJS, JQuery and FDT We do these kinds of changes with Ant replace and replaceregex in the build.xml. See the top-level build.xml and the externc.js.swc target. -Alex On 4/21/16, 12:04 AM, "Harbs

Re: FlexJS, JQuery and FDT

2016-04-21 Thread Alex Harui
We do these kinds of changes with Ant replace and replaceregex in the build.xml. See the top-level build.xml and the externc.js.swc target. -Alex On 4/21/16, 12:04 AM, "Harbs" wrote: >Bah. .gitignore has this entry: externs/jquery/externs > >Is there any way to make

Re: FlexJS, JQuery and FDT

2016-04-21 Thread Harbs
Bah. .gitignore has this entry: externs/jquery/externs Is there any way to make this change and have it “stick” in the repo? On Apr 21, 2016, at 10:00 AM, Harbs wrote: > OK. I’ll make that change. I don’t have time to test today, so I’ll see what > happens in the next

Re: FlexJS, JQuery and FDT

2016-04-21 Thread Harbs
FWIW, I just tried this, and the swc was not as well defined. Not sure why… On Apr 21, 2016, at 2:46 AM, OmPrakash Muppirala wrote: > or are you using the > dts2as tool to create one from a definitely typed definition file

Re: FlexJS, JQuery and FDT

2016-04-21 Thread Harbs
OK. I’ll make that change. I don’t have time to test today, so I’ll see what happens in the next nightly… On Apr 21, 2016, at 9:55 AM, Alex Harui wrote: > I think it should be: > > /** > * @const > * @type {jQuery} > */ > var $ = jQuery; > > Look at other extern files for

Re: FlexJS, JQuery and FDT

2016-04-21 Thread Alex Harui
I think it should be: /** * @const * @type {jQuery} */ var $ = jQuery; Look at other extern files for similar usage. -Alex On 4/20/16, 11:36 PM, "Harbs" wrote: >Yes. I was looking in asjs instead of falcon… > >I’ve never done typdefs before. Does this look right?

Re: FlexJS, JQuery and FDT

2016-04-21 Thread Harbs
Yes. I was looking in asjs instead of falcon… I’ve never done typdefs before. Does this look right? /** * @const * @typedef {jQuery} */ var $ = jQuery; It’s currently: /** * @const */ var $ = jQuery; On Apr 21, 2016, at 9:25 AM, OmPrakash Muppirala wrote: > I think

Re: FlexJS, JQuery and FDT

2016-04-21 Thread OmPrakash Muppirala
I think this is what you are looking for? : flex-falcon\externs\jquery\externs\jquery-1.9.js Thanks, Om On Wed, Apr 20, 2016 at 11:21 PM, Harbs wrote: > I’m looking for where the jQuery definitions are and I can’t seem to find > it. > > On Apr 21, 2016, at 3:17 AM, Alex

Re: FlexJS, JQuery and FDT

2016-04-21 Thread Harbs
Yes. On Apr 21, 2016, at 2:46 AM, OmPrakash Muppirala wrote: > Are you using the jquery.swc from the externs file

Re: FlexJS, JQuery and FDT

2016-04-21 Thread Harbs
I’m looking for where the jQuery definitions are and I can’t seem to find it. On Apr 21, 2016, at 3:17 AM, Alex Harui wrote: > Looks like the externs file doesn't have an @type for the $ constant. You > can try adding it in the build script or see if Google will accept a

Re: FlexJS, JQuery and FDT

2016-04-20 Thread OmPrakash Muppirala
Are you using the jquery.swc from the externs file, or are you using the dts2as tool to create one from a definitely typed definition file? I think I remember seeing the one from our externs code work fine with the $ call. Thanks, Om On Wed, Apr 20, 2016 at 4:13 PM, Harbs

Re: FlexJS, JQuery and FDT

2016-04-20 Thread Harbs
Replacing “$” with “jQuery” makes the warnings go away. Why would “$” be different than “jQuery”? It sounds to me like a bug in the definitions. jQuery always returns a JQuery object which has many defined methods. One of those is attr. On Apr 21, 2016, at 1:50 AM, Alex Harui

Re: FlexJS, JQuery and FDT

2016-04-20 Thread Alex Harui
IMO, this is why Jquery is painful for strong typing. I think you may need to do casting: ($("#topcoat") as Whatever).attr(..) Where Whatever is a "type" that has an attr function. And you may need to use @flexjsignorecoercion or other compiler options to not actually do the "as" test

Re: FlexJS, JQuery and FDT

2016-04-20 Thread Harbs
Here’s an example: $("#topcoat").attr("href", "css/topcoat-desktop-lightlight.min.css"); It looks like “$” is defined as an object. Here’s the exact warnings I’m getting: Could not resolve variable (may be a dynamic member) 'attr' at line 43 column 19. ThemeManager.as

Re: FlexJS, JQuery and FDT

2016-04-20 Thread Alex Harui
On 4/20/16, 3:34 PM, "Harbs" wrote: >Does anyone know if there’s a way to get FDT to not flag JQuery >expressions with “could not resolve variable” and "Maybe invoke a non >function” warnings? What kind of expressions result in this output? Are you sure you have the

FlexJS, JQuery and FDT

2016-04-20 Thread Harbs
Does anyone know if there’s a way to get FDT to not flag JQuery expressions with “could not resolve variable” and "Maybe invoke a non function” warnings?