Re: HTTP QueryExecution has been closed

[Martynas Jusevičius]

What I meant: can try-with-resources call qex.close() before
constructQuads even does the checkNotClosed() check?

On Fri, Oct 27, 2023 at 11:31 PM Martynas Jusevičius
 wrote:
>
> Can try-with-resources call qex.close() before constructDataset() does here?
> https://github.com/apache/jena/blob/main/jena-arq/src/main/java/org/apache/jena/sparql/exec/QueryExecDataset.java#L232
>
> On Fri, Oct 27, 2023 at 11:18 PM Martynas Jusevičius
>  wrote:
> >
> > Hi,
> >
> > I'm trying to understand in which circumstances can the following code
> >
> > try (QueryExecution qex = QueryExecution.create(getQuery(), 
> > rowModel))
> > {
> > return qex.execConstructDataset();
> > }
> >
> > throw the "HTTP QueryExecution has been closed" exception?
> > Full code here:
> > https://github.com/AtomGraph/LinkedDataHub/blob/rf-direct-graph-ids-only/src/main/java/com/atomgraph/linkeddatahub/imports/stream/csv/CSVGraphStoreRowProcessor.java#L141
> >
> > The execution is not even happening over HTTP? Is it somehow closed 
> > prematurely?
> >
> > I can see the exception being thrown in QueryExecDataset::constructQuads:
> > https://github.com/apache/jena/blob/main/jena-arq/src/main/java/org/apache/jena/sparql/exec/QueryExecDataset.java#L211
> >
> > Martynas

Re: HTTP QueryExecution has been closed

[Martynas Jusevičius]

Can try-with-resources call qex.close() before constructDataset() does here?
https://github.com/apache/jena/blob/main/jena-arq/src/main/java/org/apache/jena/sparql/exec/QueryExecDataset.java#L232

On Fri, Oct 27, 2023 at 11:18 PM Martynas Jusevičius
 wrote:
>
> Hi,
>
> I'm trying to understand in which circumstances can the following code
>
> try (QueryExecution qex = QueryExecution.create(getQuery(), rowModel))
> {
> return qex.execConstructDataset();
> }
>
> throw the "HTTP QueryExecution has been closed" exception?
> Full code here:
> https://github.com/AtomGraph/LinkedDataHub/blob/rf-direct-graph-ids-only/src/main/java/com/atomgraph/linkeddatahub/imports/stream/csv/CSVGraphStoreRowProcessor.java#L141
>
> The execution is not even happening over HTTP? Is it somehow closed 
> prematurely?
>
> I can see the exception being thrown in QueryExecDataset::constructQuads:
> https://github.com/apache/jena/blob/main/jena-arq/src/main/java/org/apache/jena/sparql/exec/QueryExecDataset.java#L211
>
> Martynas

HTTP QueryExecution has been closed

[Martynas Jusevičius]

Hi,

I'm trying to understand in which circumstances can the following code

try (QueryExecution qex = QueryExecution.create(getQuery(), rowModel))
{
return qex.execConstructDataset();
}

throw the "HTTP QueryExecution has been closed" exception?
Full code here:
https://github.com/AtomGraph/LinkedDataHub/blob/rf-direct-graph-ids-only/src/main/java/com/atomgraph/linkeddatahub/imports/stream/csv/CSVGraphStoreRowProcessor.java#L141

The execution is not even happening over HTTP? Is it somehow closed prematurely?

I can see the exception being thrown in QueryExecDataset::constructQuads:
https://github.com/apache/jena/blob/main/jena-arq/src/main/java/org/apache/jena/sparql/exec/QueryExecDataset.java#L211

Martynas

qparse but preserve comments

[Justin]

Hello,

Is it possible to allow qparse to preserve comments?

e.g. it currently does not:
```
justin@parens:/tmp$ cat a.rq
select * where {
?s ?p ?o
# comment here
}
justin@parens:/tmp$ ~/Downloads/apache-jena-4.7.0/bin/qparse --query a.rq
SELECT  *
WHERE
  { ?s  ?p  ?o }
```

If comment lines (starting with #) are too tricky to work with what about
something like Clojure's `comment`
e.g.

```
(comment (range 5))
```
That way the "comment" is still part of the AST tree.
Maybe there could be a magic predicate that gets ignored?
```
[] ex:comment "comment here" .
```