Re: [kafka streams] 'null' values in state stores

2017-08-09 Thread Bart Vercammen
Hi Guy, Indeed, I referenced the wrong source-code, sorry about that ;-) I created KAFKA-5717 for this. Thanks Bart On Tue, Aug 8, 2017 at 8:08 PM, Damian Guy wrote: > The change logger is not used during restoration of the in-memory-store. > Restoration is handled >

Re: [kafka streams] 'null' values in state stores

2017-08-08 Thread Damian Guy
The change logger is not used during restoration of the in-memory-store. Restoration is handled https://github.com/apache/kafka/blob/0.11.0/streams/src/main/java/org/apache/kafka/streams/state/internals/InMemoryKeyValueStore.java#L79 But, even then it is just putting `null` when it should be

Re: [kafka streams] 'null' values in state stores

2017-08-08 Thread Damian Guy
Hi, The null values are treated as deletes when they are written to the store. You can see here: https://github.com/apache/kafka/blob/0.11.0/streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java#L261 On Tue, 8 Aug 2017 at 11:22 Bart Vercammen wrote: