Re: Data loss in case of request.required.acks set to -1

2013-12-25 Thread Hanish Bansal
Thanks Guozhang for response !! I filed a jira KAFKA-1193 regarding this. On Tue, Dec 24, 2013 at 5:48 PM, Guozhang Wang wrote: > Hanish, > > In this case I believe it is a bug for kill -9 scenario. Could you file a > jira and describe the pro

Re: Data loss in case of request.required.acks set to -1

2013-12-24 Thread Guozhang Wang
Hanish, In this case I believe it is a bug for kill -9 scenario. Could you file a jira and describe the process to reproduce? Guozhang On Mon, Dec 23, 2013 at 7:42 PM, Hanish Bansal < hanish.bansal.agar...@gmail.com> wrote: > Sorry last message was sent by mistake. > > Hi Guazhang, > > Please

Re: Data loss in case of request.required.acks set to -1

2013-12-23 Thread Hanish Bansal
Sorry last message was sent by mistake. Hi Guazhang, Please find my comments below : On Tue, Dec 24, 2013 at 12:52 AM, Guozhang Wang wrote: > Hanish, > > Originally when you create the two partitions their leadership should be > evenly distributed to two brokers, i.e. one broker get one parti

Re: Data loss in case of request.required.acks set to -1

2013-12-23 Thread Hanish Bansal
On Tue, Dec 24, 2013 at 12:52 AM, Guozhang Wang wrote: > Hanish, > > Originally when you create the two partitions their leadership should be > evenly distributed to two brokers, i.e. one broker get one partition. > But from your case broker 1 is the leader for both partition 1 and 0, and > from

Re: Data loss in case of request.required.acks set to -1

2013-12-23 Thread Guozhang Wang
Controlled shutdown will wait for the brokers which are going to take over the partitions the shutting down broker is handling to be in sync before doing the migration, so yes it will assure this. To check the number of brokers in ISR you can use kafka-topics tool. Guozhang On Mon, Dec 23, 2013

Re: Data loss in case of request.required.acks set to -1

2013-12-23 Thread Jason Rosenberg
Is it possible to expose programmatically, the number of brokers in ISR for each partition? We could make this a gating thing before shutting down a broker gracefully, to make sure things are in good shape.I guess controlled shutdown assures this anyway, in a sense. Jason On Mon, Dec 23

Re: Data loss in case of request.required.acks set to -1

2013-12-23 Thread Guozhang Wang
Hanish, Originally when you create the two partitions their leadership should be evenly distributed to two brokers, i.e. one broker get one partition. But from your case broker 1 is the leader for both partition 1 and 0, and from the replica list broker 0 should be originally the leader for partit

Re: Data loss in case of request.required.acks set to -1

2013-12-22 Thread Hanish Bansal
Hi Guazhang, When both nodes are alive then topic isr status is: topic: test-trunk111partition: 0leader: 0replicas: 1,0isr: 0 topic: test-trunk111partition: 1leader: 0replicas: 0,1isr: 0 Now as the leader node is broker-0 so when i am producing the data then meanw

Re: Data loss in case of request.required.acks set to -1

2013-12-20 Thread Guozhang Wang
Hanish, One thing you can check is when you kill one of the brokers, is the other broker on the ISR last of the partition that killed broker is hosting. This can be done using the kafka-topics tool. Also you can check if the controller log if there is any entry like "No broker in ISR is alive for

Re: Data loss in case of request.required.acks set to -1

2013-12-20 Thread Jun Rao
Could you reproduce this easily? If so, could you file a jira and describe the steps? Thanks, Jun On Thu, Dec 19, 2013 at 9:41 PM, Hanish Bansal < hanish.bansal.agar...@gmail.com> wrote: > Hi Guozhang, > > I have tried with Kafka-0.8.1 after applying patch 1188 but thats not > helping in this

Re: Data loss in case of request.required.acks set to -1

2013-12-19 Thread Hanish Bansal
Hi Guozhang, I have tried with Kafka-0.8.1 after applying patch 1188 but thats not helping in this case. Also controlled.shutdown.enable is also not helpful in case of abnormally shutdown (i.e. SIGKILL (-9)). Any other suggestion? On Thu, Dec 19, 2013 at 3:59 PM, Guozhang Wang wrote: > Yes,

Re: Data loss in case of request.required.acks set to -1

2013-12-19 Thread Guozhang Wang
Yes, please go ahead. On Thu, Dec 19, 2013 at 2:30 AM, Hanish Bansal < hanish.bansal.agar...@gmail.com> wrote: > Hi Guazhang, > > Can I try it now with trunk HEAD kafka code after applying the patch > KAFKA-1188.patch< > https://issues.apache.org/jira/secure/attachment/12619475/KAFKA-1188.patch

Re: Data loss in case of request.required.acks set to -1

2013-12-19 Thread Hanish Bansal
Hi Guazhang, Can I try it now with trunk HEAD kafka code after applying the patch KAFKA-1188.patch? On Wed, Dec 18, 2013 at 9:49 PM, Guozhang Wang wrote: > Kafka server's shutdown hook should capture all SIG but NOT

Re: Data loss in case of request.required.acks set to -1

2013-12-18 Thread Guozhang Wang
Kafka server's shutdown hook should capture all SIG but NOT SIGKILL (-9), and the controlled shut down process will not be triggered in this case. That said, if the other replica is in ISR then even kill -9 should not lose data. I am currently working on this JIRA that might be related if brokers

Re: Data loss in case of request.required.acks set to -1

2013-12-18 Thread Joe Stein
leader election should start for the brokers that are in the isr for the partitions that are on that replica that are leaders by the other replicas still in the isr, and the leader failed removed from the isr. The isr will shrink for all other partitions this broker is in the isr on but not the le

Re: Data loss in case of request.required.acks set to -1

2013-12-18 Thread Robert Rodgers
what happens if the physical machine dies or the kernel panics? On Dec 18, 2013, at 9:44 AM, Hanish Bansal wrote: > Yup definitely i would like to try that If controlled.shutdown.enable > property works in case of kill -9. > > I hope that this option will be perfect. > > Thanks for quick resp

Re: Data loss in case of request.required.acks set to -1

2013-12-18 Thread Hanish Bansal
Yup definitely i would like to try that If controlled.shutdown.enable property works in case of kill -9. I hope that this option will be perfect. Thanks for quick response, really appreciate it. On Wed, Dec 18, 2013 at 10:52 PM, Joe Stein wrote: > Wouldn't you want to set the controlled.shutd

Re: Data loss in case of request.required.acks set to -1

2013-12-18 Thread Joe Stein
Wouldn't you want to set the controlled.shutdown.enable to true so the broker would do this for you before ending itself? /*** Joe Stein Founder, Principal Consultant Big Data Open Source Security LLC http://www.stealth.ly Twitter: @allthingshadoop

Re: Data loss in case of request.required.acks set to -1

2013-12-18 Thread Hanish Bansal
I am having 2 replicas. Guozhang, I tried both scenario first is only using kill -9 and 2nd is kill and bouncing that. On Wed, Dec 18, 2013 at 10:06 PM, pushkar priyadarshi < priyadarshi.push...@gmail.com> wrote: > my doubt was they are dropping off at producer level only.so suggested > play

Re: Data loss in case of request.required.acks set to -1

2013-12-18 Thread pushkar priyadarshi
my doubt was they are dropping off at producer level only.so suggested playing with paramaters like retries and backoff.ms and also with refreshinterval on producer side. Regards, Pushkar On Wed, Dec 18, 2013 at 10:01 PM, Guozhang Wang wrote: > Hanish, > > Did you "kill -9" one of the brokers

Re: Data loss in case of request.required.acks set to -1

2013-12-18 Thread Guozhang Wang
Hanish, Did you "kill -9" one of the brokers only or bouncing them iteratively? Guozhang On Wed, Dec 18, 2013 at 8:02 AM, Joe Stein wrote: > How many replicas do you have? > > > On Wed, Dec 18, 2013 at 8:57 AM, Hanish Bansal < > hanish.bansal.agar...@gmail.com> wrote: > > > Hi pushkar, > > >

Re: Data loss in case of request.required.acks set to -1

2013-12-18 Thread Joe Stein
How many replicas do you have? On Wed, Dec 18, 2013 at 8:57 AM, Hanish Bansal < hanish.bansal.agar...@gmail.com> wrote: > Hi pushkar, > > I tried with configuring "message.send.max.retries" to 10. Default value > for this is 3. > > But still facing data loss. > > > On Wed, Dec 18, 2013 at 12:44

Re: Data loss in case of request.required.acks set to -1

2013-12-18 Thread Hanish Bansal
Hi pushkar, I tried with configuring "message.send.max.retries" to 10. Default value for this is 3. But still facing data loss. On Wed, Dec 18, 2013 at 12:44 PM, pushkar priyadarshi < priyadarshi.push...@gmail.com> wrote: > You can try setting a higher value for "message.send.max.retries" in

Re: Data loss in case of request.required.acks set to -1

2013-12-18 Thread pushkar priyadarshi
You can try setting a higher value for "message.send.max.retries" in producer config. Regards, Pushkar On Wed, Dec 18, 2013 at 5:34 PM, Hanish Bansal < hanish.bansal.agar...@gmail.com> wrote: > Hi All, > > We are having kafka cluster of 2 nodes. (using 0.8.0 final release) > Replication Factor:

Data loss in case of request.required.acks set to -1

2013-12-18 Thread Hanish Bansal
Hi All, We are having kafka cluster of 2 nodes. (using 0.8.0 final release) Replication Factor: 2 Number of partitions: 2 I have configured request.required.acks in producer configuration to -1. As mentioned in documentation http://kafka.apache.org/documentation.html#producerconfigs, setting th