Re: Missing Per-Topic BrokerTopicMetrics in v0.8.2.0

2015-01-27 Thread Jun Rao
Jason, Kyle, Added comments to the jira. Let me know if they make sense. The dot convention is a bit tricky to follow since we allow dots in topic and clientId, etc. Also, we probably don't want to use a convention too specific for Graphite since other systems may have other conventions. Thanks,

Re: Missing Per-Topic BrokerTopicMetrics in v0.8.2.0

2015-01-27 Thread Joel Koshy
Hi Jason - can you describe how you verify that the metrics are not coming through to the metrics registry? Looking at the metrics code it seems that the mbeans are only registered by the yammer jmx reporter only after being added to the metrics registry. Thanks, Joel On Tue, Jan 27, 2015 at

Re: Missing Per-Topic BrokerTopicMetrics in v0.8.2.0

2015-01-27 Thread Jason Rosenberg
Ok, It looks like the yammer MetricName is not being created correctly for the sub metrics that include a topic. E.g. a metric with an mbeanName like: kafka.server:type=BrokerTopicMetrics,name=BytesRejectedPerSec,topic=mytopic appears to be malformed. A yammer MetricName has 4 fields that are

Re: Missing Per-Topic BrokerTopicMetrics in v0.8.2.0

2015-01-27 Thread Joel Koshy
Is it actually getting double-counted? I tried reproducing this locally but the BrokerTopicMetrics.Count lines up with the sum of the PerTopic.Counts for various metrics. On Tue, Jan 27, 2015 at 03:29:37AM -0500, Jason Rosenberg wrote: Ok, It looks like the yammer MetricName is not being

Re: Missing Per-Topic BrokerTopicMetrics in v0.8.2.0

2015-01-27 Thread Jason Rosenberg
Remember multiple people have reported this issue. Per topic metrics no longer appear in graphite (or in any system modeled after the yammer GraphiteReporter). They are not being seen as unique. While these metrics are registered in the registry as separate ‘MetricName’ instances (varying only by

Re: Missing Per-Topic BrokerTopicMetrics in v0.8.2.0

2015-01-27 Thread Manikumar Reddy
I have enabled yammer's ConsoleReporter and I am getting all the metrics (including per-topic metrics). Yammer's MetricName object implements equals/hashcode methods using mBeanName . We are constructing a unique mBeanName for each metric, So we are not missing/overwriting any metrics. Current

Re: Missing Per-Topic BrokerTopicMetrics in v0.8.2.0

2015-01-27 Thread Jun Rao
Jason, So, this sounds like a real issue. Perhaps we can fix it just by setting the tag name as the scope. For example, for mbean kafka.server:type= BrokerTopicMetrics,name=BytesInPerSec,topic=test, we can have group: kafka.server type: BrokerTopicMetrics name: BytesInPerSec scope: topic=test

Re: Missing Per-Topic BrokerTopicMetrics in v0.8.2.0

2015-01-27 Thread Kyle Banker
Thanks for the quick response, Jun (and many thanks to Jason for confirming and further investigating the issue). I've tested the patch, and it does fix the fundamental issue, but I do have a few comments that I'll leave on the ticket. On Tue, Jan 27, 2015 at 9:19 AM, Jun Rao j...@confluent.io

Re: Missing Per-Topic BrokerTopicMetrics in v0.8.2.0

2015-01-27 Thread Jason Rosenberg
I added a comment to the ticket. I think it will work getting data disambiguated (didn't actually test end to end to graphite). However, the naming scheme is not ideal for how metric ui's typically would present the metric tree (e.g. jmx tag syntax doesn't really translate). Jason On Tue, Jan

Re: Missing Per-Topic BrokerTopicMetrics in v0.8.2.0

2015-01-27 Thread Jun Rao
Jason, Kyle, I created an 0.8.2 blocker https://issues.apache.org/jira/browse/KAFKA-1902 and attached a patch there. Could you test it out and see if it fixes the issue with the reporter? The patch adds tags as scope in MetricName. Thanks, Jun On Tue, Jan 27, 2015 at 7:39 AM, Jun Rao

Re: Missing Per-Topic BrokerTopicMetrics in v0.8.2.0

2015-01-26 Thread Manikumar Reddy
If you are using multi-node cluster, then metrics may be reported from other servers. pl check all the servers in the cluster. On Tue, Jan 27, 2015 at 4:12 AM, Kyle Banker kyleban...@gmail.com wrote: I've been using a custom KafkaMetricsReporter to report Kafka broker metrics to Graphite. In

Re: Missing Per-Topic BrokerTopicMetrics in v0.8.2.0

2015-01-26 Thread Jason Rosenberg
I can confirm that the per topic metrics are not coming through to the yammer metrics registry. I do see them in jmx (via jconsole), but the MetricsRegistry does not have them. All the other metrics are coming through that appear in jmx. This is with single node instance running locally. Jason

Re: Missing Per-Topic BrokerTopicMetrics in v0.8.2.0

2015-01-26 Thread Jun Rao
The jmx beans created by Yammer have been changed to the new names. However, the global mbeans have different names from the topic level mbeans. The new mbeans have completely different names from the old ones since they no longer have quotes. Does that answer your question? Thanks, Jun On Mon,

Re: Missing Per-Topic BrokerTopicMetrics in v0.8.2.0

2015-01-26 Thread Jun Rao
Yes, we refactored the mbean names in 0.8.2.0 to make them more standard. Those metrics are now registered under the following names. I did some quick test and the values do get updated. kafka.server:type=BrokerTopicMetrics,name=BytesInPerSec

Missing Per-Topic BrokerTopicMetrics in v0.8.2.0

2015-01-26 Thread Kyle Banker
I've been using a custom KafkaMetricsReporter to report Kafka broker metrics to Graphite. In v0.8.1.1, Kafka was reporting bytes and messages in and out for all topics together and for each individual topic. After upgrading to v0.8.2.0, these metrics are no longer being reported. I'm only seeing

Re: Missing Per-Topic BrokerTopicMetrics in v0.8.2.0

2015-01-26 Thread Kyle Banker
Thanks, Jun. I'm pretty sure, though not 100% confident, that this has caused a change in the way that these metrics are reported to Yammer metrics (I believe that they are stomping on each other). Is that intended as well? On Mon, Jan 26, 2015 at 4:13 PM, Jun Rao j...@confluent.io wrote: Yes,