Re: [OMPI users] my_sense in ompi_osc_sm_module_t not always protected by OPAL_HAVE_POSIX_THREADS

The #if OPAL_HAVE_POSIX_THREADS is still there around my_sense in osc_sm.h in 1.10.1 On 06/29/2015 05:42 PM, Åke Sandgren wrote: Yeah, i thought so. Well code reductions are good when correct :-) On 06/29/2015 05:39 PM, Nathan Hjelm wrote: Open MPI has required posix threads for some time.

Re: [OMPI users] my_sense in ompi_osc_sm_module_t not always protected by OPAL_HAVE_POSIX_THREADS

I would remove it since it has no effect in 1.10. -Nathan On Tue, Jun 30, 2015 at 07:16:09AM +0900, Gilles Gouaillardet wrote: >Nathan, >Shall I remove the --with-threads configure option ? >or make it dummy ? >Cheers, >Gilles > >On Tuesday, June 30, 2015, Nathan Hjelm

Re: [OMPI users] my_sense in ompi_osc_sm_module_t not always protected by OPAL_HAVE_POSIX_THREADS

Nathan, Shall I remove the --with-threads configure option ? or make it dummy ? Cheers, Gilles On Tuesday, June 30, 2015, Nathan Hjelm wrote: > > Ah, that would explain why I am not seeing it in master. Can you PR the > changes to v1.10? > > -Nathan > > On Tue, Jun 30, 2015

Re: [OMPI users] my_sense in ompi_osc_sm_module_t not always protected by OPAL_HAVE_POSIX_THREADS

Ah, that would explain why I am not seeing it in master. Can you PR the changes to v1.10? -Nathan On Tue, Jun 30, 2015 at 07:06:15AM +0900, Gilles Gouaillardet wrote: >Nathan, >I removed all of this (including the --with-threads configure option) on >master a while ago. >because

Re: [OMPI users] my_sense in ompi_osc_sm_module_t not always protected by OPAL_HAVE_POSIX_THREADS

Nathan, I removed all of this (including the --with-threads configure option) on master a while ago. because this is a change in the configure command line, I never made a PR for v1.8 Cheers, Gilles On Tuesday, June 30, 2015, Nathan Hjelm wrote: > > Open MPI has required

Re: [OMPI users] my_sense in ompi_osc_sm_module_t not always protected by OPAL_HAVE_POSIX_THREADS

Yeah, i thought so. Well code reductions are good when correct :-) On 06/29/2015 05:39 PM, Nathan Hjelm wrote: Open MPI has required posix threads for some time. The check for OPAL_HAVE_POSIX_THREADS in ompi/mca/osc/sm/osc_sm.h is stale and should be removed. I will clean that out in master,

Re: [OMPI users] my_sense in ompi_osc_sm_module_t not always protected by OPAL_HAVE_POSIX_THREADS

Open MPI has required posix threads for some time. The check for OPAL_HAVE_POSIX_THREADS in ompi/mca/osc/sm/osc_sm.h is stale and should be removed. I will clean that out in master, 1.8, and 1.10. -Nathan On Mon, Jun 29, 2015 at 05:26:30PM +0200, Åke Sandgren wrote: > Hi! > > The my_sense

[OMPI users] my_sense in ompi_osc_sm_module_t not always protected by OPAL_HAVE_POSIX_THREADS

Hi! The my_sense entity in struct ompi_osc_sm_module_t is protected by OPAL_HAVE_POSIX_THREADS in the definition (ompi/mca/osc/sm/osc_sm.h) But in ./ompi/mca/osc/sm/osc_sm_active_target.c it is not. (Tripped on this due to a compiler problem which caused it to only partially detect threads