Re: [OMPI users] my_sense in ompi_osc_sm_module_t not always protected by OPAL_HAVE_POSIX_THREADS

2015-12-07 Thread Åke Sandgren 
The #if OPAL_HAVE_POSIX_THREADS is still there around my_sense in 
osc_sm.h in 1.10.1


On 06/29/2015 05:42 PM, Åke Sandgren wrote:

Yeah, i thought so. Well code reductions are good when correct :-)

On 06/29/2015 05:39 PM, Nathan Hjelm wrote:


Open MPI has required posix threads for some time. The check for
OPAL_HAVE_POSIX_THREADS in ompi/mca/osc/sm/osc_sm.h is stale and should
be removed. I will clean that out in master, 1.8, and 1.10.



--
Ake Sandgren, HPC2N, Umea University, S-90187 Umea, Sweden
Internet: a...@hpc2n.umu.se   Phone: +46 90 7866134 Fax: +46 90-580 14
Mobile: +46 70 7716134 WWW: http://www.hpc2n.umu.se

Re: [OMPI users] my_sense in ompi_osc_sm_module_t not always protected by OPAL_HAVE_POSIX_THREADS

2015-06-29 Thread Nathan Hjelm 

I would remove it since it has no effect in 1.10.

-Nathan

On Tue, Jun 30, 2015 at 07:16:09AM +0900, Gilles Gouaillardet wrote:
>Nathan,
>Shall I remove the --with-threads configure option ?
>or make it dummy ?
>Cheers,
>Gilles
> 
>On Tuesday, June 30, 2015, Nathan Hjelm  wrote:
> 
>  Ah, that would explain why I am not seeing it in master. Can you PR the
>  changes to v1.10?
> 
>  -Nathan
> 
>  On Tue, Jun 30, 2015 at 07:06:15AM +0900, Gilles Gouaillardet wrote:
>  >Nathan,
>  >I removed all of this (including the --with-threads configure
>  option) on
>  >master a while ago.
>  >because this is a change in the configure command line, I never
>  made a PR
>  >for v1.8
>  >Cheers,
>  >Gilles
>  >
>  >On Tuesday, June 30, 2015, Nathan Hjelm  wrote:
>  >
>  >  Open MPI has required posix threads for some time. The check for
>  >  OPAL_HAVE_POSIX_THREADS in ompi/mca/osc/sm/osc_sm.h is stale and
>  should
>  >  be removed. I will clean that out in master, 1.8, and 1.10.
>  >
>  >  -Nathan
>  >
>  >  On Mon, Jun 29, 2015 at 05:26:30PM +0200, AAke Sandgren wrote:
>  >  > Hi!
>  >  >
>  >  > The my_sense entity in struct ompi_osc_sm_module_t is protected
>  by
>  >  > OPAL_HAVE_POSIX_THREADS in the definition
>  (ompi/mca/osc/sm/osc_sm.h)
>  >  >
>  >  > But in ./ompi/mca/osc/sm/osc_sm_active_target.c it is not.
>  >  >
>  >  > (Tripped on this due to a compiler problem which caused it to
>  only
>  >  partially
>  >  > detect threads support, found for C++, missing for C/Fortran)
>  >  >
>  >  > Not sure if it is something that need to be dealt with but
>  reporting
>  >  anyway.
>  >  >
>  >  > --
>  >  > Ake Sandgren, HPC2N, Umea University, S-90187 Umea, Sweden
>  >  > Internet: a...@hpc2n.umu.se   Phone: +46 90 7866134 Fax: +46
>  90-580 14
>  >  > Mobile: +46 70 7716134 WWW: http://www.hpc2n.umu.se
>  >  > ___
>  >  > users mailing list
>  >  > us...@open-mpi.org
>  >  > Subscription:
>  http://www.open-mpi.org/mailman/listinfo.cgi/users
>  >  > Link to this post:
>  >  http://www.open-mpi.org/community/lists/users/2015/06/27211.php
> 
>  > ___
>  > users mailing list
>  > us...@open-mpi.org
>  > Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/users
>  > Link to this post:
>  http://www.open-mpi.org/community/lists/users/2015/06/27223.php

> ___
> users mailing list
> us...@open-mpi.org
> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/users
> Link to this post: 
> http://www.open-mpi.org/community/lists/users/2015/06/27225.php



pgpRWxaT2GVP1.pgp
Description: PGP signature

Re: [OMPI users] my_sense in ompi_osc_sm_module_t not always protected by OPAL_HAVE_POSIX_THREADS

2015-06-29 Thread Gilles Gouaillardet 
Nathan,

Shall I remove the --with-threads configure option ?
or make it dummy ?

Cheers,

Gilles

On Tuesday, June 30, 2015, Nathan Hjelm  wrote:

>
> Ah, that would explain why I am not seeing it in master. Can you PR the
> changes to v1.10?
>
> -Nathan
>
> On Tue, Jun 30, 2015 at 07:06:15AM +0900, Gilles Gouaillardet wrote:
> >Nathan,
> >I removed all of this (including the --with-threads configure option)
> on
> >master a while ago.
> >because this is a change in the configure command line, I never made
> a PR
> >for v1.8
> >Cheers,
> >Gilles
> >
> >On Tuesday, June 30, 2015, Nathan Hjelm  > wrote:
> >
> >  Open MPI has required posix threads for some time. The check for
> >  OPAL_HAVE_POSIX_THREADS in ompi/mca/osc/sm/osc_sm.h is stale and
> should
> >  be removed. I will clean that out in master, 1.8, and 1.10.
> >
> >  -Nathan
> >
> >  On Mon, Jun 29, 2015 at 05:26:30PM +0200, AAke Sandgren wrote:
> >  > Hi!
> >  >
> >  > The my_sense entity in struct ompi_osc_sm_module_t is protected by
> >  > OPAL_HAVE_POSIX_THREADS in the definition
> (ompi/mca/osc/sm/osc_sm.h)
> >  >
> >  > But in ./ompi/mca/osc/sm/osc_sm_active_target.c it is not.
> >  >
> >  > (Tripped on this due to a compiler problem which caused it to only
> >  partially
> >  > detect threads support, found for C++, missing for C/Fortran)
> >  >
> >  > Not sure if it is something that need to be dealt with but
> reporting
> >  anyway.
> >  >
> >  > --
> >  > Ake Sandgren, HPC2N, Umea University, S-90187 Umea, Sweden
> >  > Internet: a...@hpc2n.umu.se    Phone: +46 90
> 7866134 Fax: +46 90-580 14
> >  > Mobile: +46 70 7716134 WWW: http://www.hpc2n.umu.se
> >  > ___
> >  > users mailing list
> >  > us...@open-mpi.org 
> >  > Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/users
> >  > Link to this post:
> >  http://www.open-mpi.org/community/lists/users/2015/06/27211.php
>
> > ___
> > users mailing list
> > us...@open-mpi.org 
> > Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/users
> > Link to this post:
> http://www.open-mpi.org/community/lists/users/2015/06/27223.php
>
>

Re: [OMPI users] my_sense in ompi_osc_sm_module_t not always protected by OPAL_HAVE_POSIX_THREADS

2015-06-29 Thread Nathan Hjelm 

Ah, that would explain why I am not seeing it in master. Can you PR the
changes to v1.10?

-Nathan

On Tue, Jun 30, 2015 at 07:06:15AM +0900, Gilles Gouaillardet wrote:
>Nathan,
>I removed all of this (including the --with-threads configure option) on
>master a while ago.
>because this is a change in the configure command line, I never made a PR
>for v1.8
>Cheers,
>Gilles
> 
>On Tuesday, June 30, 2015, Nathan Hjelm  wrote:
> 
>  Open MPI has required posix threads for some time. The check for
>  OPAL_HAVE_POSIX_THREADS in ompi/mca/osc/sm/osc_sm.h is stale and should
>  be removed. I will clean that out in master, 1.8, and 1.10.
> 
>  -Nathan
> 
>  On Mon, Jun 29, 2015 at 05:26:30PM +0200, AAke Sandgren wrote:
>  > Hi!
>  >
>  > The my_sense entity in struct ompi_osc_sm_module_t is protected by
>  > OPAL_HAVE_POSIX_THREADS in the definition (ompi/mca/osc/sm/osc_sm.h)
>  >
>  > But in ./ompi/mca/osc/sm/osc_sm_active_target.c it is not.
>  >
>  > (Tripped on this due to a compiler problem which caused it to only
>  partially
>  > detect threads support, found for C++, missing for C/Fortran)
>  >
>  > Not sure if it is something that need to be dealt with but reporting
>  anyway.
>  >
>  > --
>  > Ake Sandgren, HPC2N, Umea University, S-90187 Umea, Sweden
>  > Internet: a...@hpc2n.umu.se   Phone: +46 90 7866134 Fax: +46 90-580 14
>  > Mobile: +46 70 7716134 WWW: http://www.hpc2n.umu.se
>  > ___
>  > users mailing list
>  > us...@open-mpi.org
>  > Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/users
>  > Link to this post:
>  http://www.open-mpi.org/community/lists/users/2015/06/27211.php

> ___
> users mailing list
> us...@open-mpi.org
> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/users
> Link to this post: 
> http://www.open-mpi.org/community/lists/users/2015/06/27223.php



pgpA2RQ397GWR.pgp
Description: PGP signature

Re: [OMPI users] my_sense in ompi_osc_sm_module_t not always protected by OPAL_HAVE_POSIX_THREADS

2015-06-29 Thread Gilles Gouaillardet 
Nathan,

I removed all of this (including the --with-threads configure option) on
master a while ago.
because this is a change in the configure command line, I never made a PR
for v1.8

Cheers,

Gilles

On Tuesday, June 30, 2015, Nathan Hjelm  wrote:

>
> Open MPI has required posix threads for some time. The check for
> OPAL_HAVE_POSIX_THREADS in ompi/mca/osc/sm/osc_sm.h is stale and should
> be removed. I will clean that out in master, 1.8, and 1.10.
>
> -Nathan
>
> On Mon, Jun 29, 2015 at 05:26:30PM +0200, Åke Sandgren wrote:
> > Hi!
> >
> > The my_sense entity in struct ompi_osc_sm_module_t is protected by
> > OPAL_HAVE_POSIX_THREADS in the definition (ompi/mca/osc/sm/osc_sm.h)
> >
> > But in ./ompi/mca/osc/sm/osc_sm_active_target.c it is not.
> >
> > (Tripped on this due to a compiler problem which caused it to only
> partially
> > detect threads support, found for C++, missing for C/Fortran)
> >
> > Not sure if it is something that need to be dealt with but reporting
> anyway.
> >
> > --
> > Ake Sandgren, HPC2N, Umea University, S-90187 Umea, Sweden
> > Internet: a...@hpc2n.umu.se    Phone: +46 90 7866134 Fax:
> +46 90-580 14
> > Mobile: +46 70 7716134 WWW: http://www.hpc2n.umu.se
> > ___
> > users mailing list
> > us...@open-mpi.org 
> > Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/users
> > Link to this post:
> http://www.open-mpi.org/community/lists/users/2015/06/27211.php
>

Re: [OMPI users] my_sense in ompi_osc_sm_module_t not always protected by OPAL_HAVE_POSIX_THREADS

2015-06-29 Thread Åke Sandgren 

Yeah, i thought so. Well code reductions are good when correct :-)

On 06/29/2015 05:39 PM, Nathan Hjelm wrote:


Open MPI has required posix threads for some time. The check for
OPAL_HAVE_POSIX_THREADS in ompi/mca/osc/sm/osc_sm.h is stale and should
be removed. I will clean that out in master, 1.8, and 1.10.

-Nathan

On Mon, Jun 29, 2015 at 05:26:30PM +0200, Åke Sandgren wrote:

Hi!

The my_sense entity in struct ompi_osc_sm_module_t is protected by
OPAL_HAVE_POSIX_THREADS in the definition (ompi/mca/osc/sm/osc_sm.h)

But in ./ompi/mca/osc/sm/osc_sm_active_target.c it is not.

(Tripped on this due to a compiler problem which caused it to only partially
detect threads support, found for C++, missing for C/Fortran)

Not sure if it is something that need to be dealt with but reporting anyway.


--
Ake Sandgren, HPC2N, Umea University, S-90187 Umea, Sweden
Internet: a...@hpc2n.umu.se   Phone: +46 90 7866134 Fax: +46 90-580 14
Mobile: +46 70 7716134 WWW: http://www.hpc2n.umu.se

Re: [OMPI users] my_sense in ompi_osc_sm_module_t not always protected by OPAL_HAVE_POSIX_THREADS

2015-06-29 Thread Nathan Hjelm 

Open MPI has required posix threads for some time. The check for
OPAL_HAVE_POSIX_THREADS in ompi/mca/osc/sm/osc_sm.h is stale and should
be removed. I will clean that out in master, 1.8, and 1.10.

-Nathan

On Mon, Jun 29, 2015 at 05:26:30PM +0200, Åke Sandgren wrote:
> Hi!
> 
> The my_sense entity in struct ompi_osc_sm_module_t is protected by
> OPAL_HAVE_POSIX_THREADS in the definition (ompi/mca/osc/sm/osc_sm.h)
> 
> But in ./ompi/mca/osc/sm/osc_sm_active_target.c it is not.
> 
> (Tripped on this due to a compiler problem which caused it to only partially
> detect threads support, found for C++, missing for C/Fortran)
> 
> Not sure if it is something that need to be dealt with but reporting anyway.
> 
> -- 
> Ake Sandgren, HPC2N, Umea University, S-90187 Umea, Sweden
> Internet: a...@hpc2n.umu.se   Phone: +46 90 7866134 Fax: +46 90-580 14
> Mobile: +46 70 7716134 WWW: http://www.hpc2n.umu.se
> ___
> users mailing list
> us...@open-mpi.org
> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/users
> Link to this post: 
> http://www.open-mpi.org/community/lists/users/2015/06/27211.php


pgpVG8VolJqWW.pgp
Description: PGP signature

[OMPI users] my_sense in ompi_osc_sm_module_t not always protected by OPAL_HAVE_POSIX_THREADS

2015-06-29 Thread Åke Sandgren 

Hi!

The my_sense entity in struct ompi_osc_sm_module_t is protected by 
OPAL_HAVE_POSIX_THREADS in the definition (ompi/mca/osc/sm/osc_sm.h)


But in ./ompi/mca/osc/sm/osc_sm_active_target.c it is not.

(Tripped on this due to a compiler problem which caused it to only 
partially detect threads support, found for C++, missing for C/Fortran)


Not sure if it is something that need to be dealt with but reporting anyway.

--
Ake Sandgren, HPC2N, Umea University, S-90187 Umea, Sweden
Internet: a...@hpc2n.umu.se   Phone: +46 90 7866134 Fax: +46 90-580 14
Mobile: +46 70 7716134 WWW: http://www.hpc2n.umu.se