Re: Building and unit-testing MR Jars, easily

2018-04-13 Thread Martin Gainty
MG3>agreed please see below From: Russell Gold Sent: Friday, April 13, 2018 9:07 AM To: Maven Users List Subject: Re: Building and unit-testing MR Jars, easily > On Apr 13, 2018, at 8:34 AM, Martin Gainty wrote: >

Re: maven-compiler-plugin JPMS module resolution

2018-04-13 Thread Robert Scholte
Here you hit the nail on the head! This is exactly my concern and I've spoken about this on several conferences. TLDR: Don't publish libraries to Maven Central that depend on at least one filename-based automatic module. You must wait until all your dependencies are explicit modules. In

AW: Writing own plugin: The parameter annotation - does it work?

2018-04-13 Thread g.hohl
Hello everyone, after some analyzing I realized that the MojoRule is trying to read the plug-in description. This file is created during the build process by the maven-plugin-plugin and is located: target\classes\META-INF\maven\plugin.xml If I only execute the test via JUnit in Eclipse that

Re: Building and unit-testing MR Jars, easily

2018-04-13 Thread Russell Gold
> On Apr 13, 2018, at 8:34 AM, Martin Gainty wrote: > > MG2>quick comment below > > MG2>from your website: > MG2> > "JEP-238 >. A problem, though, is that more than two > years after this feature was

Writing own plugin: The parameter annotation - does it work?

2018-04-13 Thread g.hohl
Hello everyone, :-) I'm currently writing a Maven plug-in again. And I'm experiencing some add odd behavior. Maybe I should add first that I'm currently executing my Mojo using the MojoRule within a JUnit test. The parameters of my Mojo are annotated using the @Parameter annotation of Maven.

Re: Building and unit-testing MR Jars, easily

2018-04-13 Thread Martin Gainty
MG2>quick comment below From: Russell Gold Sent: Thursday, April 12, 2018 2:43 PM To: Maven Users List Subject: Re: Building and unit-testing MR Jars, easily > On Apr 12, 2018, at 1:58 PM, Martin Gainty wrote: >

Re: maven-compiler-plugin JPMS module resolution

2018-04-13 Thread Roman Grigoriadi
I guess you are right. I wasn't sure if it is a good idea to include a name for a module in my descriptor for a dependency which is actually not named (automatic) and release with such descriptor. But given this dependency is fixed version, it will not get any other name than I am referencing and

Re: maven-compiler-plugin JPMS module resolution

2018-04-13 Thread Robert Scholte
But that means that the dependency is actually required at runtime. Looks to me there are 2 options: - make that dependency a requirement - restructure your code so it can be a static requirement One of the benefits I do like about the modularization is that it forces you to do clean coding.