Re: Run all tests (also in dependent modules), fail build at end

2022-02-14 Thread Alexander Kriegisch
Hi Tibor. I waited for a week in order to see other developers want to contribute to the general discussion you asked to have before making any design decisions the Surefire team might regret later. Did you get the input your were looking for from somewhere off-list, or have you had enough time

Re: Possible file separator bug in 3.10.0 using bnd-maven-plugin

2022-02-14 Thread Daniel B. Widdis
OK, so I didn't reach the end of my investigation. I did just look at the Java specifications for the class file format [1]. They specify the internal representation of packages always replace periods with forward slashes (for historical reasons). So the binary class file generated by the

Re: Possible file separator bug in 3.10.0 using bnd-maven-plugin

2022-02-14 Thread Daniel B. Widdis
I believe I've traced the problem to the binary inside the generated package-info.class files. The path stored internally there uses the backslash, while all other class files have forward slashes on Windows. That appears to be written by the Classwriter (lines 1352-1358). Debug lines show the

Re: Possible file separator bug in 3.10.0 using bnd-maven-plugin

2022-02-14 Thread Daniel B. Widdis
I've confirmed this PR is the relevant problem as the symptoms can be suppressed by using mvn clean test "-Dmaven.compiler.createMissingPackageInfoClass=false" On Mon, Feb 14, 2022 at 9:50 AM Greg Chabala wrote: > Just my opinion, https://github.com/apache/maven-compiler-plugin/pull/88 >

Re: Possible file separator bug in 3.10.0 using bnd-maven-plugin

2022-02-14 Thread Greg Chabala
Just my opinion, https://github.com/apache/maven-compiler-plugin/pull/88 feels like a hack solution. Generating classes for package-info.java files, just to appease some issue with the incremental compiler? That seems like it should have been filtered in the compile plugin, not litter the build

Possible file separator bug in 3.10.0 using bnd-maven-plugin

2022-02-14 Thread Daniel B. Widdis
I just bumped the maven-compiler-plugin version on my project from 3.9.0 to 3.10.0 and it caused Windows-based builds to fail maven-bnd-plugin tests for package-info files in the "wrong" directory. The symptom looks to be associated with the windows file separator. Sample failure looks like:

[ANN] Apache Maven Compiler Plugin 3.10.0 Released

2022-02-14 Thread Olivier Lamy
Hi The Apache Maven team is pleased to announce the release of the Apache Maven Compiler Plugin, version 3.10.0 The Compiler Plugin is used to compile the sources of your project. https://maven.apache.org/plugins/maven-compiler-plugin/ You should specify the version in your project's plugin