Re: How to set default directories when developing a reporting plugin?

2023-10-24 Thread Michael Osipov
On 2023/10/22 02:38:07 Alexander Kriegisch wrote: > Hello Michael, hello community. > > I have decided to actually change the plugin's behaviour the way I > described: > > -- I overrode the default value of AbstractMavenReport.outputDirectory > [1] by defining a setter method and adding a

Re: How to set default directories when developing a reporting plugin?

2023-10-22 Thread Alexander Kriegisch
Michael, first of all thanks for your conceptual thoughts and efforts to improve both code and documentation. > Let me know what you think! I fully agree that the notion that both the output directory and the report output directory are meant to be *base* directories. I disagree, however, with

RE: How to set default directories when developing a reporting plugin?

2023-10-22 Thread Michael Osipov
Alexander, I have now read the code of all our reporting plugins, maven-reporting-impl and maven-site-plugin. Here is my understanding how I expect to work which it is not at the moment and there is a flaw in the system were both MJXR and MJAVADOC apply a hack and I will explain why they

Re: How to set default directories when developing a reporting plugin?

2023-10-21 Thread Alexander Kriegisch
Hello Michael, hello community. I have decided to actually change the plugin's behaviour the way I described: -- I overrode the default value of AbstractMavenReport.outputDirectory [1] by defining a setter method and adding a @Parameter annotation, specifying

RE: How to set default directories when developing a reporting plugin?

2023-10-21 Thread Michael Osipov
On 2023/10/20 02:08:25 Alexander Kriegisch wrote: Hello. I am trying to improve a reporting mojo in a Maven plugin. The mojo extends org.apache.maven.reporting.AbstractMavenReport. I recently upgraded it to Doxia 2.0 - thanks again to Hervé B. and Michael O. for their support - and cleaned

Re: How to set default directories when developing a reporting plugin?

2023-10-19 Thread Alexander Kriegisch
One more thing: In class AbstractMavenReport, field 'reportOutputDirectory' is private (not protected), i.e. it cannot be updated independently by extending mojos. Using the setter method also updates 'outputDirectory' simultaneously. The latter is a protected field, BTW. Of course, the setter

How to set default directories when developing a reporting plugin?

2023-10-19 Thread Alexander Kriegisch
Hello. I am trying to improve a reporting mojo in a Maven plugin. The mojo extends org.apache.maven.reporting.AbstractMavenReport. I recently upgraded it to Doxia 2.0 - thanks again to Hervé B. and Michael O. for their support - and cleaned out some cruft, removing redundant super class fields