Re: Maven Plugin and JSR330

2016-11-20 Thread Stuart McCulloch
Thanks, looks good to me On Sunday, 20 November 2016 at 17:46, Dan Tran wrote: > I filed a PR at https://github.com/apache/maven/pull/98. > > On Thu, Nov 17, 2016 at 8:48 PM, Dan Tran (mailto:dant...@gmail.com)> wrote: > > It works!!! Thanks Stuard > > > > So my change

Re: Maven Plugin and JSR330

2016-11-20 Thread Dan Tran
I filed a PR at https://github.com/apache/maven/pull/98. On Thu, Nov 17, 2016 at 8:48 PM, Dan Tran wrote: > It works!!! Thanks Stuard > > So my change should be good for commit for 3.4? > > -Dan > > On Sun, Nov 13, 2016 at 3:01 PM, Stuart McCulloch >

Re: Maven Plugin and JSR330

2016-11-17 Thread Dan Tran
It works!!! Thanks Stuard So my change should be good for commit for 3.4? -Dan On Sun, Nov 13, 2016 at 3:01 PM, Stuart McCulloch wrote: > Hi Dan, > > There are two places in MavenCli which create a container. > > You’ve enabled JSR250 for the temporary container that

Re: Maven Plugin and JSR330

2016-11-13 Thread Stuart McCulloch
Hi Dan, There are two places in MavenCli which create a container. You’ve enabled JSR250 for the temporary container that resolves the core extensions, but not the main container that runs the Mojos:

Re: Maven Plugin and JSR330

2016-11-13 Thread Dan Tran
@Stuard Could you review my changes at https://github.com/dantran/maven/commits/master? I still not able to get @PostContruct working yet Thanks -Dan On Sun, Sep 11, 2016 at 7:27 PM, Dan Tran wrote: > Thanks Stuart, very much appreciated > > -D > > On Sun, Sep 11, 2016 at

Re: Maven Plugin and JSR330

2016-09-11 Thread Dan Tran
Thanks Stuart, very much appreciated -D On Sun, Sep 11, 2016 at 7:22 PM, Stuart McCulloch wrote: > Sorry, last week was very busy with work and family > > I’ve listed the necessary config changes in https://issues.apache.org/ > jira/browse/MNG-6084 > > -- > Cheers, Stuart >

Re: Maven Plugin and JSR330

2016-09-11 Thread Stuart McCulloch
Sorry, last week was very busy with work and family I’ve listed the necessary config changes in https://issues.apache.org/jira/browse/MNG-6084 -- Cheers, Stuart On Sunday, 11 September 2016 at 04:28, Dan Tran wrote: > @Stuart, ping :-) > > On Tue, Sep 6, 2016 at 7:06 PM, Dan Tran

Re: Maven Plugin and JSR330

2016-09-10 Thread Dan Tran
@Stuart, ping :-) On Tue, Sep 6, 2016 at 7:06 PM, Dan Tran wrote: > @Stuart, could you provide instructions on how to enable JSR 250 support? > > Thanks > > > -Dan > > On Fri, Sep 2, 2016 at 9:22 AM, Dan Tran wrote: > >> here you go

Re: Maven Plugin and JSR330

2016-09-06 Thread Dan Tran
@Stuart, could you provide instructions on how to enable JSR 250 support? Thanks -Dan On Fri, Sep 2, 2016 at 9:22 AM, Dan Tran wrote: > here you go https://issues.apache.org/jira/browse/MNG-6084 > > Very much appreciated > > -Dan > > On Fri, Sep 2, 2016 at 8:42 AM, Stuart

Re: Maven Plugin and JSR330

2016-09-02 Thread Dan Tran
here you go https://issues.apache.org/jira/browse/MNG-6084 Very much appreciated -Dan On Fri, Sep 2, 2016 at 8:42 AM, Stuart McCulloch wrote: > On Wednesday, 31 August 2016 at 19:05, Dan Tran wrote: > > Hi Stuart > > > > Thanks for helping out. > > > > I have 3 mojos,

Re: Maven Plugin and JSR330

2016-09-02 Thread Stuart McCulloch
On Wednesday, 31 August 2016 at 19:05, Dan Tran wrote: > Hi Stuart > > Thanks for helping out. > > I have 3 mojos, sharing one singleton component which depends on another > singleton component thru injection. All working now via both injection type > ( after some cleanup) > > should I file

Re: Maven Plugin and JSR330

2016-08-31 Thread Dan Tran
Hi Stuart Thanks for helping out. I have 3 mojos, sharing one singleton component which depends on another singleton component thru injection. All working now via both injection type ( after some cleanup) should I file a JIRA to enable JSR-250 support fo rmaven 3.4? looking forward to use it

Re: Maven Plugin and JSR330

2016-08-31 Thread Stuart McCulloch
Hi Dan, Constructor injection (and component injection) is working for me with Maven 3.3.9 if I follow the example in http://maven.apache.org/maven-jsr330.html Is your plugin code available somewhere? PS. at the moment Maven doesn’t enable container support for JSR-250 lifecycle, but it

Re: Maven Plugin and JSR330

2016-08-31 Thread Dan Tran
Hi Thomas, You are right!!! looking for how to fix this... The only thing working for me is field injection at MOJO. event The constructor injection ( as documented) at MOJO is not. Thanks -Dan On Wed, Aug 31, 2016 at 1:20 AM, Thomas Broyer wrote: > On Wed, Aug 31, 2016

Re: Maven Plugin and JSR330

2016-08-31 Thread Thomas Broyer
On Wed, Aug 31, 2016 at 8:43 AM Dan Tran wrote: > Hi > > I have a need to inject my jsr330 component into my plugins[1] and I > found 2 issues > > 1. @Inject under MOJO works, but my singleton component @PreDestroy never > got called > @PreDestroy is not part of JSR 330,

Maven Plugin and JSR330

2016-08-31 Thread Dan Tran
Hi I have a need to inject my jsr330 component into my plugins[1] and I found 2 issues 1. @Inject under MOJO works, but my singleton component @PreDestroy never got called 2. @Inject at my component does not work. I wonder if anyone able to get JSR330 fully working for your maven plugin