Re: Surefire leaking ClassMethod

2023-07-13 Thread Clebert Suconic
just for the record I just opened a dev thread about this. On Wed, Jul 12, 2023 at 9:31 AM Clebert Suconic wrote: > > Also.. is there a MavenLauncher on surefire-its or anywhere else that > will run multiple tests? > > On Wed, Jul 12, 2023 at 9:28 AM Clebert Suconic > wrote: > > > > it seems

Re: Surefire leaking ClassMethod

2023-07-12 Thread Clebert Suconic
Also.. is there a MavenLauncher on surefire-its or anywhere else that will run multiple tests? On Wed, Jul 12, 2023 at 9:28 AM Clebert Suconic wrote: > > it seems there is surefire-its for integration tests and there are a > couple of resources it will use. > > I think I should create a new

Re: Surefire leaking ClassMethod

2023-07-12 Thread Clebert Suconic
it seems there is surefire-its for integration tests and there are a couple of resources it will use. I think I should create a new module, surefire-leaktests using check-leak to validate for leaks and use the launcher to run a small testsuite and validate the leaks at the end. One challenge I

Re: Surefire leaking ClassMethod

2023-07-11 Thread Tamás Cservenák
Yes, leak test are warmly welcome :) T On Wed, Jul 12, 2023, 01:17 Enrico Olivelli wrote: > Il Mer 12 Lug 2023, 00:15 Clebert Suconic ha > scritto: > > > On Tue, Jul 11, 2023 at 6:13 PM Clebert Suconic > > wrote: > > > > > > How tests are simulated within maven-surefire? is there any

Re: Surefire leaking ClassMethod

2023-07-11 Thread Enrico Olivelli
Il Mer 12 Lug 2023, 00:15 Clebert Suconic ha scritto: > On Tue, Jul 11, 2023 at 6:13 PM Clebert Suconic > wrote: > > > > How tests are simulated within maven-surefire? is there any example? > > I mean... a test testing the test! Something that will call surefire > and its unit tests and

Re: Surefire leaking ClassMethod

2023-07-11 Thread Clebert Suconic
On Tue, Jul 11, 2023 at 6:13 PM Clebert Suconic wrote: > > How tests are simulated within maven-surefire? is there any example? I mean... a test testing the test! Something that will call surefire and its unit tests and validate outcome? > > Would I be able to create an optional module where I

Re: Surefire leaking ClassMethod

2023-07-11 Thread Clebert Suconic
How tests are simulated within maven-surefire? is there any example? Would I be able to create an optional module where I do a test-leak using my library to validate if it leaked or not? On Tue, Jul 11, 2023 at 5:33 PM Clebert Suconic wrote: > > I tried looking at how I would contribute a fix,

Re: Surefire leaking ClassMethod

2023-07-11 Thread Clebert Suconic
I tried looking at how I would contribute a fix, but I lacked an understanding on how tests are performed in surefire. Also: would you accept a test that's using check-leak to prevent future leaks like this? (maybe a separate sub-module for this test?)... and where I would add such test? I would

Re: Surefire leaking ClassMethod

2023-07-11 Thread Enrico Olivelli
Clebert, Il Mar 11 Lug 2023, 15:55 Clebert Suconic ha scritto: > created a JIRA: > > https://issues.apache.org/jira/browse/SUREFIRE-2186 Thanks. Would you have time to contribute a fix? Enrico > > > On Tue, Jul 11, 2023 at 9:33 AM Clebert Suconic > wrote: > > > > You guys need to be

Re: Surefire leaking ClassMethod

2023-07-11 Thread Clebert Suconic
created a JIRA: https://issues.apache.org/jira/browse/SUREFIRE-2186 On Tue, Jul 11, 2023 at 9:33 AM Clebert Suconic wrote: > > You guys need to be careful with non static ThreadLocals. > > > ClassMethodIndexer has a non static ThreadLocal. > > threadLocals will create a hashEntry somewhere deep

Re: Surefire leaking ClassMethod

2023-07-11 Thread Clebert Suconic
You guys need to be careful with non static ThreadLocals. ClassMethodIndexer has a non static ThreadLocal. threadLocals will create a hashEntry somewhere deep in the JDK. Depending on the number of tests that are running you guys may break things like ReadWriteLock because it will transverse a

Surefire leaking ClassMethod

2023-07-10 Thread Clebert Suconic
We have recently upgraded surefire into artemis from 2.x, and strangely our testsuite started to crash because of memory. So, it happens that I had other memory leaks in the past and I became addicted into finding them, up to a point that I created a project that will track memory usage over a