Re: Why does Maven Shade relocate modify unrelated classes?

2021-05-16 Thread Alexander Kriegisch
Jim N schrieb am 16.05.2021 18:27 (GMT +07:00): > im not sure whether the prior response fully bounced, so forgive the > duplication: > > This is the maven users list not the shade issues tracker. expect > helpful suggestions that don't share your viewpoints or goals. Looks like it did, I did

Re: Why does Maven Shade relocate modify unrelated classes?

2021-05-16 Thread Alexander Kriegisch
MSHADE-252 https://github.com/apache/maven-shade-plugin/pull/88 Mentioned multiple times here, too, even very recently again. I am feeling awkward, posting the link again, but I keep getting asked about it, so I am replying. My apologies to everyone else who reads about this PR again. Tibor

Re: Why does Maven Shade relocate modify unrelated classes?

2021-05-16 Thread Jim N
im not sure whether the prior response fully bounced, so forgive the duplication: This is the maven users list not the shade issues tracker. expect helpful suggestions that don't share your viewpoints or goals. I'd suggest you find the shade plugin source code and resist the urge to mix words

Re: Why does Maven Shade relocate modify unrelated classes?

2021-05-16 Thread Tibor Digana
Where is the ticket in Jira? Last time I meant when Romain improved the plugin a lot. Maybe before you created the ticket. T On Sun, May 16, 2021 at 1:01 PM Alexander Kriegisch < alexan...@kriegisch.name> wrote: > Sorry Tibor, I am not sure which "last time" you are talking about. I > think,

Re: Why does Maven Shade relocate modify unrelated classes?

2021-05-16 Thread Alexander Kriegisch
Sorry Tibor, I am not sure which "last time" you are talking about. I think, last time I interacted with anyone concerning Maven Shade on Jira was by commenting on an old, existing ticket, getting zero help and then fixing the problem myself, trying return something to the community by means of an

Re: Why does Maven Shade relocate modify unrelated classes?

2021-05-16 Thread Alexander Kriegisch
I have no idea what you are talking about and how your answer concerning "non-relocating options" is relevant to my question about the opposite. I also did not report any surprises during my deployments or runtime behaviour of relocated classes. Thanks for your feedback anyway. Next time, maybe

Re: Why does Maven Shade relocate modify unrelated classes?

2021-05-16 Thread Tibor Digana
These Apache developers work with Jira based on objective materials attached to Jira, like a reproducible project provided by you on Github or a provided POM. Then they will take care especially regarding the maven-shade-plugin they want to improve this plugin, and there was a big effort given to

Re: Why does Maven Shade relocate modify unrelated classes?

2021-05-16 Thread Jim N
You might want to examine the "horrible" Non relocating options previously outlined if you want a fast resolution to unsurprising deployments. On Sun, May 16, 2021, 10:41 AM Alexander Kriegisch wrote: > When running Maven Shade with relocation, it works nicely. When > comparing JARs before and