Hervé, can you please elaborate for non-committers like me:
(a) Why shall I open another issue that contains essentially the same text as the already-existing and non-fixed-but-marked-as-resolved one http://jira.codehaus.org/browse/MDEP-436 ? The result would be the same: Kristian assumes it is fixed, and again closes it. So what do we gain ? (b) Why adding a new configuration property <encoding> to maven-dependency-plugin's <configuration> would (even hypothetically) break anything ? (c) What you assume how anybody should be able to use maven-dependency-plugin's unpack target on CP850-ZIPs ? Just to make me understand. :-) Thanks -Markus -----Ursprüngliche Nachricht----- Von: Hervé BOUTEMY [mailto:herve.bout...@free.fr] Gesendet: Dienstag, 17. März 2015 08:36 An: Maven Users List Betreff: Re: AW: How to configure maven-dependency-plugin's encoding used for unpack? Le mardi 17 mars 2015 08:19:20 Markus Karg a écrit : > (1) "Normal users" (non-comitters) do not have permission to reopen > issues so I really beg for your kind help to reopen this issue for me! > :-) no, please don't reopen the issue: open another issue > (2) Despite all the quirks of Windows, the ZIP specification does not > say a word about encoding, we had the discussion on dev@ mailing list in october and we based our decision partly on PKWARE's old documentation see http://mail-archives.apache.org/mod_mbox/maven-dev/201410.mbox/%3C1632789.Hzz1ElkyQm%40herve-desktop%3E > so it is pretty correct to use any decoding in ZIPs. > As a consequence, maven-dependency-plugin MUST either be able to > detect the encoding OR MUST have configurable encoding (plexus > unarchiver already provides setEncoding BTW). > I actually do not understand the discussion about this. I have such > ZIPs, these are compliant with the ZIP specification, please provide the Zip specifications you're referring to: having a common reference is the first problem we faced, ie we could not find any shared reference > and maven-dependency-plugin > cannot handle it. So instead of complaining about Windows being quirky > wouldn't it make more sense to simply provide maven-dependency-plugin > the same <encoding> option that maven-assembly-plugin already has? I > mean, that would be straightforward, simple to implement, pragmatic > and would actually help us (we are stuck with this!) while discussions about > Windows do not. > ;-) I suppose there are multiple zip encoders and decoders on every platform: the problem is with some decoders, IIUC, not the whole platform that executes it > Maybe there is a trick so one can configure plexus unarchiver's > setEncoding via the POM, but we simply don't know how to do that. So > if you know that trick, then please share your knowledge with us. We > do not insist on a fix for the plugin, but we really need a solution > ASAP! :-) given the problem on shared zip structure reference, we really fear that fixing the issue for one user will break the other one, using another zip decoder Regards, Hervé > Thanks a lot! > -Markus > > -----Ursprüngliche Nachricht----- > Von: kristian.rosenv...@zenior.no > [mailto:kristian.rosenv...@zenior.no] Im Auftrag von Kristian > Rosenvold Gesendet: Dienstag, 17. März 2015 07:06 > An: Maven Users List > Betreff: Re: How to configure maven-dependency-plugin's encoding used > for unpack? > This is really only a question about the borked "zip file" explorer > that is default in windows. Quality zip clients always works fine on Windows. > The miserable story is documented entirely at > http://commons.apache.org/proper/commons-compress/zip.html#Encoding > and is an enjoyable read for anyone who wants the full story :) > For the assembly plugin I have scheduled > http://jira.codehaus.org/browse/MASSEMBLY-748 for the next release, > which should be soonish. > For the dependency plugin I am still not convinced that this should be > supported. Unlike the ZIP specification, the Jar specification is > crystal clear on "UTF-8" only, which means we'd be breaking something > that is not broken. > Kristian > > > > > > 2015-03-17 6:39 GMT+01:00 Baptiste Mathus <bmat...@batmat.net>: > > > > And this is actually not even always true, CP1252 is also often used > > on Windows (in France for example). > > > > > > > > Encoding is actually a quite "simple" problem, but transfer makes it > > difficult to handle as each move has to take care of what it does. > > As for the JIRA tickets, if you feel this is not OK, feel free to > > comment/reopen/create the ones you want. > > But also beware that without a patch, in that very specific > > situation, it's not very likely someone else will spend time to fix it. > > > > > > > > HTH > > Cheers > > > > > > > > 2015-03-16 15:04 GMT+01:00 Markus Karg <k...@quipsy.de>: > > > > > > > > > Kristian, > > > > > > > > > > > > can you please reopen the item then? I mean, it simply is not > > > fixed, because UTF-8 ZIPs are not a solution: Windows cannot > > > correctly display them, so people on the Windows world will > > > virtually every create > > > > CP850-ZIPs! > > > > > > > > > > > Do you know about any plans to support this, or what is the > > > intended future of this issue? > > > > > > > > > > > > Thanks > > > -Markus > > > > > > > > > > > > -----Ursprüngliche Nachricht----- > > > Von: kristian.rosenv...@zenior.no > > > [mailto:kristian.rosenv...@zenior.no] > > > Im Auftrag von Kristian Rosenvold > > > Gesendet: Montag, 16. März 2015 13:46 > > > An: Maven Users List > > > Betreff: Re: How to configure maven-dependency-plugin's encoding > > > used for unpack? > > > > > > > > > > > > I did not actually look at the implementation on the dependency > > > plugin, but it is actually technically impossible to supply the > > > encoding > > > > parameter > > > > > to > > > *unzip* via the <archiverConfig> tag. So until this is fixed, > > > UTF-8 zip archives are the only ones that will work (with plexus > > > unzip archiver). > > > > > > > > > > > Kristian > > > > > > > > > > > > > > > 2015-03-16 13:05 GMT+01:00 Adrien Rivard <adrien.riv...@gmail.com>: > > > > > > > > > > > > > If I'm reading the documentation correctly, > > > > <archiverConfig><encoding> only apply to filter resources, not > > > > to zip them. > > > > > > > > > > > > > > > In any case I would try using utf-8. > > > > > > > > > > > > > > > > > > > > On Mon, Mar 16, 2015 at 12:34 PM, Kristian Rosenvold < > > > > kristian.rosenv...@gmail.com> wrote: > > > > > > > > > > > > > > > > > I dont believe there is support for specifying encoding to > > > > > unzip. At > > > > > > > > least > > > > > > > > > assembly only provides config to zip. Call it a bug, call it a > > > > > feature :( > > > > > > > > > > > > > > > > > > > > Kristian > > > > > > > > > > > > > > > > > > > > > > > > > 2015-03-16 12:12 GMT+01:00 Markus Karg <k...@quipsy.de>: > > > > > > > > > > > > > > > > > > > > > To preserve German umlauts in file names within a ZIP, we > > > > > > are > > > > > > using... > > > > > > > > > > > > > > > > > > > > > <archiverConfig> > > > > > > <encoding>CP850</encoding> > > > > > > </archiverConfig> > > > > > > > > > > > > > > > > > > > > > > > > ...in the maven-assembly-plugin configuration, which is > > > > > > working > > > > well. > > > > > > :) > > > > : > > > > > > > > > > > > > > > > > > Next we want to use maven-dependency-plugin to unpack that ZIP. > > > > > > > > > > > > > > > > > > > > > > > > How can we configure maven-dependency-plugin:unpack so it > > > > > > will apply > > > > > > > > > > CP850 > > > > > > > > > > > when unpacking that ZIP? > > > > > > > > > > > > > > > > > > > > > > > > Thanks! > > > > > > -Markus > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > Adrien Rivard > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > Baptiste <Batmat> MATHUS - http://batmat.net Sauvez un arbre, Mangez > > un castor ! > > > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@maven.apache.org For additional commands, e-mail: users-h...@maven.apache.org
