Re: [Users] hosted-engine deployment doesn't accept legal email address (ovirt-3.4.0-prerelease)
- Original Message - > From: "Giorgio Bersano" > To: "Doron Fediuck" > Cc: Users@ovirt.org, "Yedidyah Bar David" , "Sandro > Bonazzola" > Sent: Friday, February 14, 2014 10:54:25 AM > Subject: Re: [Users] hosted-engine deployment doesn't accept legal email > address (ovirt-3.4.0-prerelease) > > 2014-02-12 17:28 GMT+01:00 Doron Fediuck : > > > > Hi Giorgio. > > Patches are always welcomed! > > > > I'd start with opening a bug, as mail verification may need > > some attention. > > > > Next, to get the code you can use- > > git clone git://gerrit.ovirt.org/ovirt-hosted-engine-setup > > > > and then make a patch and push it to gerrit. > > > > Thanks again! > > Doron > > Hi Doron, > here it is: https://bugzilla.redhat.com/show_bug.cgi?id=1065269 . > > To speedup things I've put the patch in there, as I'm not familiar > with gerrit ATM . > Please push it by yourself if you agree; in the meantime I'll try to > learn how to use it. > > TIA, > Giorgio. > Giorgio, eccellente ;) This is how your patch looks like in Gerrit (Thanks to Sandro)- http://gerrit.ovirt.org/#/c/24476/ Keep sending patches! Doron ___ Users mailing list Users@ovirt.org http://lists.ovirt.org/mailman/listinfo/users
Re: [Users] hosted-engine deployment doesn't accept legal email address (ovirt-3.4.0-prerelease)
2014-02-12 17:28 GMT+01:00 Doron Fediuck : > > Hi Giorgio. > Patches are always welcomed! > > I'd start with opening a bug, as mail verification may need > some attention. > > Next, to get the code you can use- > git clone git://gerrit.ovirt.org/ovirt-hosted-engine-setup > > and then make a patch and push it to gerrit. > > Thanks again! > Doron Hi Doron, here it is: https://bugzilla.redhat.com/show_bug.cgi?id=1065269 . To speedup things I've put the patch in there, as I'm not familiar with gerrit ATM . Please push it by yourself if you agree; in the meantime I'll try to learn how to use it. TIA, Giorgio. ___ Users mailing list Users@ovirt.org http://lists.ovirt.org/mailman/listinfo/users
Re: [Users] hosted-engine deployment doesn't accept legal email address (ovirt-3.4.0-prerelease)
- Original Message - > From: "Giorgio Bersano" > To: Users@ovirt.org > Sent: Wednesday, February 12, 2014 12:28:33 PM > Subject: [Users] hosted-engine deployment doesn't accept legal email address > (ovirt-3.4.0-prerelease) > > Hi, > I am happily testing the hosted engine feature, sorry I was late on > the test day but I dare to provide some feedback. > To be more clear I prefer to report one item per email. > > This is related to a really minor issue I think it doesn't deserve a > Bugzilla but I'm ready to do it if requested. > > So, during > # hosted-engine --deploy > in the step named "--== HOSTED ENGINE CONFIGURATION ==--" we are asked > to provide a couple of email addresses but addresses with an hypen > before the @ sign (ex. my-n...@mydomain.com ) aren't allowed and > throwns the following: > [ ERROR ] Invalid input, please try again > > As a workaround I used another address but, looking at > /usr/share/ovirt-hosted-engine-setup/plugins/ovirt-hosted-engine-setup/ha/ha_notifications.py > (ovirt-hosted-engine-setup-1.1.0-0.5.beta2.el6.noarch) > I've found that _RE_EMAIL_ADDRESS is using a simplified pattern (hope > that gmail doesn't mangles text too much): > > [a-zA-Z0-9_.+]+ > @ > [a-z0-9.-]+ > > even avoiding the intricacy of the whole possibilities (see "Local > part" in http://en.wikipedia.org/wiki/Email_address ) I think the > following (not tested) could be more appropriate: > > [a-zA-Z0-9] > [a-zA-Z0-9_.+-]+ > [a-zA-Z0-9] > @ > [a-z0-9.-]+ > > don't know if it really works as I've never programmed in python but I > hope you get the idea. > > Best regards, > Giorgio. Hi Giorgio. Patches are always welcomed! I'd start with opening a bug, as mail verification may need some attention. Next, to get the code you can use- git clone git://gerrit.ovirt.org/ovirt-hosted-engine-setup and then make a patch and push it to gerrit. Thanks again! Doron ___ Users mailing list Users@ovirt.org http://lists.ovirt.org/mailman/listinfo/users
[Users] hosted-engine deployment doesn't accept legal email address (ovirt-3.4.0-prerelease)
Hi, I am happily testing the hosted engine feature, sorry I was late on the test day but I dare to provide some feedback. To be more clear I prefer to report one item per email. This is related to a really minor issue I think it doesn't deserve a Bugzilla but I'm ready to do it if requested. So, during # hosted-engine --deploy in the step named "--== HOSTED ENGINE CONFIGURATION ==--" we are asked to provide a couple of email addresses but addresses with an hypen before the @ sign (ex. my-n...@mydomain.com ) aren't allowed and throwns the following: [ ERROR ] Invalid input, please try again As a workaround I used another address but, looking at /usr/share/ovirt-hosted-engine-setup/plugins/ovirt-hosted-engine-setup/ha/ha_notifications.py (ovirt-hosted-engine-setup-1.1.0-0.5.beta2.el6.noarch) I've found that _RE_EMAIL_ADDRESS is using a simplified pattern (hope that gmail doesn't mangles text too much): [a-zA-Z0-9_.+]+ @ [a-z0-9.-]+ even avoiding the intricacy of the whole possibilities (see "Local part" in http://en.wikipedia.org/wiki/Email_address ) I think the following (not tested) could be more appropriate: [a-zA-Z0-9] [a-zA-Z0-9_.+-]+ [a-zA-Z0-9] @ [a-z0-9.-]+ don't know if it really works as I've never programmed in python but I hope you get the idea. Best regards, Giorgio. ___ Users mailing list Users@ovirt.org http://lists.ovirt.org/mailman/listinfo/users
