[ovirt-users] Re: Ansible ovirt_disk module: how to attach disk without activation

2020-06-17 Thread Gianluca Cecchi
On Tue, Jun 16, 2020 at 10:04 AM Martin Necas  wrote:

> Hi Gianluca,
>
> this looks like an issue in the module.
> I have created PR which should fix the problem [1].
> Please check it out. You can manually create an ansible library to which
> you would copy the module and add the fix there or wait till it is
> added to ansible 2.9.
>
> Further issues/requests recommend to create on the repo.
>
> [1] https://github.com/oVirt/ovirt-ansible-collection/pull/61
>
> Martin Necas
>
>
>
Thanks Martin!
I verified correct behavior after applying the patch both using
ansible-playbook on a 2.9.9 ansible environment and using awx with patched
ansible 2.8.5 venv
I put my feedback on github page too

Gianluca
___
Users mailing list -- users@ovirt.org
To unsubscribe send an email to users-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/privacy-policy.html
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/users@ovirt.org/message/GDI4LY5PNQEQZM6DFO464JN2UNLESJEF/


[ovirt-users] Re: Ansible ovirt_disk module: how to attach disk without activation

2020-06-16 Thread Martin Necas
Hi Gianluca,

this looks like an issue in the module.
I have created PR which should fix the problem [1].
Please check it out. You can manually create an ansible library to which
you would copy the module and add the fix there or wait till it is added to
ansible 2.9.

Further issues/requests recommend to create on the repo.

[1] https://github.com/oVirt/ovirt-ansible-collection/pull/61

Martin Necas

On Mon, Jun 15, 2020 at 11:57 PM Gianluca Cecchi 
wrote:

> On Mon, Jun 15, 2020 at 11:47 PM Gianluca Cecchi <
> gianluca.cec...@gmail.com> wrote:
>
>>
>>   register: disk_attach_info
>>
>> But going to see registered variable it contains "active: true":
>>
>> "disk_activate_info": {
>> "changed": false,
>> "id": "6f7cdf02-cf8b-4fa8-ac00-6b47f6e0c827",
>> "diskattachment": {
>> "href":
>> "/ovirt-engine/api/vms/b5c67c93-bd5d-42b6-a873-05f69cece2f1/diskattachments/6f7cdf02-cf8b-4fa8-ac00-6b47f6e0c827",
>> "id": "6f7cdf02-cf8b-4fa8-ac00-6b47f6e0c827",
>> "active": true,
>> "bootable": false,
>> "disk": {
>> 
>>
>>
> Unfortunately I copied two times the disk_activate_info registered value
> in the previous e-mail.
> Here below the correct disk_attach_info var contents that contains
> "active: true":
>
> "disk_attach_info": {
> "changed": true,
> "id": "6f7cdf02-cf8b-4fa8-ac00-6b47f6e0c827",
> "diskattachment": {
> "href":
> "/ovirt-engine/api/vms/b5c67c93-bd5d-42b6-a873-05f69cece2f1/diskattachments/6f7cdf02-cf8b-4fa8-ac00-6b47f6e0c827",
> "id": "6f7cdf02-cf8b-4fa8-ac00-6b47f6e0c827",
> "active": true,
> "bootable": false,
> "disk": {
> "href":
> "/ovirt-engine/api/disks/6f7cdf02-cf8b-4fa8-ac00-6b47f6e0c827",
> "id": "6f7cdf02-cf8b-4fa8-ac00-6b47f6e0c827"
> },
> ...
>
> Gianluca
> ___
> Users mailing list -- users@ovirt.org
> To unsubscribe send an email to users-le...@ovirt.org
> Privacy Statement: https://www.ovirt.org/privacy-policy.html
> oVirt Code of Conduct:
> https://www.ovirt.org/community/about/community-guidelines/
> List Archives:
> https://lists.ovirt.org/archives/list/users@ovirt.org/message/ANQCN5GFPSWJG36LH7PJJU3BU477HBPM/
>
___
Users mailing list -- users@ovirt.org
To unsubscribe send an email to users-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/privacy-policy.html
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/users@ovirt.org/message/5ALPQ2KGXEHKEKCIZMGHZYLS5QGHPKCH/


[ovirt-users] Re: Ansible ovirt_disk module: how to attach disk without activation

2020-06-15 Thread Gianluca Cecchi
On Mon, Jun 15, 2020 at 11:47 PM Gianluca Cecchi 
wrote:

>
>   register: disk_attach_info
>
> But going to see registered variable it contains "active: true":
>
> "disk_activate_info": {
> "changed": false,
> "id": "6f7cdf02-cf8b-4fa8-ac00-6b47f6e0c827",
> "diskattachment": {
> "href":
> "/ovirt-engine/api/vms/b5c67c93-bd5d-42b6-a873-05f69cece2f1/diskattachments/6f7cdf02-cf8b-4fa8-ac00-6b47f6e0c827",
> "id": "6f7cdf02-cf8b-4fa8-ac00-6b47f6e0c827",
> "active": true,
> "bootable": false,
> "disk": {
> 
>
>
Unfortunately I copied two times the disk_activate_info registered value in
the previous e-mail.
Here below the correct disk_attach_info var contents that contains "active:
true":

"disk_attach_info": {
"changed": true,
"id": "6f7cdf02-cf8b-4fa8-ac00-6b47f6e0c827",
"diskattachment": {
"href":
"/ovirt-engine/api/vms/b5c67c93-bd5d-42b6-a873-05f69cece2f1/diskattachments/6f7cdf02-cf8b-4fa8-ac00-6b47f6e0c827",
"id": "6f7cdf02-cf8b-4fa8-ac00-6b47f6e0c827",
"active": true,
"bootable": false,
"disk": {
"href":
"/ovirt-engine/api/disks/6f7cdf02-cf8b-4fa8-ac00-6b47f6e0c827",
"id": "6f7cdf02-cf8b-4fa8-ac00-6b47f6e0c827"
},
...

Gianluca
___
Users mailing list -- users@ovirt.org
To unsubscribe send an email to users-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/privacy-policy.html
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/users@ovirt.org/message/ANQCN5GFPSWJG36LH7PJJU3BU477HBPM/