Serious Bug in AMQP 1.0 JMS Client with persistent messages

2014-01-08 Thread uromahn
I believe I found a serious bug in the current (latest version from source) qpid-amqp-1-0-client-jms library. I think the client violates the delivery guarantee of JMS with persistent messages. Here is my test: 1. Start a qpid-cpp broker. Create a persistent queue on that broker 2. Start a test

Re: Serious Bug in AMQP 1.0 JMS Client with persistent messages

2014-01-08 Thread uromahn
Quick update: re-ran the test using a qpid-0.24 Java broker with the same result. A kill -9 lost 42 messages from 491 reported sent. Still not clear whether it is a client bug or a bug in the proton messaging library. -- View this message in context:

Re: Serious Bug in AMQP 1.0 JMS Client with persistent messages

2014-01-08 Thread uromahn
Rob, saw your reply after my second post. I will try that out immediately. As you mentioned, the client should be intelligent enough to switch off async publishing by default when a producer was set to persistent delivery mode since the client is expected to honor the JMS delivery guarantee in

Re: Serious Bug in AMQP 1.0 JMS Client with persistent messages

2014-01-08 Thread Rob Godfrey
Hi Uli, To enable synchronous publishing you need to either set the Java system property qpid.sync_publish to true, or have sync-publish=true as one of the URL options in your connection URL. I agree it should be the default, and we can look to change this in a future release. -- Rob On 8

Re: Serious Bug in AMQP 1.0 JMS Client with persistent messages

2014-01-08 Thread uromahn
I changed my test to use 'sync-publish=true' in my connection URL as suggested. However, now I am facing another issue: Publishing to my qpid-cpp broker becomes extremely slow: less than 1 msg/sec compared to 1000+ msgs/sec with async publish! Publishing to an ActiveMQ 5.9.0 broker seems to hang

Re: Serious Bug in AMQP 1.0 JMS Client with persistent messages

2014-01-08 Thread Rob Godfrey
Hi Uli, On 8 Jan 2014 20:29, uromahn ulr...@ulrichromahn.net wrote: I changed my test to use 'sync-publish=true' in my connection URL as suggested. However, now I am facing another issue: Publishing to my qpid-cpp broker becomes extremely slow: less than 1 msg/sec compared to 1000+ msgs/sec

Re: Serious Bug in AMQP 1.0 JMS Client with persistent messages

2014-01-08 Thread uromahn
Rob, I just completed another round of testing and here is a consolidated status: Client (latest version build from trunk) using anyc-publish=true: *Qpid Java Broker 0.24:* enqueued and dequeued 1000 messages. Writes about 8.5 msgs/sec and reads about 60 msgs/sec. *Qpid CPP Broker (latest source

Re: Serious Bug in AMQP 1.0 JMS Client with persistent messages

2014-01-08 Thread Fraser Adams
On 08/01/14 18:55, Rob Godfrey wrote: Hi Uli, To enable synchronous publishing you need to either set the Java system property qpid.sync_publish to true, or have sync-publish=true as one of the URL options in your connection URL. I agree it should be the default, and we can look to change this

Re: Serious Bug in AMQP 1.0 JMS Client with persistent messages

2014-01-08 Thread Rob Godfrey
On 8 January 2014 21:27, Fraser Adams fraser.ad...@blueyonder.co.uk wrote: On 08/01/14 18:55, Rob Godfrey wrote: Hi Uli, To enable synchronous publishing you need to either set the Java system property qpid.sync_publish to true, or have sync-publish=true as one of the URL options in your

Re: Serious Bug in AMQP 1.0 JMS Client with persistent messages

2014-01-08 Thread Rob Godfrey
On 8 January 2014 21:15, uromahn ulr...@ulrichromahn.net wrote: Rob, I just completed another round of testing and here is a consolidated status: Client (latest version build from trunk) using anyc-publish=true: *Qpid Java Broker 0.24:* enqueued and dequeued 1000 messages. Writes about

Re: Serious Bug in AMQP 1.0 JMS Client with persistent messages

2014-01-08 Thread Timothy Bish
On 01/08/2014 03:41 PM, Rob Godfrey wrote: On 8 January 2014 21:27, Fraser Adams fraser.ad...@blueyonder.co.uk wrote: On 08/01/14 18:55, Rob Godfrey wrote: Hi Uli, To enable synchronous publishing you need to either set the Java system property qpid.sync_publish to true, or have

Re: Serious Bug in AMQP 1.0 JMS Client with persistent messages

2014-01-08 Thread Rob Godfrey
Looks good - I'll commit it later tonight -- Rob On 8 January 2014 21:54, Timothy Bish tabish...@gmail.com wrote: On 01/08/2014 03:41 PM, Rob Godfrey wrote: On 8 January 2014 21:27, Fraser Adams fraser.ad...@blueyonder.co.uk wrote: On 08/01/14 18:55, Rob Godfrey wrote: Hi Uli, To

Re: Serious Bug in AMQP 1.0 JMS Client with persistent messages

2014-01-08 Thread Rob Godfrey
What sort of environment are you using? Just testing on my laptop (Macbook with SSD) over loopback and using small (Hello World) messages I get ~1100msg/s sync publish on the Java Broker with the Derby store and ~1600msg/s with the Java Broker and BDB store. -- Rob On 8 January 2014 21:15,

Re: Serious Bug in AMQP 1.0 JMS Client with persistent messages

2014-01-08 Thread uromahn
Thanks for creating a patch on such a short notice. I am testing it out on my side right now. -Uli -- View this message in context: http://qpid.2158936.n2.nabble.com/Serious-Bug-in-AMQP-1-0-JMS-Client-with-persistent-messages-tp7602408p7602435.html Sent from the Apache Qpid users mailing list

Re: Serious Bug in AMQP 1.0 JMS Client with persistent messages

2014-01-08 Thread uromahn
With the patch added to my local sources, I ran a bunch of different tests against an ActiveMQ 5.9.0 and 5.10-SNAPSHOT broker using the patched as well as unpatched client library. To summarize my findings: 1. running the patched client against ActiveMQ 5.9.0 without sync-publish set at all does

Re: Serious Bug in AMQP 1.0 JMS Client with persistent messages

2014-01-08 Thread uromahn
Quick correction of my last post: it seems that I still have a message loss when running against ActiveMQ 5.10-SNAPSHOT without setting sync-publish, although the loss seems to be consistently limited to a single message - the last one published. So, there seems to be something really odd going

Re: Serious Bug in AMQP 1.0 JMS Client with persistent messages

2014-01-08 Thread Timothy Bish
On 01/08/2014 05:34 PM, uromahn wrote: With the patch added to my local sources, I ran a bunch of different tests against an ActiveMQ 5.9.0 and 5.10-SNAPSHOT broker using the patched as well as unpatched client library. To summarize my findings: 1. running the patched client against ActiveMQ

Re: Serious Bug in AMQP 1.0 JMS Client with persistent messages

2014-01-08 Thread uromahn
I was doing that but was missing your commit by just a few minutes. Re-building just now to see how it changes... -- View this message in context: http://qpid.2158936.n2.nabble.com/Serious-Bug-in-AMQP-1-0-JMS-Client-with-persistent-messages-tp7602408p7602452.html Sent from the Apache Qpid

Re: Serious Bug in AMQP 1.0 JMS Client with persistent messages

2014-01-08 Thread uromahn
Ok, I did the following: 1. got the latest sources for ActiveMQ 5.10-SNAPSHOT and built from source 2. got the latest sources for qpid and build amqp-1-0-client-jms from source 3. started ActiveMQ 5.10-SNAPSHOT enabling levelDB (Java) and NIO on the AMQP connector 4. re-built my test program with