RE: Work on Emulation

2018-03-29 Thread Alina Kazi
Hi Piotr , 1.Created a branch : https://github.com/alinakazi/royale-asjs/tree/mxRoyaleAQ 2.Added file ListEvent.as manually to the location using upload file at: https://github.com/alinakazi/royale-asjs/tree/mxRoyaleAQ/frameworks/projects/MXRoyale/src/main/royale/mx/events 3.Created a Pull

Re: Work on Emulation

2018-03-29 Thread Piotr Zarzycki
I think adding through the console is also ok. If you affect your branch you will be able to fix that. You won't affect Main repository, because you don't have commit rights yet. You can do pull requests only. Do not hesitate try. Again: 1) You have your branch mxRoyaleAK 2) Switch to that

RE: Work on Emulation

2018-03-29 Thread Alina Kazi
Currently, I am not using https://github.com/alinakazi/royale-asjs Do you want me to add my file Manually ? https://github.com/alinakazi/royale-asjs/tree/feature/MXRoyale/frameworks/projects/MXRoyale/src/main/royale/mx/events

Re: Work on Emulation

2018-03-29 Thread Piotr Zarzycki
Are you pushing to your forked royale-asjs ? -> https://github.com/alinakazi/royale-asjs, because I think you should do that in that way. Than doing a pull request to the main repository. 2018-03-29 12:44 GMT+02:00 Alina Kazi : > Should I write git push --set-upstream origin

RE: Work on Emulation

2018-03-29 Thread Alina Kazi
Should I write git push --set-upstream origin mxRoyaleAK Instead of git push as instructed below: D:\new\royale-asjs>git push fatal: The current branch mxRoyaleAK has no upstream branch. To push the current branch and set the remote as upstream, use git push --set-upstream origin

Re: Work on Emulation

2018-03-29 Thread Piotr Zarzycki
Let me close it, you will do once again. 2018-03-29 12:22 GMT+02:00 Alina Kazi : > Created a Pull Request by mistake > Feature/mx royale > > #137 opened 5 minutes ago by alinakazi >

RE: Work on Emulation

2018-03-29 Thread Alina Kazi
Created a Pull Request by mistake Feature/mx royale #137 opened 5 minutes ago by alinakazi How can I delete it? Thanks, Alina Kazi From: Alina Kazi

Re: Work on Emulation

2018-03-29 Thread Piotr Zarzycki
It looks good. Try to make pull request against MXRoyale and see whether only those files are you seeing changed. 2018-03-29 12:10 GMT+02:00 Alina Kazi : > Hi Piotr, > > > > Created a new branch mxRoyaleAK > > Switch to the branch > > ListEvent.as File Copied > > The result

RE: Work on Emulation

2018-03-29 Thread Alina Kazi
Hi Piotr, Created a new branch mxRoyaleAK Switch to the branch ListEvent.as File Copied The result is : https://www.dropbox.com/s/g5bxzr472r2hidu/addtobranch.png?dl=0 Is it ok? Thanks, Alina From: Piotr Zarzycki [mailto:piotrzarzyck...@gmail.com] Sent: Thursday, March

Re: Work on Emulation

2018-03-29 Thread Piotr Zarzycki
Alina, If you are create branch based on MXRoyale - you will have exactly the same hierarchy as it is in that branch. Once you add everything what you need, make pull request we will merge it into the MXRoyale. Actually when you will be working on your branch once you create pull request GitHub

RE: Work on Emulation

2018-03-29 Thread Alina Kazi
Hi Piotr, Peter and Alex are using MXRoyale branch to work on emulation. You want me to create another branch and add my files to it. Then, open a pull request and I should select the drop down list: Base: MXRoyale <- Compare:MyBranch If these are the steps that I should follow, I want to

Re: Work on Emulation

2018-03-29 Thread Piotr Zarzycki
Hi Alina, On your screenshot I see to many files changed. The best way of work with pull request are branches. 1. You pickup some control to work from raised issue - create new branch against MXRoyale - alert_mxroyale - just an example 2. Once all your changes you have in your branch - open pull

RE: Work on Emulation

2018-03-29 Thread Alina Kazi
I understand that I need to follow below mentioned steps to work on a new emulation component: 1. I will copy files from flex-sdk branch to my local machine, 2. I will make changes in the files on my local machine based on the document available on “Setup & Migration ->