Re: ArrayCollection Problem in AMFBinaryData.as

2018-05-16 Thread doug777
Hi Carlos, I now have ArrayCollection working properly. I suspect the same change will also allow ObjectProxy to work properly as well, but at the moment I can't test that. Doug -- Sent from: http://apache-royale-users.20374.n8.nabble.com/

Re: is being broken by the compiler

2018-05-16 Thread Piotr Zarzycki
It will be. Last time when I responded to you I just didn't click Start Review. All comments which you are adding as a reviewer are in "Pending" state until you hit "Start Review" ;) I won't forget this time! :) Thanks, Piotr 2018-05-16 16:01 GMT+02:00 : > Okay

Re: is being broken by the compiler

2018-05-16 Thread serkan . tas
Okay i'll make it :) Can you check if your response to my comments are viewable for me ? Alinti Piotr Zarzycki I you are going to do that, make sure to create new branch for that. If not you will mess up the current one. :) 2018-05-16 12:39 GMT+02:00

Re: is being broken by the compiler

2018-05-16 Thread Piotr Zarzycki
I you are going to do that, make sure to create new branch for that. If not you will mess up the current one. :) 2018-05-16 12:39 GMT+02:00 : > > I know Piotr :) > > I am working on the issue, may be am going to close PR and create new one > after syncronizing

Re: is being broken by the compiler

2018-05-16 Thread serkan . tas
I know Piotr :) I am working on the issue, may be am going to close PR and create new one after syncronizing repos. Alinti Piotr Zarzycki Looking forward to your update! :) Make sure that your branch is refreshed with newest changes from MXRoyale branch,

Re: is being broken by the compiler

2018-05-16 Thread serkan . tas
Thank you Piotr, They are not ready. I will inform you when i prepare PR update. Serkan. Alinti Piotr Zarzycki Serkan, If you have your changes ready after my comments, please update your pull request and let me know! Piotr 2018-05-16 9:31 GMT+02:00

Re: is being broken by the compiler

2018-05-16 Thread Piotr Zarzycki
Serkan, If you have your changes ready after my comments, please update your pull request and let me know! Piotr 2018-05-16 9:31 GMT+02:00 : > > Hi Piotr, > > Rather than asking on the list, i would like to check first if you had > time to see my coments that i

Re: is being broken by the compiler

2018-05-16 Thread serkan . tas
Hi Piotr, Rather than asking on the list, i would like to check first if you had time to see my coments that i made few days ago. Thanks Serkan. Alinti Piotr Zarzycki Serkan, Are you going to update that PR - that's what you mean ? If something is not fully