Re: DQS rules for SA 4.0.0+

2022-12-28 Thread Benny Pedersen
Riccardo Alfieri skrev den 2022-12-28 11:44: Hello everyone, just FYI, I published the updated rules to have DQS working on SA 4.0.0+ (https://github.com/spamhaus/spamassassin-dqs) https://github.com/spamhaus/spamassassin-dqs/blob/master/4.0.0%2B/sh.cf dated Spamhaus's SpamAssassin setup

Re: DQS rules for SA 4.0.0+

2022-12-28 Thread Riccardo Alfieri
On 28/12/22 15:15, Henrik K wrote: Maybe would be even good idea to use something like this: ifplugin Mail::SpamAssassin::Plugin::HashBL else error: Please activate HashBL plugin in v342.pre endif I think I'll just add the ifplugin condition in the two .cf files and add a note in

Re: DQS rules for SA 4.0.0+

2022-12-28 Thread Henrik K
And it is even mentioned in the UPGRADE notes: - The HashBL plugin in 342.pre is now enabled by default. (sad typo in the filename) On Wed, Dec 28, 2022 at 04:21:45PM +0200, Henrik K wrote: > > This was discussed and approved in some of the 4.0.0 bugs. There should be > no need to revisit

Re: DQS rules for SA 4.0.0+

2022-12-28 Thread Kevin A. McGrail
As I say, such is life.  It's a minor thing.  Any objections to a comment if it doesn't exist that documents it was enabled by default in 4.0.0 in the 3.4.2 pre file? On 12/28/2022 9:21 AM, Henrik K wrote: This was discussed and approved in some of the 4.0.0 bugs. There should be no need to

Re: DQS rules for SA 4.0.0+

2022-12-28 Thread Henrik K
This was discussed and approved in some of the 4.0.0 bugs. There should be no need to revisit it. It still wouldn't make sense to have loadplugin HashBL in two *.pre files. On Wed, Dec 28, 2022 at 09:18:51AM -0500, Kevin A. McGrail wrote: > Wow, as it's enabled in v342.pre, that would imply

Re: DQS rules for SA 4.0.0+

2022-12-28 Thread Kevin A. McGrail
Wow, as it's enabled in v342.pre, that would imply it was enabled in 3.4.2.  We should not have changed a past pre file for the 4.0.0 release IMO but added it to the 4.0.0.pre file.  Such is life.  Should we fix it for 4.0.1? On 12/28/2022 9:07 AM, Henrik K wrote: Just keep in mind that

Re: DQS rules for SA 4.0.0+

2022-12-28 Thread Benny Pedersen
Henrik K skrev den 2022-12-28 15:06: Of course it's a bit of a double-edged sword, since with ifplugin the rules might silently be ignored. Especially for Gentoo users. ;-) gentoo users does not use precompiled problems

Re: DQS rules for SA 4.0.0+

2022-12-28 Thread Henrik K
On Wed, Dec 28, 2022 at 04:06:01PM +0200, Henrik K wrote: > On Wed, Dec 28, 2022 at 01:58:55PM +, Riccardo Alfieri wrote: > > On 28/12/22 14:44, Henrik K wrote: > > > > > It is enabled by default for new installs in v342.pre (old users must > > > enable > > > it manually). But like with any

Re: DQS rules for SA 4.0.0+

2022-12-28 Thread Benny Pedersen
Kevin A. McGrail skrev den 2022-12-28 15:04: Going further, you might just encapsulate your entire cf file in to ifplugin checks, one for URIDNSBL and one for HashBL and any other plugins you need. bingo However, both URIDNSBL and HashBL are enabled by default from checking the source code.

Re: DQS rules for SA 4.0.0+

2022-12-28 Thread Henrik K
On Wed, Dec 28, 2022 at 09:04:09AM -0500, Kevin A. McGrail wrote: > > However, both URIDNSBL and HashBL are enabled by default from checking the > source code. Just keep in mind that HashBL is only enabled for fresh 4.0.0 installs, it wasn't default previously.

Re: DQS rules for SA 4.0.0+

2022-12-28 Thread Henrik K
On Wed, Dec 28, 2022 at 01:58:55PM +, Riccardo Alfieri wrote: > On 28/12/22 14:44, Henrik K wrote: > > > It is enabled by default for new installs in v342.pre (old users must enable > > it manually). But like with any other loadable plugin, one MUST check use > > "ifplugin" to check that

Re: DQS rules for SA 4.0.0+

2022-12-28 Thread Kevin A. McGrail
Going further, you might just encapsulate your entire cf file in to ifplugin checks, one for URIDNSBL and one for HashBL and any other plugins you need. However, both URIDNSBL and HashBL are enabled by default from checking the source code. Regards, KAM On 12/28/2022 8:58 AM, Riccardo

Re: DQS rules for SA 4.0.0+

2022-12-28 Thread Riccardo Alfieri
On 28/12/22 14:44, Henrik K wrote: It is enabled by default for new installs in v342.pre (old users must enable it manually). But like with any other loadable plugin, one MUST check use "ifplugin" to check that it's loaded. Ok, thanks for the clarification. Would you then suggest to add also

Re: DQS rules for SA 4.0.0+

2022-12-28 Thread Benny Pedersen
Kevin A. McGrail skrev den 2022-12-28 14:48: And posters should do their homework as well and post information that shows what is the problem, how to recreate it, and the expected outcome. Your posts on this thread are borderline nonsensical. i did, but you did not understand me, sorry for

Re: DQS rules for SA 4.0.0+

2022-12-28 Thread Benny Pedersen
Kevin A. McGrail skrev den 2022-12-28 14:44: On 12/28/2022 8:35 AM, Riccardo Alfieri wrote: Do you have hashbl plugin enabled? Ah, I thought it was enabled by default in SA 4.0. You are correct.  HashBL is by default enabled in a stock distribution with v342.pre.  That doesn't mean the

Re: DQS rules for SA 4.0.0+

2022-12-28 Thread Kevin A. McGrail
On 12/28/2022 8:33 AM, Benny Pedersen wrote: I have no idea what the check plugin is.  Read your quoted line again. don't read the source ?, https://github.com/apache/spamassassin/blob/trunk/rules/v320.pre#L21 My question was: Do you have the Plugin HashBL enabled. i have in my test only

Re: DQS rules for SA 4.0.0+

2022-12-28 Thread Benny Pedersen
Riccardo Alfieri skrev den 2022-12-28 14:35: On 28/12/22 14:20, Kevin A. McGrail wrote: Do you have hashbl plugin enabled? Ah, I thought it was enabled by default in SA 4.0. only check is on --lint testing, if all plugins is default enabled multiple errors is hidded hopefully

Re: DQS rules for SA 4.0.0+

2022-12-28 Thread Kevin A. McGrail
On 12/28/2022 8:35 AM, Riccardo Alfieri wrote: Do you have hashbl plugin enabled? Ah, I thought it was enabled by default in SA 4.0. You are correct.  HashBL is by default enabled in a stock distribution with v342.pre.  That doesn't mean the trouble reporter has it enabled. -- Kevin A.

Re: DQS rules for SA 4.0.0+

2022-12-28 Thread Henrik K
On Wed, Dec 28, 2022 at 01:35:22PM +, Riccardo Alfieri wrote: > On 28/12/22 14:20, Kevin A. McGrail wrote: > > > Do you have hashbl plugin enabled? > > > > > Ah, I thought it was enabled by default in SA 4.0. It is enabled by default for new installs in v342.pre (old users must enable it

Re: DQS rules for SA 4.0.0+

2022-12-28 Thread Benny Pedersen
Riccardo Alfieri skrev den 2022-12-28 14:34: Looks like you didn't replace the DQS key in the template, as it's outlined in the README. i will not share my key here You also have a lot of parsing errors that are not normal (\t should be a , don't know why your system renders that badly)

Re: DQS rules for SA 4.0.0+

2022-12-28 Thread Riccardo Alfieri
On 28/12/22 14:20, Kevin A. McGrail wrote: Do you have hashbl plugin enabled? Ah, I thought it was enabled by default in SA 4.0. -- Best regards, Riccardo Alfieri Spamhaus Technology https://www.spamhaus.com/

Re: DQS rules for SA 4.0.0+

2022-12-28 Thread Riccardo Alfieri
Looks like you didn't replace the DQS key in the template, as it's outlined in the README. You also have a lot of parsing errors that are not normal (\t should be a , don't know why your system renders that badly) On 28/12/22 14:17, Benny Pedersen wrote: Dec 28 14:12:09.837 [1461] warn:

Re: DQS rules for SA 4.0.0+

2022-12-28 Thread Benny Pedersen
Kevin A. McGrail skrev den 2022-12-28 14:24: I have no idea what the check plugin is.  Read your quoted line again. don't read the source ?, https://github.com/apache/spamassassin/blob/trunk/rules/v320.pre#L21 i have in my test only this plugin enabled, rest is disabled rule maintainers

Re: DQS rules for SA 4.0.0+

2022-12-28 Thread Kevin A. McGrail
I have no idea what the check plugin is.  Read your quoted line again. On 12/28/2022 8:22 AM, Benny Pedersen wrote: Kevin A. McGrail skrev den 2022-12-28 14:20: Do you have hashbl plugin enabled? read your quoted line again ? On 12/28/2022 8:17 AM, Benny Pedersen wrote: above is with

Re: DQS rules for SA 4.0.0+

2022-12-28 Thread Benny Pedersen
Kevin A. McGrail skrev den 2022-12-28 14:20: Do you have hashbl plugin enabled? read your quoted line again ? On 12/28/2022 8:17 AM, Benny Pedersen wrote: above is with only check plugin enabled, this should lint without warnings

Re: DQS rules for SA 4.0.0+

2022-12-28 Thread Kevin A. McGrail
Do you have hashbl plugin enabled? On 12/28/2022 8:17 AM, Benny Pedersen wrote: above is with only check plugin enabled, this should lint without warnings -- Kevin A. McGrail kmcgr...@apache.org Member, Apache Software Foundation Chair Emeritus Apache SpamAssassin Project

Re: DQS rules for SA 4.0.0+

2022-12-28 Thread Benny Pedersen
Riccardo Alfieri skrev den 2022-12-28 11:44: Hello everyone, just FYI, I published the updated rules to have DQS working on SA 4.0.0+ (https://github.com/spamhaus/spamassassin-dqs) Thanks to the effort of all SA developers there is no need anymore to install a dedicated plugin, as all of our