Re: SA 3.3.1 and NetAddr::IP 4.034

2010-11-09 Thread Mark Martinec
On Tuesday November 9 2010 09:29:57 Marcin Mirosław wrote: Trying 66.232.79.143... Connected to mail.redfish-solutions.com. 554 mail.redfish-solutions.com ESMTP not accepting messages (the message is now sitting in our queue, retrying periodically) Just from curiosity, You mail

Re: SA 3.3.1 and NetAddr::IP 4.034

2010-11-08 Thread Philip Prindeville
On 11/2/10 8:14 PM, Mark Martinec wrote: Btw, this could be more gracefully handled: $ perl -e 'use Socket6; use Net::Patricia' Prototype mismatch: sub main::AF_INET6: none vs () at /usr/local/lib/perl5/5.12.2/Exporter.pm line 64. Mark That's someone else's bug:

Re: SA 3.3.1 and NetAddr::IP 4.034

2010-11-08 Thread Mark Martinec
Philip, Try the following patch. If it works for you, I'll rerelease as 1.19: my ($self, $ip, $bits, $data) = @_; - $data ||= $bits ? $ip/$bits : $ip; + $data ||= defined $bits ? $ip/$bits : $ip; my $packed = inet_pton(AF_INET6, $ip) || croak(invalid key); Hmm. What I had in

Re: SA 3.3.1 and NetAddr::IP 4.034

2010-11-08 Thread Mark Martinec
Philip, Thanks for your off-list reply. Unfortunately I cannot reply, as your mailer is refusing connections: $ host -t mx redfish-solutions.com redfish-solutions.com mail is handled by 10 mail.redfish-solutions.com. $ telnet -s mail4.ijs.si mail.redfish-solutions.com 25 Trying

Re: SA 3.3.1 and NetAddr::IP 4.034

2010-11-08 Thread Philip Prindeville
On 11/8/10 5:58 PM, Mark Martinec wrote: Philip, Thanks for your off-list reply. Unfortunately I cannot reply, as your mailer is refusing connections: $ host -t mx redfish-solutions.com redfish-solutions.com mail is handled by 10 mail.redfish-solutions.com. $ telnet -s mail4.ijs.si

Re: SA 3.3.1 and NetAddr::IP 4.034

2010-11-07 Thread Philip Prindeville
On 11/2/10 7:35 PM, Mark Martinec wrote: One suggestion: currently it is not possible to store 0 and 1 as a data item associated with each net, because a 0 is treated the same as undef and replaced by the key. And the AF_NET6 argument to new() needs to be documented in a POD. Thanks for your

Re: SA 3.3.1 and NetAddr::IP 4.034

2010-11-07 Thread Philip Prindeville
On 11/7/10 9:19 PM, Philip Prindeville wrote: Try the following patch. If it works for you, I'll rerelease as 1.19: Actually, I released it as Net-Patricia-1.18_01

Re: SA 3.3.1 and NetAddr::IP 4.034

2010-11-02 Thread Mark Martinec
On Tuesday November 2 2010 16:40:49 Rob McMahon wrote: The fix to NetAddr::IP seems to be as simple as --- NetAddr/IP/Lite.pm.bak Fri Oct 29 00:33:06 2010 +++ NetAddr/IP/Lite.pm Tue Nov 2 15:18:05 2010 @@ -740,7 +740,7 @@ if ($mval == 128) { # cidr 128

Re: SA 3.3.1 and NetAddr::IP 4.034

2010-11-02 Thread Mark Martinec
You might be able to get better results with: Net-Patricia-1.18 which I released earlier this week. Thank you for bringing it to our attention. Now that you have added the AF_INET6 support is became useful. I toyed with it for a while, looks good and fast (and a bit memory fat compared

Re: SA 3.3.1 and NetAddr::IP 4.034

2010-10-31 Thread Philip Prindeville
On 10/29/10 9:18 AM, Michael Scheidell wrote: On 10/29/10 12:11 PM, Mark Martinec wrote: Sure, go ahead, can't hurt. The patch is now in the SA trunk. Is it worth opening a ticket and putting it into the 3.3 branch too? Mark looks like Freebsd ports has an older version, so it should be

Re: SA 3.3.1 and NetAddr::IP 4.034

2010-10-29 Thread Mark Martinec
On Thursday 28 October 2010 17:34:28 Giampaolo Tomassoni wrote: I'm too late: Steve Huff already did it... See: https://rt.cpan.org/Public/Bug/Display.html?id=62521 . Perfect. Thank you guys. | Thu Oct 28 19:41:16 2010 michael [...] bizsystems.com fixed in release 4.035 Mark

Re: SA 3.3.1 and NetAddr::IP 4.034

2010-10-29 Thread Mark Martinec
| Thu Oct 28 19:41:16 2010 michael [...] bizsystems.com fixed in release 4.035 Actually ... maybe not fixed ... investigating Mark

Re: SA 3.3.1 and NetAddr::IP 4.034

2010-10-29 Thread Mark Martinec
On Friday 29 October 2010 16:35:31 Mark Martinec wrote: | Thu Oct 28 19:41:16 2010 michael [...] bizsystems.com fixed in release 4.035 Actually ... maybe not fixed ... investigating NetAddr::IP 4.035: correct, this case is now fixed: $ perl -le 'use NetAddr::IP; print

R: SA 3.3.1 and NetAddr::IP 4.034

2010-10-29 Thread Giampaolo Tomassoni
still incorrect: $ perl -le 'use NetAddr::IP; print NetAddr::IP-new6(127/8)' 0:0:0:0:0:0:7F00:0/8 This seems way too ambiguos to me, isn't? How could the NetAddr::IP module get you're instantiating an IPv6 net address, after all. That seems to me a valid IPv6 syntax, too... A workaround

Re: SA 3.3.1 and NetAddr::IP 4.034

2010-10-29 Thread Michael Scheidell
Patch for SpamAssassin Ports, rpm's and yum? or would it hurt to do this to 3.3.2 before it gets released? On 10/29/10 11:01 AM, Mark Martinec wrote: A workaround for SpamAssassin is to avoid shorthand IPv4 network specifications, both in a config file (trusted/internal networks, if any), as

Re: SA 3.3.1 and NetAddr::IP 4.034

2010-10-29 Thread Mark Martinec
Giampaolo, still incorrect: $ perl -le 'use NetAddr::IP; print NetAddr::IP-new6(127/8)' 0:0:0:0:0:0:7F00:0/8 This seems way too ambiguos to me, isn't? No, it isn't ambiguous, it is a perfectly valid syntax for an IPv4 network, although nowadays somewhat deprecated in favour for the

Re: SA 3.3.1 and NetAddr::IP 4.034

2010-10-29 Thread Michael Scheidell
On 10/29/10 12:11 PM, Mark Martinec wrote: Sure, go ahead, can't hurt. The patch is now in the SA trunk. Is it worth opening a ticket and putting it into the 3.3 branch too? Mark looks like Freebsd ports has an older version, so it should be ok. pkg_info | grep NetAddr

SA 3.3.1 and NetAddr::IP 4.034

2010-10-28 Thread Giampaolo Tomassoni
Hi, this morning Gentoo people liked to upgrade NetAddr::IP from 4.033 to 4.034. People with stable systems (a Gentoo feature) actually runs SpamAssassin 3.3.1. Soon after upgrading NetAddr::IP, a lint run reported these: warn: netset: cannot include 0:0:0:0:0:0:0:1/128 as it has already been

Re: SA 3.3.1 and NetAddr::IP 4.034

2010-10-28 Thread Mark Martinec
On Thursday 28 October 2010 14:29:41 Giampaolo Tomassoni wrote: this morning Gentoo people liked to upgrade NetAddr::IP from 4.033 to 4.034. People with stable systems (a Gentoo feature) actually runs SpamAssassin 3.3.1. Soon after upgrading NetAddr::IP, a lint run reported these:

Re: SA 3.3.1 and NetAddr::IP 4.034

2010-10-28 Thread Mark Martinec
Looking into it... I know NetAddr::IP recently got a re-design and probably SA have to cope with this. Looks like a but in NetAddr::IP 4.034, it forgets to adjust the CIDR mask when converting an IPv4 address to an IPv6 notation: correct (NetAddr-IP-4.033): $ perl -le 'use NetAddr::IP;

RE: SA 3.3.1 and NetAddr::IP 4.034

2010-10-28 Thread Giampaolo Tomassoni
Looking into it... I know NetAddr::IP recently got a re-design and probably SA have to cope with this. Looks like a but in NetAddr::IP 4.034, it forgets to adjust the CIDR mask when converting an IPv4 address to an IPv6 notation: correct (NetAddr-IP-4.033): $ perl -le 'use

RE: SA 3.3.1 and NetAddr::IP 4.034

2010-10-28 Thread Giampaolo Tomassoni
Mmmh. In fact it seems they bobbed few lines from 4.033... You sure new6 may be used with IPv4 address, huh? If you confirm this, I can take care of reporting the bug to upstream. Giampaolo Aha, you're too fast! ;) Giampaolo Mark

Re: SA 3.3.1 and NetAddr::IP 4.034

2010-10-28 Thread Mark Martinec
Looks like a but in NetAddr::IP 4.034, it forgets to adjust the CIDR mask when converting an IPv4 address to an IPv6 notation: s/but/BUG/:) correct (NetAddr-IP-4.033): $ perl -le 'use NetAddr::IP; print NetAddr::IP-new6(127.0.0.0/8)' 0:0:0:0:0:0:7F00:0/104 wrong

RE: SA 3.3.1 and NetAddr::IP 4.034

2010-10-28 Thread Giampaolo Tomassoni
If you confirm this, I can take care of reporting the bug to upstream. Please do so, thanks! I'm too late: Steve Huff already did it... See: https://rt.cpan.org/Public/Bug/Display.html?id=62521 . Giampaolo Mark