Re: subversion-1.11.1/subversion/libsvn_client/upgrade.c:353: poor error checking ?

2019-01-12 Thread Branko Čibej
On 12.01.2019 16:32, David Binderman wrote: > Hello there, > > subversion-1.11.1/subversion/libsvn_client/upgrade.c:353] -> > [subversion-1.11.1/subversion/libsvn_client/upgrade.c:358]: (style) The if > condition is the same as the previous if condition > > Source code is > > if (!err) >

subversion-1.11.1/subversion/libsvn_client/upgrade.c:353: poor error checking ?

2019-01-12 Thread David Binderman
Hello there, subversion-1.11.1/subversion/libsvn_client/upgrade.c:353] -> [subversion-1.11.1/subversion/libsvn_client/upgrade.c:358]: (style) The if condition is the same as the previous if condition Source code is if (!err) externals_parent_url = svn_path_url_add_component2(