Re: Svnadmin verify question

2021-11-03 Thread Luke Mauldin
Does the Svnadmin verify do checksum checks? How does it verify validity? > On Nov 3, 2021, at 1:44 PM, Nathan Hartman wrote: > > On Tue, Nov 2, 2021 at 5:09 PM Luke Mauldin wrote: >> >> Can anyone tell me the details of the svnadmin verify command? Does >> subversion store any internal

Re: Svnadmin verify question

2021-11-03 Thread Nathan Hartman
On Tue, Nov 2, 2021 at 5:09 PM Luke Mauldin wrote: > > Can anyone tell me the details of the svnadmin verify command? Does > subversion store any internal hash of each commit to verify its correctness > and that it has not changed over time due to disk/memory errors or software > bugs? > >

Re: Use-after-free of object-pools in subversion/libsvn_repos/authz.c

2021-11-03 Thread Thomas Weißschuh
On 2021-11-03 17:14+0100, Stefan Sperling wrote: > On Wed, Nov 03, 2021 at 04:47:39PM +0100, Thomas Weißschuh wrote: > > The svn_atomic__init_once() inside svn_repos_authz_initialize() seems to > > work > > correctly. synchronized_authz_initialize() is only executed once. > > > > I am arguing

Re: Use-after-free of object-pools in subversion/libsvn_repos/authz.c

2021-11-03 Thread Stefan Sperling
On Wed, Nov 03, 2021 at 05:21:19PM +0100, Thomas Weißschuh wrote: > On 2021-11-03 17:14+0100, Stefan Sperling wrote: > > On Wed, Nov 03, 2021 at 04:47:39PM +0100, Thomas Weißschuh wrote: > > > The svn_atomic__init_once() inside svn_repos_authz_initialize() seems to > > > work > > > correctly.

Re: Use-after-free of object-pools in subversion/libsvn_repos/authz.c

2021-11-03 Thread Thomas Weißschuh
On 2021-11-03 17:14+0100, Stefan Sperling wrote: > On Wed, Nov 03, 2021 at 04:47:39PM +0100, Thomas Weißschuh wrote: > > The svn_atomic__init_once() inside svn_repos_authz_initialize() seems to > > work > > correctly. synchronized_authz_initialize() is only executed once. > > > > I am arguing

Re: Use-after-free of object-pools in subversion/libsvn_repos/authz.c

2021-11-03 Thread Stefan Sperling
On Wed, Nov 03, 2021 at 04:47:39PM +0100, Thomas Weißschuh wrote: > The svn_atomic__init_once() inside svn_repos_authz_initialize() seems to work > correctly. synchronized_authz_initialize() is only executed once. > > I am arguing that it should *not* be executed only once because the pools that

Re: Use-after-free of object-pools in subversion/libsvn_repos/authz.c

2021-11-03 Thread Thomas Weißschuh
On 2021-11-03 16:34+0100, Stefan Sperling wrote: > On Wed, Nov 03, 2021 at 04:21:34PM +0100, Thomas Weißschuh wrote: > > Hi everybody, > > > > While investigating persistent segmentation faults in mod_dav_svn I found > > invalid uses of objectpools in subversion/libsnv_repos/authz.c. > > > > In

Re: Use-after-free of object-pools in subversion/libsvn_repos/authz.c

2021-11-03 Thread Stefan Sperling
On Wed, Nov 03, 2021 at 04:21:34PM +0100, Thomas Weißschuh wrote: > Hi everybody, > > While investigating persistent segmentation faults in mod_dav_svn I found > invalid uses of objectpools in subversion/libsnv_repos/authz.c. > > In svn_repos_authz_initialize() the objectpools passed in during

Use-after-free of object-pools in subversion/libsvn_repos/authz.c

2021-11-03 Thread Thomas Weißschuh
Hi everybody, While investigating persistent segmentation faults in mod_dav_svn I found invalid uses of objectpools in subversion/libsnv_repos/authz.c. In svn_repos_authz_initialize() the objectpools passed in during the configuration phase are stored in static variables. For some reason the